Fix 75496: Android-Chat-using header markdown, typing texts from the third line not fit on composer box by annaweber830 · Pull Request #77607 · Expensify/App

annaweber830 · 2025-12-13T12:14:08Z

Explanation of Change

Fixed Issues

$ #75496
PROPOSAL:#75496 (comment)

Tests

Open app
Navigate to any conversation
Type header markdown # and some texts for 4 lines
Send message
Hold the message for open menu and select Edit comment
Verify the text fits into the composer box without being cut off.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open app
Navigate to any conversation
Type header markdown # and some texts for 4 lines
Send message
Hold the message for open menu and select Edit comment
Verify the text fits into the composer box without being cut off.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-13.at.3.31.03.AM.mp4

Android: mWeb Chrome

Screen.Recording.2025-12-13.at.3.39.00.AM.mp4

iOS: Native

Screen.Recording.2025-12-13.at.4.09.30.AM.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-13.at.4.10.53.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-13.at.3.44.20.AM.mp4

melvin-bot · 2025-12-13T12:14:14Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-13T13:22:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/styles/index.ts	`46.85% <ø> (+0.30%)`	⬆️
src/styles/utils/index.ts	`49.77% <100.00%> (ø)`
... and 367 files with indirect coverage changes

dubielzyk-expensify · 2025-12-15T09:58:07Z

Videos look good to me 👍

eVoloshchak · 2025-12-15T11:44:01Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

                    onKeyPress={handleKeyPress}
                    textAlignVertical="top"
-                    style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : styles.textInputCollapseCompose]}
+                    style={Platform.OS === 'android' ? StyleSheet.flatten([...composerStyle, styles.androidComposerFix]) : composerStyle}


@annaweber830, according to https://github.com/Expensify/App/blob/main/contributingGuides/philosophies/CROSS-PLATFORM.md#platform-specific-file-extensions

Platform specific code MUST be placed in dedicated files and folders

But I don't think it makes sense to create a separate *.android.ts file for this case, let's move Platform.OS check directly to src/styles/index file (textInputCollapseCompose) so it's consistent with the rest of the app. This will also allow us to get rid of androidComposerFix name

Hi @eVoloshchak I updated my PR.

eVoloshchak · 2025-12-17T19:50:51Z

Screen.Recording.2025-12-17.at.20.48.13.mov

@annaweber830, this is resolved in normal composer, but text is still cut off when editing the message

annaweber830 · 2025-12-17T20:53:34Z

Screen.Recording.2025-12-17.at.20.48.13.mov
@annaweber830, this is resolved in normal composer, but text is still cut off when editing the message

I fixed this issue. I updated my PR.

eVoloshchak · 2025-12-19T13:37:23Z

@annaweber830, nice! And since we use different styles for full-size composer (isComposerFullSize), this fix isn't applied when you expand it

Screen.Recording.2025-12-19.at.14.36.01.mov

…5496

annaweber830 · 2025-12-22T21:39:31Z

@annaweber830, nice! And since we use different styles for full-size composer (isComposerFullSize), this fix isn't applied when you expand it

Screen.Recording.2025-12-19.at.14.36.01.mov

Hi @eVoloshchak I updated my PR.

eVoloshchak · 2025-12-25T11:03:26Z

src/styles/index.ts

            alignSelf: 'stretch',
            flex: 1,
            maxHeight: '100%',
            verticalAlign: 'top',


Can this be moved to textInputCompose? Since we use this style in both components

Hi @eVoloshchak I updated my PR.

eVoloshchak · 2025-12-28T17:48:56Z

src/styles/utils/index.ts

        }

-        const composerLineHeight = styles.textInputCompose.lineHeight ?? 0;
+        const composerLineHeight = variables.lineHeightXLarge;


Why is this change needed? It's already lineHeight: variables.lineHeightXLarge in textInputCompose

On Android, styles.textInputCompose.lineHeight is undefined, so the height of the composer is 0 in the original code.
Therefore, we need to explicitly set the composer height, and I have updated the code accordingly.

eVoloshchak · 2025-12-30T17:15:14Z

src/styles/utils/index.ts

        }

-        const composerLineHeight = styles.textInputCompose.lineHeight ?? 0;
+        const composerLineHeight = Platform.OS === 'android' ? variables.lineHeightXLarge : (styles.textInputCompose.lineHeight ?? 0);


But isn't this the same? styles.textInputCompose.lineHeight is already defined as variables.lineHeightXLarge

App/src/styles/index.ts

Line 2095 in 6913f8b

lineHeight: variables.lineHeightXLarge,

On Android, styles.textInputCompose.lineHeight is undefined, so the height of the composer is 0 in the original code.
Therefore, we need to explicitly set the composer height, and I have updated the code accordingly.

Ah, I see. In that case, could we just do const composerLineHeight = variables.lineHeightXLarge ?? 0
?

arosiclair · 2026-01-06T13:31:59Z

bump for review @eVoloshchak

eVoloshchak · 2026-01-07T10:22:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-07.at.12.01.16.mov

Android: mWeb Chrome

Screen.Recording.2026-01-07.at.12.02.47.mov

iOS: HybridApp

Screen.Recording.2026-01-07.at.12.05.49.mov

iOS: mWeb Safari

Screen.Recording.2026-01-07.at.12.08.14.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-06.at.16.32.40.mov

eVoloshchak

Looking good!
@annaweber830, could you please change the latest test step to

Verify the text fits into the composer box without being cut off

And add tests from #12669 here, according to the comment in styles.ts

Be extremely careful when editing the compose styles, as it is easy to introduce regressions. Make sure you run the following tests against any changes: #12669

OSBotify · 2026-01-07T15:24:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-08T16:48:16Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:17:15Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:13:37Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:20:33Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

annaweber830 added 2 commits December 13, 2025 02:51

fix: android chat header markdown error

f915afa

fix: error

b42fe7f

annaweber830 requested review from a team as code owners December 13, 2025 12:14

melvin-bot bot assigned annaweber830 Dec 13, 2025

melvin-bot bot requested review from eVoloshchak and trjExpensify December 13, 2025 12:14

melvin-bot bot removed request for a team and trjExpensify December 13, 2025 12:14

eVoloshchak reviewed Dec 15, 2025

View reviewed changes

fix: platform check

bbf2eed

fix: edit comment error

cf1710a

annaweber830 requested a review from eVoloshchak December 18, 2025 07:00

annaweber830 added 2 commits December 22, 2025 11:13

Merge branch 'main' of https://github.com/annaweber830/App into fix-7…

fbdcec9

…5496

fix: expand error

e65a413

eVoloshchak reviewed Dec 25, 2025

View reviewed changes

fix: code optimize

6cae652

eVoloshchak reviewed Dec 28, 2025

View reviewed changes

annaweber830 added 2 commits December 28, 2025 22:20

fix: height

87415a0

fix: prettier

6913f8b

eVoloshchak reviewed Dec 30, 2025

View reviewed changes

annaweber830 added 2 commits January 3, 2026 17:14

fix: composer height

a2c28e8

fix: prettier and lint

bcfb443

annaweber830 requested a review from eVoloshchak January 6, 2026 14:35

eVoloshchak approved these changes Jan 7, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair January 7, 2026 11:19

arosiclair approved these changes Jan 7, 2026

View reviewed changes

arosiclair merged commit 96f845c into Expensify:main Jan 7, 2026
31 checks passed

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

melvin-bot bot mentioned this pull request Jan 9, 2026

[Payment due] [$250] Android-Chat-using header markdown, typing texts from the third line not fit on composer box #75496

Closed

8 tasks

Conversation

annaweber830 commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 13, 2025

Uh oh!

codecov bot commented Dec 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dubielzyk-expensify commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Dec 17, 2025

Uh oh!

annaweber830 commented Dec 17, 2025

Uh oh!

eVoloshchak commented Dec 19, 2025

Uh oh!

annaweber830 commented Dec 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Jan 6, 2026

Uh oh!

eVoloshchak commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

annaweber830 commented Dec 13, 2025 •

edited

Loading

codecov bot commented Dec 13, 2025 •

edited by github-actions bot

Loading

eVoloshchak commented Jan 7, 2026 •

edited

Loading