Show concierge system message after submit/approval action by bernhardoj · Pull Request #77638 · Expensify/App

bernhardoj · 2025-12-14T15:59:26Z

Explanation of Change

Add a Concierge system message that appears after submit/approval actions in workspaces with Dynamic External Workflow (DEW) multi-level approval enabled.

Fixed Issues

$ #75223
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a DEW-enabled workspace with multi-level approval and invite 2 members

Open the WS chat
Create a report with 2 expenses and submit
Verify there is a report routed to {1st_approver} due to custom approval workflow concierge message is shown after the submitted message
As the 1st approver, approve the expense
Verify there is a report routed to {2nd_approver} due to custom approval workflow concierge message is shown after the approved message
As the 2nd approver, final approve the expense
Verify there is no report routed ... concierge message shown after the approved message

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-14T15:59:32Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-12-14T15:59:33Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-14T16:16:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`86.48% <ø> (ø)`
src/hooks/useOriginalReportID.ts	`75.00% <100.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`73.34% <100.00%> (+0.04%)`	⬆️
src/libs/ReportActionsUtils.ts	`50.00% <100.00%> (+0.84%)`	⬆️
src/libs/ReportUtils.ts	`72.88% <100.00%> (+0.01%)`	⬆️
src/libs/actions/IOU.ts	`64.69% <100.00%> (+0.01%)`	⬆️
...report/ContextMenu/BaseReportActionContextMenu.tsx	`0.00% <ø> (ø)`
...pages/Debug/ReportAction/DebugReportActionPage.tsx	`0.00% <0.00%> (ø)`
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.78% <0.00%> (-0.02%)`	⬇️
... and 8 files with indirect coverage changes

trjExpensify · 2025-12-15T10:11:24Z

@AndrewGable any idea what happened here? It seems to have assigned two of us for the product-pr review?

abzokhattab · 2025-12-15T17:33:44Z

looks like we have some failing pipleines...

AndrewGable · 2025-12-15T17:38:50Z

@trjExpensify Hmm yes, looks like it's duplicating reviews. Can we make an internal E/E issue? I will have to dig into the logs

trjExpensify · 2025-12-16T00:27:53Z

Done: https://github.com/Expensify/Expensify/issues/579111

bernhardoj · 2025-12-16T03:42:26Z

Fixed conflicts and asked for translations here: https://expensify.slack.com/archives/C01GTK53T8Q/p1765856448170749

bernhardoj · 2025-12-16T03:45:00Z

src/libs/ReportActionsUtils.ts

+    reportAction: ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.SUBMITTED> | ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.FORWARDED>,
+): ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.DYNAMIC_EXTERNAL_WORKFLOW_ROUTED> {
+    return {
+        reportActionID: `${reportAction.reportActionID}DEW`,


@francoisl is it fine that I just append DEW to the report action ID of the concierge message?

This is so the ID is consistent every time getDynamicExternalWorkflowRoutedAction is called, so the "Copy message" context menu can work.

bernhardoj · 2025-12-16T04:01:00Z

Looks like the rest of the failing actions are unrelated.

abzokhattab · 2025-12-18T05:40:38Z

Please let me know when the tests are ready .. the changes generally looks good to me

bernhardoj · 2025-12-18T14:14:37Z

Oh, I thought it was a flaky test only. Checking...

…o it

bernhardoj · 2025-12-18T15:33:16Z

@abzokhattab done

trjExpensify · 2025-12-19T17:32:03Z

@abzokhattab can you complete the review ASAP? Thanks!

abzokhattab · 2025-12-20T02:01:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

abzokhattab · 2025-12-20T22:38:58Z

LGTM 🚀🚀 lets fix the eslint check @bernhardoj

bernhardoj · 2025-12-21T14:52:17Z

The lint error comes from #77512

francoisl · 2025-12-21T20:56:58Z

Works great 🚀 I left a comment in the PR about the ESLint issue, I'll send a follow-up PR to fix those.

melvin-bot · 2025-12-21T20:58:00Z

@francoisl looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

francoisl · 2025-12-21T20:58:41Z

looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

ESLint error was unrelated to this PR. I'll send a follow-up PR to fix them.

OSBotify · 2025-12-21T21:07:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-23T00:51:59Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

marcaaron · 2025-12-24T02:00:56Z

Anyone do the Internal QA here? I think it's the last thing blocking the deploy.

OSBotify · 2025-12-24T18:49:06Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

bernhardoj added 3 commits December 14, 2025 23:39

show concierge system message after submit/approval action

997027d

remove log

a0a912a

add missing param

7ef0b5c

bernhardoj requested review from a team as code owners December 14, 2025 15:59

melvin-bot bot assigned bernhardoj Dec 14, 2025

melvin-bot bot requested review from abzokhattab and joekaufmanexpensify December 14, 2025 15:59

melvin-bot bot requested review from a team and removed request for a team December 14, 2025 15:59

melvin-bot bot requested review from trjExpensify and removed request for a team December 14, 2025 15:59

Merge branch 'main' into fix/75223-dew-system-msg-after-submit/approvel

baf7310

lint

fb158b8

francoisl self-requested a review December 15, 2025 18:12

Merge branch 'main' into fix/75223-dew-system-msg-after-submit/approvel

e62b28f

bernhardoj commented Dec 16, 2025

View reviewed changes

lint

11ef3ee

trjExpensify removed request for joekaufmanexpensify and trjExpensify December 16, 2025 15:43

bernhardoj added 2 commits December 18, 2025 11:02

add test

3c87f0e

lint

ff91890

Merge branch 'main' into fix/75223-dew-system-msg-after-submit/approvel

f8ef16b

bernhardoj added 2 commits December 18, 2025 22:25

fix test

80d8218

use getSortedReportActions back and apply withDEWRoutedActionsArray t…

0aa8352

…o it

bernhardoj added 3 commits December 19, 2025 22:24

Merge branch 'main' into fix/75223-dew-system-msg-after-submit/approvel

370ba64

make workflow type optional

7959987

Merge branch 'main' into fix/75223-dew-system-msg-after-submit/approvel

191600f

abzokhattab approved these changes Dec 20, 2025

View reviewed changes

francoisl added the InternalQA This pull request required internal QA label Dec 21, 2025

francoisl approved these changes Dec 21, 2025

View reviewed changes

francoisl merged commit e6dc28b into Expensify:main Dec 21, 2025
32 of 33 checks passed

melvin-bot bot added the Emergency label Dec 21, 2025

francoisl removed the Emergency label Dec 21, 2025

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

melvin-bot bot mentioned this pull request Dec 24, 2025

[Due for payment 2025-12-31] [DEW in NewDot] Display system message after submit/approval action #75223

Closed

Conversation

bernhardoj commented Dec 14, 2025 • edited by francoisl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 14, 2025

Uh oh!

melvin-bot bot commented Dec 14, 2025

Uh oh!

codecov bot commented Dec 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Dec 15, 2025

Uh oh!

abzokhattab commented Dec 15, 2025

Uh oh!

AndrewGable commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Dec 16, 2025

Uh oh!

bernhardoj commented Dec 16, 2025

Uh oh!

bernhardoj Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Dec 16, 2025

Uh oh!

abzokhattab commented Dec 18, 2025

Uh oh!

bernhardoj commented Dec 18, 2025

Uh oh!

bernhardoj commented Dec 18, 2025

Uh oh!

trjExpensify commented Dec 19, 2025

Uh oh!

abzokhattab commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Dec 21, 2025

Uh oh!

francoisl commented Dec 21, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Dec 21, 2025

Uh oh!

francoisl commented Dec 21, 2025

Uh oh!

OSBotify commented Dec 21, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

marcaaron commented Dec 24, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bernhardoj commented Dec 14, 2025 •

edited by francoisl

Loading

codecov bot commented Dec 14, 2025 •

edited by github-actions bot

Loading

AndrewGable commented Dec 15, 2025 •

edited

Loading

abzokhattab commented Dec 20, 2025 •

edited

Loading

abzokhattab commented Dec 20, 2025 •

edited

Loading