[No QA] feat: add DomainAdminDetailsPage.tsx by war-in · Pull Request #77659 · Expensify/App

war-in · 2025-12-15T12:58:53Z

Explanation of Change

This PR adds simple admin details RHP without any buttons. This will unblock further changes, e.g. revoke admin access & reset domain

Fixed Issues

$ #77744
PROPOSAL:

Tests

Go to /domain/domainAccountID/admins
Click on any admin
Verify the RHP is opened and contains the account avatar, and name with the option to copy the email

Offline tests

QA Steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2025-12-15T13:07:31Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
...avigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/ROUTES.ts	`13.23% <0.00%> (-0.02%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`8.54% <0.00%> (-0.02%)`	⬇️
src/pages/domain/Admins/DomainAdminsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/domain/Admins/DomainAdminDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 75 files with indirect coverage changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

ZhenjaHorbach · 2025-12-15T16:55:02Z

I suppose we have the wrong horizontal padding for emails

2025-12-15.17.53.53.mov

ZhenjaHorbach · 2025-12-15T16:56:17Z

Do we need to add the ability to open avatars?
But on Workspace members screen, we can't
So I suppose it's okay

2025-12-15.17.55.28.mov

situchan · 2025-12-15T16:56:55Z

I am stuck on testing iOS. After login, app redirects to OldDot and immediately crashes.

Screen.Recording.2025-12-15.at.10.56.07.PM.mov

ZhenjaHorbach · 2025-12-15T17:00:35Z

I am stuck on testing iOS. After login, app redirects to OldDot and immediately crashes.

Screen.Recording.2025-12-15.at.10.56.07.PM.mov

Let me check also

situchan · 2025-12-15T17:09:31Z

I think we should follow the same pattern as workspace member detail page

Screen.Recording.2025-12-15.at.11.08.22.PM.mov

src/pages/domain/Admins/DomainAdminsPage.tsx

situchan · 2025-12-15T17:25:26Z

I am stuck on testing iOS. After login, app redirects to OldDot and immediately crashes.

Screen.Recording.2025-12-15.at.10.56.07.PM.mov

Nvm. As it's out of scope, I built standalone app and continue testing

war-in · 2025-12-15T17:27:24Z

@situchan Actually, ngrok can't be connected to the native devices so I think we can't test Android and iOS now :/
you can always mock the data but I wonder if we should wait for backend with testing native platforms and test narrow layout in web 🤔

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

situchan · 2025-12-15T17:31:56Z

@situchan Actually, ngrok can't be connected to the native devices so I think we can't test Android and iOS now :/ you can always mock the data but I wonder if we should wait for backend with testing native platforms and test narrow layout in web 🤔

Why not? I connected already and tested native on previous PR.

situchan · 2025-12-15T17:44:24Z

App/src/CONFIG.ts

Lines 39 to 42 in 26c32b9

    
           const ngrokURL = addTrailingForwardSlash(get(Config, 'NGROK_URL', '')); 
        
           const secureNgrokURL = addTrailingForwardSlash(get(Config, 'SECURE_NGROK_URL', '')); 
        
           const secureExpensifyUrl = addTrailingForwardSlash(get(Config, 'SECURE_EXPENSIFY_URL', 'https://secure.expensify.com/')); 
        
           const useNgrok = get(Config, 'USE_NGROK', 'false') === 'true';

I hardcoded this to test native quickly with only js changes. If using .env, you should rebuild the app which takes much time.

const ngrokURL = addTrailingForwardSlash(get(Config, 'NGROK_URL', 'https://xxx.ngrok.io/'));
const secureNgrokURL = addTrailingForwardSlash(get(Config, 'SECURE_NGROK_URL', 'https://xxx.ngrok.io/'));
const useNgrok = true || get(Config, 'USE_NGROK', 'false') === 'true';

war-in · 2025-12-15T18:28:34Z

guys, I think all comments are resolved

situchan · 2025-12-15T18:33:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-12-16.at.12.34.28.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-16.at.12.39.49.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-16.at.12.32.24.AM.mov

situchan

Similar to previously reported bug.
Not found page briefly shows when reload the app.
Not sure if we should block on this. If not blocker, please note this to fix as follow up.

Screen.Recording.2025-12-16.at.12.42.16.AM.mov

situchan · 2025-12-15T19:43:20Z

Please link any existing issue (i.e. #77565) and mark as ready for review.
Then I will approve.

melvin-bot · 2025-12-16T10:28:40Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in · 2025-12-16T10:28:43Z

@situchan ready!

src/pages/domain/Admins/DomainAdminsPage.tsx

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

mountiny

@war-in One question

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

mountiny

Left one comment but please address it in the next PR

mountiny · 2025-12-16T18:26:15Z

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

+    });
+
+    // eslint-disable-next-line rulesdir/no-inline-useOnyx-selector
+    const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {


I think we should rename this to make it clear it is the admin personal details already

Suggested change

const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {

const [adminPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {

OSBotify · 2025-12-16T18:56:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-16T22:49:13Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-17T12:26:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:48:24Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:11:48Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: add DomainAdminDetailsPage.tsx

8de1424

melvin-bot bot assigned war-in Dec 15, 2025

war-in added 2 commits December 15, 2025 16:05

Merge branch 'main' into war-in/domains/add-admin-details-page

948407e

refactor: unpack params

26c32b9

ZhenjaHorbach reviewed Dec 15, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx Show resolved Hide resolved

ZhenjaHorbach reviewed Dec 15, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx Outdated Show resolved Hide resolved

fix: use display name

514e3d2

war-in changed the title ~~feat: add DomainAdminDetailsPage.tsx~~ [No QA] feat: add DomainAdminDetailsPage.tsx Dec 15, 2025

chore: fix prettier

3df3a9e

situchan reviewed Dec 15, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminsPage.tsx Outdated Show resolved Hide resolved

situchan reviewed Dec 15, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx Outdated Show resolved Hide resolved

feat: add Profile to details page and fix padding

83c8ff3

situchan reviewed Dec 15, 2025

View reviewed changes

war-in added 2 commits December 16, 2025 11:27

Merge branch 'main' into war-in/domains/add-admin-details-page

55ecc93

feat: add shouldUseGoBackButton to FullScreenLoadingIndicator

aa73920

war-in marked this pull request as ready for review December 16, 2025 10:28

war-in requested a review from a team as a code owner December 16, 2025 10:28

melvin-bot bot requested review from JmillsExpensify and situchan and removed request for a team and JmillsExpensify December 16, 2025 10:28

melvin-bot bot removed the request for review from a team December 16, 2025 10:28

github-actions bot reviewed Dec 16, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminsPage.tsx Show resolved Hide resolved

github-actions bot reviewed Dec 16, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx Show resolved Hide resolved

situchan approved these changes Dec 16, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny December 16, 2025 12:52

mountiny requested changes Dec 16, 2025

View reviewed changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx Outdated Show resolved Hide resolved

war-in added 2 commits December 16, 2025 17:52

refactor: use selector for personal details onyx subscription

ec43f6a

chore: fix eslint

7e0375c

mountiny approved these changes Dec 16, 2025

View reviewed changes

mountiny merged commit 33eea24 into Expensify:main Dec 16, 2025
32 checks passed

OSBotify mentioned this pull request Dec 16, 2025

Deploy Checklist: New Expensify 2025-12-16 #77818

Closed

	const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {
	const [adminPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {

Conversation

war-in commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

ZhenjaHorbach commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Dec 15, 2025

Uh oh!

ZhenjaHorbach commented Dec 15, 2025

Uh oh!

situchan commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

situchan commented Dec 15, 2025

Uh oh!

war-in commented Dec 15, 2025

Uh oh!

Uh oh!

situchan commented Dec 15, 2025

Uh oh!

situchan commented Dec 15, 2025

Uh oh!

war-in commented Dec 15, 2025

Uh oh!

situchan commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 15, 2025

Uh oh!

melvin-bot bot commented Dec 16, 2025

Uh oh!

war-in commented Dec 16, 2025

Uh oh!

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

Reviewers

war-in commented Dec 15, 2025 •

edited

Loading

codecov bot commented Dec 15, 2025 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Dec 15, 2025 •

edited

Loading

ZhenjaHorbach commented Dec 15, 2025 •

edited

Loading

situchan commented Dec 15, 2025 •

edited

Loading

situchan commented Dec 15, 2025 •

edited

Loading