Skip to content

[NoQA] Revert "Refactor: Deprecate getPolicy (part 2)"#77698

Merged
AndrewGable merged 1 commit intomainfrom
revert-76836-refactor-getPolicy-2
Dec 15, 2025
Merged

[NoQA] Revert "Refactor: Deprecate getPolicy (part 2)"#77698
AndrewGable merged 1 commit intomainfrom
revert-76836-refactor-getPolicy-2

Conversation

@tgolen
Copy link
Copy Markdown
Contributor

@tgolen tgolen commented Dec 15, 2025

Reverts #76836 because we found that it caused some unit tests to start timing out. See this slack thread

@tgolen tgolen requested a review from mountiny December 15, 2025 20:26
@tgolen tgolen self-assigned this Dec 15, 2025
@tgolen tgolen requested review from a team as code owners December 15, 2025 20:26
@melvin-bot melvin-bot bot requested review from stitesExpensify and trjExpensify and removed request for a team December 15, 2025 20:26
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Dec 15, 2025

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert! Lets wait for the job2 jest to pass

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useGetExpensifyCardFromReportAction.ts 100.00% <100.00%> (ø)
...ou/request/step/IOURequestStepPerDiemWorkspace.tsx 5.55% <ø> (ø)
...orkspace/categories/CategoryDefaultTaxRatePage.tsx 0.00% <ø> (ø)
...s/workspace/members/WorkspaceMemberNewCardPage.tsx 0.00% <ø> (ø)
src/pages/workspace/tags/TagApproverPage.tsx 0.00% <ø> (ø)
src/libs/actions/TeachersUnite.ts 0.00% <0.00%> (ø)
src/pages/TransactionDuplicate/ReviewTaxCode.tsx 0.00% <0.00%> (ø)
...ages/home/report/SystemChatReportFooterMessage.tsx 12.50% <0.00%> (ø)
src/libs/actions/Policy/Category.ts 44.19% <0.00%> (-5.62%) ⬇️
src/libs/actions/Policy/Tag.ts 64.63% <0.00%> (-5.18%) ⬇️
... and 5 files with indirect coverage changes

@mountiny mountiny changed the title Revert "Refactor: Deprecate getPolicy (part 2)" [NoQA] Revert "Refactor: Deprecate getPolicy (part 2)" Dec 15, 2025
@AndrewGable AndrewGable merged commit a430ca9 into main Dec 15, 2025
33 of 37 checks passed
@AndrewGable AndrewGable deleted the revert-76836-refactor-getPolicy-2 branch December 15, 2025 20:55
@melvin-bot melvin-bot bot added the Emergency label Dec 15, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Dec 15, 2025

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@AndrewGable
Copy link
Copy Markdown
Contributor

Straight revert, no checklists, not emergency

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants