[No QA] [BYOC] [Bulk Card Assignments] Release 1: Workspace Company Cards Table by chrispader · Pull Request #77701 · Expensify/App

chrispader · 2025-12-15T21:18:29Z

Explanation of Change

Changes the company cards list to show both assigned and unassigned cards and updates the layout to list to be a three-column table (not yet sortable/filterable/searchable), based on the according design doc

Fixed Issues

$ #77702
PROPOSAL:

Tests

Verify that no errors appear in the JS console

None needed.

Offline tests

None needed.

QA Steps

Verify that no errors appear in the JS console

None needed.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-15T21:18:35Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-12-15T21:25:22Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-12-15T21:28:53Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

+                            if (assignedCard) {
+                                if (!assignedCard?.accountID || !assignedCard?.fundID) {
+                                    return;
+                                }


❌ PERF-2 (docs)

This expensive function call (getCardFeedIcon()) is executed unconditionally inside renderItem for every list item, but it's only used when the card is unassigned (!assignedCard). This wastes computation for all assigned cards.

Suggested fix: Move this call inside a conditional check or compute it lazily only when needed:

const cardFeedIcon = !assignedCard ? getCardFeedIcon(selectedFeed as CompanyCardFeed, illustrations, companyCardFeedIcons) : undefined;

Or better, check if assignedCard exists first and only call getCardFeedIcon in the unassigned branch where it's actually used.

codecov · 2025-12-15T21:34:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...yCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx	`0.00% <0.00%> (ø)`
...rkspace/companyCards/WorkspaceCompanyCardsPage.tsx	`0.00% <0.00%> (ø)`
src/components/FeedSelector.tsx	`0.00% <0.00%> (ø)`
...nyCards/WorkspaceCompanyCardsListHeaderButtons.tsx	`0.00% <0.00%> (ø)`
...rkspace/companyCards/WorkspaceCompanyCardsList.tsx	`0.00% <0.00%> (ø)`
...pace/companyCards/WorkspaceCompanyCardsListRow.tsx	`0.00% <0.00%> (ø)`
src/hooks/useAssignCard.ts	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

tgolen · 2025-12-15T21:33:17Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

+                            if (assignedCard) {
+                                if (!assignedCard?.accountID || !assignedCard?.fundID) {
+                                    return;
+                                }
+
+                                return Navigation.navigate(
+                                    ROUTES.WORKSPACE_COMPANY_CARD_DETAILS.getRoute(
+                                        policyID,
+                                        assignedCard.cardID.toString(),
+                                        getCompanyCardFeedWithDomainID(assignedCard?.bank as CompanyCardFeed, assignedCard.fundID),
+                                    ),
+                                );


Would it be better to put this logic in the parent inside the onAssignCard() callback?

No, that just makes the logic more complex, since we need the assignedCard value which we get within the list component

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

Co-authored-by: Tim Golen <tgolen@gmail.com>

tgolen · 2025-12-15T22:27:07Z

Looks like quite a few of the checks are failing, but the code looks good overall

tgolen · 2025-12-15T22:28:06Z

No C+ or product person necessary for this PR. We'll have you review the final PRs that go to main

chrispader · 2025-12-15T22:47:32Z

@tgolen The TS checks are failing because we need to run the translations script as in: #77701 (comment)

Removed the manual memoization reported by React Compiler Compliance Check, but the check is faulty anyway atm (We're updating it here atm)

chrispader · 2025-12-15T22:59:56Z

@tgolen i think we can tackle Code coverage at the end of the release/sprint PR, right? I think that might smarter

OSBotify · 2025-12-23T00:52:03Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T18:49:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chrispader added 13 commits December 15, 2025 12:37

feat: implement initial company cards table

95c04c3

fix: card feed icons and clickables

05c0fd8

feat: extract card assignment logic out of WorkspaceCompanyCardsPage

d1f0ba7

feat: move card assignment to rows

118d29d

fix: remove duplicate variable name

3c41297

fix: don't change layout in header bar

749eaf2

feat: use shouldShowAssignCardButton

d729944

feat: implement new header buttons layout

d4db7d1

refactor: re-arrange code

606fa5b

fix: useAssignCard feed type

7d9808c

fix: style/design change requests

4acd890

fix: add Assign translation key

3cf6a68

fix: style/design requests

800b2a9

melvin-bot bot assigned chrispader Dec 15, 2025

chrispader changed the base branch from main to byoc-bulk-card-assign-r1 December 15, 2025 21:18

chrispader added 2 commits December 15, 2025 16:21

Update es.ts

4b39821

refactor: move things around

46e9a26

chrispader marked this pull request as ready for review December 15, 2025 21:25

chrispader requested review from a team as code owners December 15, 2025 21:25

melvin-bot bot requested review from joekaufmanexpensify and rojiphil and removed request for a team December 15, 2025 21:25

chrispader changed the title ~~[BYOC] [Bulk Card Assignments] Release 1: Workspace Company Cards Table~~ [No QA] [BYOC] [Bulk Card Assignments] Release 1: Workspace Company Cards Table Dec 15, 2025

github-actions bot reviewed Dec 15, 2025

View reviewed changes

fix: address Codex perf improvement

4c66277

fix: remove manual memoization from useAssignCard.tsx

570a3f0

tgolen requested changes Dec 15, 2025

View reviewed changes

chrispader and others added 10 commits December 15, 2025 21:37

Update src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

4cbb874

Co-authored-by: Tim Golen <tgolen@gmail.com>

fix: rename to plaidIconUrl

9ebe23b

refactor: update onAssignCard prop comments

cb3603e

refactor: add comment for shouldUseNarrowTableRowLayout

d1b3426

refactor: simplify code with better early return

2ed8cfc

Delete WorkspaceCardListRow.tsx

30b18e1

rename file

8f21b8d

fix: import

ff8159c

Create WorkspaceCardListRow.tsx

4da71d2

fix: remove unnecessary shouldShowAssignCardButton value

b5c42cd

tgolen approved these changes Dec 15, 2025

View reviewed changes

tgolen removed request for joekaufmanexpensify and rojiphil December 15, 2025 22:27

remove manual memoization on successfully compiled file

13fdb02

chrispader added 2 commits December 15, 2025 18:01

fix: Expensicons error

ae274a5

fix: Expensicons error

d8f92ed

carlosmiceli self-requested a review December 16, 2025 14:50

carlosmiceli approved these changes Dec 16, 2025

View reviewed changes

tgolen merged commit ac82086 into Expensify:byoc-bulk-card-assign-r1 Dec 16, 2025
23 of 25 checks passed

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

jponikarchuk mentioned this pull request Dec 23, 2025

[Due for payment 2026-01-20] [$250] Company card - Wrong button name #78376

Closed

7 tasks

melvin-bot bot mentioned this pull request Dec 24, 2025

[Due for payment 2025-12-31] [BYOC] Bulk assign cards - Show All Cards in Unified Table #77702

Closed

Conversation

chrispader commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 15, 2025

Uh oh!

melvin-bot bot commented Dec 15, 2025

Uh oh!

github-actions bot Dec 15, 2025

Choose a reason for hiding this comment

❌ PERF-2 (docs)

Uh oh!

codecov bot commented Dec 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgolen Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

chrispader Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tgolen commented Dec 15, 2025

Uh oh!

tgolen commented Dec 15, 2025

Uh oh!

chrispader commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrispader commented Dec 15, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chrispader commented Dec 15, 2025 •

edited

Loading

codecov bot commented Dec 15, 2025 •

edited by github-actions bot

Loading

chrispader commented Dec 15, 2025 •

edited

Loading