Support Time expense type in Search by mhawryluk · Pull Request #77753 · Expensify/App

mhawryluk · 2025-12-16T12:23:48Z

Explanation of Change

Displays type icon/label for time expenses in Reports tab. Allows filtering by expense-type:time.

Fixed Issues

$ #77381
$ #77382
PROPOSAL: N/A

Tests

Create a time expense in old dot.
Open Reports tab in new dot.
Look for the created expense.
In wide view the type column should show a clock icon.
In narrow view there should be "time" label next to date.
Click "Filters" > "Expense type"
Select "Time", save the filter
The list should correctly show only the time expenses.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2025-12-18.o.11.36.59.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2025-12-18.o.11.33.07.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-18.at.11.28.47.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-18.at.11.22.58.mp4

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-12-18.o.11.17.23.mov

codecov · 2025-12-16T12:33:41Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.47% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`72.40% <100.00%> (+0.11%)`	⬆️
src/libs/SearchUIUtils.ts	`58.85% <0.00%> (-0.09%)`	⬇️
...mponents/TransactionItemRow/DataCells/TypeCell.tsx	`71.42% <33.33%> (-11.91%)`	⬇️
... and 7 files with indirect coverage changes

JakubKorytko

Code LGTM

melvin-bot · 2025-12-18T10:46:08Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-12-18T11:59:22Z

I am stuck on enable time feature on OldDot. Could anyone help please?

JmillsExpensify

Part of an on-going product initiative.

DylanDylann · 2025-12-19T05:01:59Z

src/components/TransactionItemRow/DataCells/TypeCell.tsx

-            height={20}
-            width={20}
+            height={typeIconSize}
+            width={typeIconSize}


Why do we need to adjust the size of the time icon? Can we use the correct icon size instead of manually customizing the size for each item?

the icon was 16x16 on the design, so I had to customize the size based on the type to keep all the others at 20x20. I don't think there's another way to achieve this here, without modifying the svg itself. I guess this difference in size is just due to visual adjustment, cause the clock icon looks unusually big when it has the same size as the others

@dannymcclain this is what it looks like now (cash icon is 20x20, clock 16x16). is it okay?

I mean that we should request time icon in correct size from the design team

oh, okay. @Expensify/design could we get a modified icon? 🙏

🤔 Hmm, let's try this one:
clock.svg.zip

And here's a mock with all the different icons at 20x20 using the clock icon I just provided above:

thanks. after compression, the new file is the same as the one we have currently. but I think it looks like it does on the mock, so I think it's okay now 😅

DylanDylann · 2025-12-19T05:07:26Z

@mhawryluk Please merge the latest main. Some changes have already been merged in #77508

DylanDylann · 2025-12-19T05:09:47Z

The rest looks fine

DylanDylann · 2025-12-22T06:08:08Z

@mhawryluk Please ping me when the update is completed

DylanDylann · 2025-12-22T09:06:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-22.at.15.18.02.mov

Android: mWeb Chrome

Screen.Recording.2025-12-22.at.15.20.01.mov

iOS: HybridApp

Screen.Recording.2025-12-22.at.15.18.56.mov

iOS: mWeb Safari

Screen.Recording.2025-12-22.at.15.25.12.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-22.at.15.13.40.mov

DylanDylann

LGTM

DylanDylann · 2026-01-07T11:23:01Z

@mhawryluk Could you merge the new main?

cc @grgia for final review

mhawryluk · 2026-01-07T11:33:20Z

@mhawryluk Could you merge the new main?

cc @grgia for final review

merged main ^^

OSBotify · 2026-01-07T17:32:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-08T16:48:25Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:17:24Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:13:46Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:20:42Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Display Time expense type in Search

a7f4f32

melvin-bot bot assigned mhawryluk Dec 16, 2025

Merge branch 'main' into feat/time-expenses-in-search

9ec5c3a

mhawryluk added 2 commits December 16, 2025 14:32

Allow filtering by time

aeec8b5

Extend getTransactionType unit tests with time type

59ceb90

mhawryluk changed the title ~~Display Time expense type in Search~~ Support Time expense type in Search Dec 16, 2025

JakubKorytko approved these changes Dec 18, 2025

View reviewed changes

mhawryluk marked this pull request as ready for review December 18, 2025 10:46

mhawryluk requested review from a team as code owners December 18, 2025 10:46

melvin-bot bot requested review from DylanDylann and JmillsExpensify and removed request for a team December 18, 2025 10:46

melvin-bot bot removed the request for review from a team December 18, 2025 10:46

JmillsExpensify previously approved these changes Dec 18, 2025

View reviewed changes

DylanDylann reviewed Dec 19, 2025

View reviewed changes

Merge branch 'main' into feat/time-expenses-in-search

6eb6b1f

mhawryluk dismissed JmillsExpensify’s stale review via 6eb6b1f December 19, 2025 09:50

Merge branch 'main' into feat/time-expenses-in-search

5560e49

Make all typecell icons same size

ef86a47

mhawryluk requested a review from DylanDylann December 22, 2025 07:24

DylanDylann approved these changes Dec 22, 2025

View reviewed changes

melvin-bot bot requested a review from grgia December 22, 2025 09:07

Merge branch 'main' into feat/time-expenses-in-search

851d8b2

mhawryluk mentioned this pull request Jan 7, 2026

Update MoneyRequestView for time expenses #77748

Merged

51 tasks

grgia approved these changes Jan 7, 2026

View reviewed changes

grgia merged commit 355ed95 into Expensify:main Jan 7, 2026
30 checks passed

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

This was referenced Jan 9, 2026

[Time Tracking] Update UI To View Time Expense Type in Search #77381

Closed

[Due for payment 2026-01-16] [Time Tracking] Allow Filtering by Time in Search #77382

Closed

Conversation

mhawryluk commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 18, 2025

Uh oh!

DylanDylann commented Dec 18, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mhawryluk Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mhawryluk Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

dannymcclain Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

mhawryluk Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Dec 19, 2025

Uh oh!

DylanDylann commented Dec 19, 2025

Uh oh!

DylanDylann commented Dec 22, 2025

Uh oh!

DylanDylann commented Dec 22, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 7, 2026

Uh oh!

mhawryluk commented Jan 7, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mhawryluk commented Dec 16, 2025 •

edited

Loading

codecov bot commented Dec 16, 2025 •

edited by github-actions bot

Loading