Implement loading skeleton for Company Cards table#77804
Implement loading skeleton for Company Cards table#77804carlosmiceli merged 17 commits intobyoc-bulk-card-assign-r1-card-flowfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
tgolen
left a comment
There was a problem hiding this comment.
There are a couple of ESLint errors that should probably be fixed in this PR too.
…m-company-cards-loading-skeleton
f1f5db8 to
59c976b
Compare
|
@hungvu193 could you also review this PR after you review the RHP one please? Thank you! 🙇 |
Sure thing |
| useEffect(() => { | ||
| fetchCompanyCards(); | ||
| }, [fetchCompanyCards]); | ||
| }, [policyID, domainOrWorkspaceAccountID]); |
There was a problem hiding this comment.
Sorry, could you explain what you mean?
There was a problem hiding this comment.
Ahhh, I see! I'm a bit rusty with App PRs, thanks!
|
|
||
| const {isOffline} = useNetwork({onReconnect: fetchCompanyCards}); | ||
| const isLoading = !isOffline && (!cardFeeds || (!!defaultFeed?.isLoading && isEmptyObject(cardsList))); | ||
| const isLoading = !isOffline && !cardFeeds; |
There was a problem hiding this comment.
This condition doesn't seem to cover reloading case, even I have a card, I still see the Empty State briefly show after reloading the page.
Screen.Recording.2025-12-18.at.16.59.25.mov
Co-authored-by: Hans <hungvu193@users.noreply.github.com>
e92856b
into
byoc-bulk-card-assign-r1-card-flow
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.86-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀
|

Explanation of Change
Fixed Issues
$ #77793
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari