fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual v2 by nkdengineer · Pull Request #77849 · Expensify/App

nkdengineer · 2025-12-17T05:00:24Z

Explanation of Change

fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual

Fixed Issues

$ #74911
PROPOSAL: #74911 (comment)

Tests

Navigate to any workspace chat
Create a manual expense to step Confirm details
Fill merchant and select category
Click on "+" button and add a receipt
Click on Create expense
Click on FAB
Select Scan receipt at Quick action
Add a receipt and observe Confirm details page
Verify that the confirmation page is displayed as scan request

Android – Add Expense (Camera Icon) – Incorrect Redirect After Selecting Recipient #77606

Tap Add Expense (camera icon).
Capture a picture of the receipt.
Select a recipient.
Verify that the confirmation page appears

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-05.at.14.03.08.mov

Screen.Recording.2025-12-16.at.00.22.33.mov

Android: mWeb Chrome

Screen.Recording.2025-12-05.at.14.02.07.mov

iOS: Native

Screen.Recording.2025-12-05.at.14.08.28.mov

iOS: mWeb Safari

Screen.Recording.2025-12-05.at.14.04.23.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-05.at.14.01.10.mov

…B is scan receipt but confirm detail display as manual""

codecov · 2025-12-17T05:09:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/iou/request/IOURequestStartPage.tsx	`73.63% <100.00%> (-11.88%)`	⬇️
... and 16 files with indirect coverage changes

melvin-bot · 2025-12-21T15:53:40Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2026-01-02T06:29:43Z

@rojiphil Friendly bump

rojiphil · 2026-01-03T02:14:10Z

Reviewing today

rojiphil · 2026-01-03T12:14:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

77849-android-hybrid-001.mp4

Android: mWeb Chrome

77849-mweb-chrome-001.mp4

iOS: HybridApp

77849-ios-hybrid-001.mp4

iOS: mWeb Safari

77849-mweb-safari-001.mp4

MacOS: Chrome / Safari

77849-web-chrome-001.mp4

rojiphil

Thanks @nkdengineer for the PR.

@mjasikowski Changes LGTM and works well.
Over to you. Thanks

mjasikowski · 2026-01-07T08:34:56Z

src/pages/iou/request/IOURequestStartPage.tsx

+        }
+        setSelectedTab(lastSelectedTab);
+        // eslint-disable-next-line react-compiler/react-compiler
+        // eslint-disable-next-line react-hooks/exhaustive-deps


Can you add a comment so everyone knows why the ESLint rules are disabled without looking for context?

@mjasikowski I updated

@nkdengineer sorry, but your comment doesn't explain why the rules are getting disabled, It only explains the usage of useEffect()

@mjasikowski I updated.

OSBotify · 2026-01-13T03:38:53Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:55:12Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2026-02-02T08:43:37Z

src/pages/iou/request/IOURequestStartPage.tsx

+        // We only want to set the selected tab when selectedTab is not set yet, don't want to run this effect again when lastSelectedTab changes
+        // eslint-disable-next-line react-compiler/react-compiler
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [isLoadingSelectedTab, selectedTab]);


this caused

[Due for payment 2026-02-03] [$250] Expense - Tooltip Try it out doesn't appeared #79629

We should let this useEffect run when lastSelectedTab is changed. It won't be a problem as there's a early return check.

Revert "[CP Staging] Revert "fix: Add receipt from manual expense, QA…

c1db378

…B is scan receipt but confirm detail display as manual""

melvin-bot bot assigned nkdengineer Dec 17, 2025

nkdengineer added 2 commits December 21, 2025 22:28

Merge branch 'main' into revert-77674-revert-76799-fix/74911

ba14da3

fix transaction is undefined

31b504c

nkdengineer changed the title ~~Revert "[CP Staging] Revert "fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual""~~ fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual v2 Dec 21, 2025

nkdengineer added 2 commits December 21, 2025 22:41

disable dependency rule

6441421

remove log

9ba9bec

nkdengineer marked this pull request as ready for review December 21, 2025 15:53

nkdengineer requested review from a team as code owners December 21, 2025 15:53

melvin-bot bot requested review from heyjennahay and rojiphil and removed request for a team and heyjennahay December 21, 2025 15:53

melvin-bot bot removed the request for review from a team December 21, 2025 15:53

rojiphil approved these changes Jan 3, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski January 3, 2026 12:18

rojiphil mentioned this pull request Jan 6, 2026

[Due for payment 2026-01-21] [$125] QAB - Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual #74911

Closed

8 tasks

mjasikowski requested changes Jan 7, 2026

View reviewed changes

nkdengineer added 3 commits January 9, 2026 12:47

Merge branch 'main' into revert-77674-revert-76799-fix/74911

a3fd561

add comment

ef78486

update comment

a6110e6

mjasikowski approved these changes Jan 12, 2026

View reviewed changes

mjasikowski merged commit b3bddac into Expensify:main Jan 12, 2026
31 checks passed

github-actions bot mentioned this pull request Jan 12, 2026

[Due for payment 2026-01-21] Investigate workflow job failing on main: lint / ESLint check #79334

Closed

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

eh2077 reviewed Feb 2, 2026

View reviewed changes

Conversation

nkdengineer commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 21, 2025

Uh oh!

nkdengineer commented Jan 2, 2026

Uh oh!

rojiphil commented Jan 3, 2026

Uh oh!

rojiphil commented Jan 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

mjasikowski Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

mjasikowski Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

eh2077 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Dec 17, 2025 •

edited

Loading

codecov bot commented Dec 17, 2025 •

edited by github-actions bot

Loading

mjasikowski Jan 9, 2026 •

edited

Loading