Add members page to domain by sumo-slonik · Pull Request #77872 · Expensify/App

sumo-slonik · 2025-12-17T10:36:40Z

Explanation of Change

First part of Release 2 of the domain-control-in-new-dot project. It adds Members page under domain/\<domainAccountID\>/members. We won't add Members button to block users from entering that page until all Release 2 PRs are merged

Fixed Issues

$ #78123
PROPOSAL:

Tests

Open /domain/<\domainAccountID\>/members
Veirfy that page loads list of members
If the list is longer than 15 the search text input should appear
Verify that the list is scrollable
Verify that you can search members
Verify that when the search phrase doesn't have matches, it shows No results found matching ...

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2025-12-23.at.14.31.14.mov

…page # Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/pages/domain/Admins/DomainAdminsPage.tsx

melvin-bot · 2025-12-17T10:36:46Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-12-17T10:45:21Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.47% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/components/Icon/chunks/illustrations.chunk.ts	`0.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/selectors/Domain.ts	`88.88% <100.00%> (+7.07%)`	⬆️
src/ROUTES.ts	`12.52% <0.00%> (+0.08%)`	⬆️
src/libs/actions/Domain.ts	`7.69% <0.00%> (ø)`
...n/AppNavigator/Navigators/DomainSplitNavigator.tsx	`0.00% <0.00%> (ø)`
...ages/domain/Admins/DomainAddPrimaryContactPage.tsx	`0.00% <0.00%> (ø)`
... and 3 more
... and 11 files with indirect coverage changes

src/libs/Navigation/AppNavigator/Navigators/DomainSplitNavigator.tsx

src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts

src/libs/DomainUtils.ts

src/ONYXKEYS.ts

src/types/onyx/Domain.ts

src/pages/domain/BaseDomainMembersPage.tsx

src/pages/domain/Admins/DomainAdminsPage.tsx

src/selectors/Domain.ts

src/pages/domain/BaseDomainMembersPage.tsx

…page # Conflicts: # src/ONYXKEYS.ts # src/ROUTES.ts # src/SCREENS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # src/types/onyx/index.ts

src/pages/domain/BaseDomainMembersPage.tsx

…page # Conflicts: # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

…page

…page # Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

src/pages/domain/BaseDomainMembersPage.tsx

dubielzyk-expensify · 2026-01-09T02:45:38Z

Yeah this seems right to me. cc @dubielzyk-expensify for more eyes since he worked on this initially.

Yep, that looks right to me too 👍

dubielzyk-expensify · 2026-01-09T02:47:21Z

Is the primary contact badge the same distance from the chevron as the admin/owner badge on workspace members page? Feels like it's like 4px different or something?

Workspace members

Domain members

war-in · 2026-01-09T10:07:51Z

Feels like it's like 4px different or something?

@dubielzyk-expensify looks like it depends on the text length 🥶 Auditor & owner are not aligned too

war-in · 2026-01-09T10:13:13Z

@mountiny I think we're ready for the final review

mountiny · 2026-01-09T12:25:07Z

Thanks! Can you please fix prettier and jest?

github-actions · 2026-01-09T12:25:50Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-09T12:49:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #77872.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5d05f592d9ccbdd471a963b5ad845b5cede1fe7f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b3c4181058937708fe171e8d9dbe7010f0efbdb1/index.html

Web 🕸️
https://77872.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2026-01-09T13:11:50Z

@Expensify/design Can you please give this PR a look for a design sign off?

…page

war-in · 2026-01-09T13:32:42Z

@mountiny prettier fixed, jest error seems unrelated

dannymcclain · 2026-01-09T15:02:09Z

Feels like it's like 4px different or something?

@dubielzyk-expensify looks like it depends on the text length 🥶 Auditor & owner are not aligned too

Let's definitely make sure we get all these badges aligned. The right edge of all the badges should line up, right @dubielzyk-expensify? Or are they supposed to be centered in a fix-width column?

war-in · 2026-01-09T15:06:31Z

Let's definitely make sure we get all these badges aligned. The right edge of all the badges should line up, right @dubielzyk-expensify? Or are they supposed to be centered in a fix-width column?

sure, but I believe we could make it external. What do you think @mountiny?

dubielzyk-expensify · 2026-01-12T00:14:51Z

Let's definitely make sure we get all these badges aligned. The right edge of all the badges should line up, right @dubielzyk-expensify? Or are they supposed to be centered in a fix-width column?

Yeah exactly. It's the right alignment that I'm trying to highlight 👍

…in_members_page # Conflicts: # src/libs/actions/Domain.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

…page

mountiny

Nice one, just one NAB that I think we can handle in future PRs

mountiny · 2026-01-12T12:53:30Z

src/pages/domain/Admins/DomainAddPrimaryContactPage.tsx


        const details = personalDetails?.[accountID];
-        if (details?.login === technicalContactSettings?.technicalContactEmail) {
+        let isSelected = false;


NAB: Since all we need from the technicalContactSettings in this component is the email imho we should use the selector to directly pull the email

OSBotify · 2026-01-12T13:19:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-13T03:38:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:55:15Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

sumo-slonik added 3 commits December 16, 2025 17:08

add members page to domains

7a4ba4b

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

7d2aaef

…page # Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/pages/domain/Admins/DomainAdminsPage.tsx

fix general members component after marge from main

276fd9e

melvin-bot bot assigned sumo-slonik Dec 17, 2025

fix SecurityGroup type

4fc8339

war-in suggested changes Dec 17, 2025

View reviewed changes

review changes

5d2698e

jmusial reviewed Dec 18, 2025

View reviewed changes

sumo-slonik added 6 commits December 18, 2025 20:38

changes after review without components from main

d376360

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

984e680

…page # Conflicts: # src/ONYXKEYS.ts # src/ROUTES.ts # src/SCREENS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # src/types/onyx/index.ts

changes after review with components from main

f8d5411

add test to selector

010d826

simplify selector

896d64a

remove unnecessary useMemo, useCallback

2cdf216

jmusial reviewed Dec 22, 2025

View reviewed changes

src/pages/domain/BaseDomainMembersPage.tsx Show resolved Hide resolved

sumo-slonik added 11 commits December 22, 2025 17:55

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

ac42828

…page # Conflicts: # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

add new admin features to page using baseMemberPage

00d70f1

remove callback

5313572

npm run prettier

96e0d89

add spain translations

7183f29

remove polish comment

fcd8581

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

56ba188

…page

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

6cbbbd8

…page # Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

remove polish comment

900a841

fix selector typing

827b5fc

fix import

4d9aa05

war-in reviewed Dec 23, 2025

View reviewed changes

src/pages/domain/BaseDomainMembersPage.tsx Outdated Show resolved Hide resolved

remove unnecessary if(loading)

b01543f

fix: dont show Hidden as selected on add primary contact page

0aeee27

war-in added 2 commits January 9, 2026 14:28

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

b32bdc1

…page

fix: prettier

d666c78

war-in added 2 commits January 12, 2026 11:57

Merge branch 'refs/heads/main' into feature/kuba-nowakowski/add__doma…

50fe039

…in_members_page # Conflicts: # src/libs/actions/Domain.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # tests/unit/DomainSelectorsTest.ts

fix: post-merge fixes

c5f471f

war-in added this to Bring Domain Control to NewDot Jan 12, 2026

war-in moved this to Ready for Review in Bring Domain Control to NewDot Jan 12, 2026

mountiny requested review from jmusial and war-in January 12, 2026 12:51

Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…

8c48a19

…page

mountiny approved these changes Jan 12, 2026

View reviewed changes

mountiny merged commit 9f809c1 into Expensify:main Jan 12, 2026
33 checks passed

github-project-automation bot moved this from Ready for Review to Done in Bring Domain Control to NewDot Jan 12, 2026

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

melvin-bot bot mentioned this pull request Jan 14, 2026

[Due for payment 2026-01-21] [Release 2] [Domain Control] Domain members page #78123

Closed

Conversation

sumo-slonik commented Dec 17, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 17, 2025

Uh oh!

codecov bot commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dubielzyk-expensify commented Jan 9, 2026

Uh oh!

dubielzyk-expensify commented Jan 9, 2026

Uh oh!

war-in commented Jan 9, 2026

Uh oh!

war-in commented Jan 9, 2026

Uh oh!

mountiny commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

mountiny commented Jan 9, 2026

Uh oh!

war-in commented Jan 9, 2026

Uh oh!

dannymcclain commented Jan 9, 2026

Uh oh!

war-in commented Jan 9, 2026

Uh oh!

dubielzyk-expensify commented Jan 12, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sumo-slonik commented Dec 17, 2025 •

edited by mountiny

Loading

codecov bot commented Dec 17, 2025 •

edited by github-actions bot

Loading