Use compute function for report name in convertIOUReportToExpenseReport by abbasifaizan70 · Pull Request #77928 · Expensify/App

abbasifaizan70 · 2025-12-17T19:12:54Z

Explanation of Change

This PR Replace populateOptimisticReportFormula with compute function when converting IOU reports to expense reports. Pass transactions from UI via useOnyx hooks instead of using deprecated getReportTransactions.

Changes:

Update convertIOUReportToExpenseReport to accept reportTransactions param
Update moveIOUReportToPolicy to pass reportTransactions
Update moveIOUReportToPolicyAndInviteSubmitter to pass reportTransactions
Update ReportChangeWorkspacePage to use useReportTransactions hook
Update SearchPage to filter and pass transactions
Update BaseKYCWall to use useReportTransactions hook"

Fixed Issues

$ #76855
PROPOSAL: #76855 (comment)

Tests

Prerequisites

Create or use an existing Team or Corporate workspace (not a personal workspace)
Go to Settings > Workspaces > [Your Workspace] > Report Fields
Set up a custom Report Title formula. Examples to test:
- {report:type} - {report:total}
- Report {report:id} - {report:policyname}
- {report:status} Report for {report:workspacename}

Formula	Expected Optimistic Result
`{report:type}`	"Expense Report"
`{report:id}`	Base62 encoded report ID (e.g., "R0000008M0kX")
`{report:total}`	Formatted amount (e.g., "25.00")
`{report:policyname}`	Workspace name
`{report:workspacename}`	Workspace name
`{report:status}`	"Open" or "Submitted"
`{report:currency}`	Currency code (e.g., "USD")

Test Case 1: Create New Expense in Workspace

Open the Expensify app
Click the + button (FAB)
Select Submit Expense
Choose a workspace that has a custom report title formula
Fill in the expense details (amount, merchant, etc.)
Submit the expense
The expense report should be created with the optimistic report name computed using the formula (e.g., "Expense Report - $25.00" instead of the default "[Workspace] owes $25.00")

Test Case 2: Offline Mode

Turn on Airplane mode / disconnect from internet
Create a new expense in a workspace with custom report title formula
The report name should still be computed optimistically using the formula
Reconnect to internet
The report name should remain correct after sync

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Test 01

Test 02

Screen.Recording.2025-12-17.at.7.58.13.PM.mov

…eReport Replace populateOptimisticReportFormula with compute function when converting IOU reports to expense reports. Pass transactions from UI via useOnyx hooks instead of using deprecated getReportTransactions. Changes: - Update convertIOUReportToExpenseReport to accept reportTransactions param - Update moveIOUReportToPolicy to pass reportTransactions - Update moveIOUReportToPolicyAndInviteSubmitter to pass reportTransactions - Update ReportChangeWorkspacePage to use useReportTransactions hook - Update SearchPage to filter and pass transactions - Update BaseKYCWall to use useReportTransactions hook

codecov · 2025-12-17T19:21:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/KYCWall/BaseKYCWall.tsx	`38.66% <60.00%> (+1.25%)`	⬆️
src/pages/ReportChangeWorkspacePage.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SearchPage.tsx	`23.42% <20.00%> (+0.05%)`	⬆️
src/libs/actions/Report.ts	`53.74% <33.33%> (-0.30%)`	⬇️
... and 3 files with indirect coverage changes

melvin-bot · 2025-12-17T19:33:16Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

All good, WN project rollout 👍

src/pages/Search/SearchPage.tsx

src/libs/actions/Report.ts

src/libs/ReportUtils.ts

eVoloshchak · 2025-12-19T14:06:28Z

@abbasifaizan70, should we put this one on HOLD until #77827 is merged? Seems like both PR's are related

abbasifaizan70 · 2025-12-19T14:24:18Z

@abbasifaizan70, should we put this one on HOLD until #77827 is merged? Seems like both PR's are related

@eVoloshchak, yes, this PR required code changes of this PR.

The merge-base changed after approval.

neil-marcellini · 2026-01-13T15:55:16Z

@abbasifaizan70 I removed the HOLD. When do you think you'll be able to have this ready for another review?

abbasifaizan70 · 2026-01-13T21:48:47Z

@neil-marcellini @eVoloshchak Can you take a look at this PR? Thanks

neil-marcellini

Looks great! Only one small non-blocking comment, and then also we should put this behind the beta check.

src/libs/actions/Report.ts

abbasifaizan70 · 2026-01-14T20:38:49Z

@neil-marcellini removed extra comments.

eVoloshchak · 2026-01-15T14:57:32Z

and then also we should put this behind the beta check

@abbasifaizan70, could you add a beta check please?

abbasifaizan70 · 2026-01-16T00:41:51Z

@eVoloshchak added

neil-marcellini

It all looks good except for adding a deprecated function call

src/libs/actions/Report.ts

…ponents using usePermissions

abbasifaizan70 · 2026-01-16T15:46:56Z

@neil-marcellini Solved feedback issue. Thanks

neil-marcellini

Looks great thanks

neil-marcellini · 2026-01-16T22:55:40Z

Next step is for @eVoloshchak to complete the C+ testing and checklist.

eVoloshchak · 2026-01-19T21:39:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-21.at.21.51.23.mov

Android: mWeb Chrome

Screen.Recording.2026-01-21.at.21.54.08.mov

iOS: HybridApp

Screen.Recording.2026-01-21.at.21.45.39.mov

iOS: mWeb Safari

Screen.Recording.2026-01-21.at.21.47.46.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-21.at.21.08.20.mov

eVoloshchak · 2026-01-20T15:34:32Z

Test Case 2: Offline Mode
Turn on Airplane mode / disconnect from internet
Create a new expense in a workspace with custom report title formula
The report name should still be computed optimistically using the formula

It isn't, it is showing "{Workspace} owes -{amount}" until you reconnect

cc: @abbasifaizan70

Untitled.mov

…-iou

abbasifaizan70 · 2026-01-20T22:15:51Z

The formula won’t run if the app doesn’t yet have the cached beta + policy field data in memory, so it falls back to the default title. Once you go online, the server computes and updates the report name, which is why it changes.

ere’s the quickest way to force-enable the beta:
Web (dev console)
Open devtools and run:
window.Onyx.merge('betas', ['newExpensifyCustomReportNames'])
Then refresh the app.

@eVoloshchak

Screen.Recording.2026-01-21.at.3.13.44.AM.mov

…-iou

eVoloshchak

LGTM!

…ub.com/abbasifaizan70/Expensify into fix-optimistic-report-name-convert-iou

neil-marcellini

Good to go, thanks for sticking with it.

neil-marcellini · 2026-01-21T21:29:12Z

Shoot looks like TS check is failing. Lmk when it's fixed.

abbasifaizan70 · 2026-01-21T21:29:25Z

@neil-marcellini let me fix typescript Checks issue

OSBotify · 2026-01-21T22:30:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-21T23:36:47Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:24:03Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned abbasifaizan70 Dec 17, 2025

abbasifaizan70 marked this pull request as ready for review December 17, 2025 19:33

abbasifaizan70 requested review from a team as code owners December 17, 2025 19:33

melvin-bot bot requested review from eVoloshchak and trjExpensify and removed request for a team December 17, 2025 19:33

melvin-bot bot removed the request for review from a team December 17, 2025 19:33

abbasifaizan70 mentioned this pull request Dec 17, 2025

[Due for payment 2026-01-29] Optimistically compute report names on creation #76855

Closed

trjExpensify previously approved these changes Dec 18, 2025

View reviewed changes

eVoloshchak suggested changes Dec 19, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Show resolved Hide resolved

src/libs/actions/Report.ts Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

neil-marcellini changed the title ~~Use compute function for report name in convertIOUReportToExpenseReport~~ [HOLD #77827] Use compute function for report name in convertIOUReportToExpenseReport Dec 30, 2025

neil-marcellini self-requested a review December 30, 2025 22:34

neil-marcellini changed the title ~~[HOLD #77827] Use compute function for report name in convertIOUReportToExpenseReport~~ Use compute function for report name in convertIOUReportToExpenseReport Jan 13, 2026

Merge origin/main into fix-optimistic-report-name-convert-iou

8a04a59

neil-marcellini requested changes Jan 14, 2026

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

removed extra comments

b7fa5fb

Added beta check

d1117f7

neil-marcellini requested changes Jan 16, 2026

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

avoid the deprecated Onyx.connect and instead pass a flag from UI com…

478911a

…ponents using usePermissions

neil-marcellini previously approved these changes Jan 16, 2026

View reviewed changes

neil-marcellini requested a review from eVoloshchak January 16, 2026 22:55

Merge branch 'Expensify:main' into fix-optimistic-report-name-convert…

eb4d6f5

…-iou

abbasifaizan70 added 2 commits January 21, 2026 15:09

Merge branch 'Expensify:main' into fix-optimistic-report-name-convert…

f5ecdd5

…-iou

Merge branch 'Expensify:main' into fix-optimistic-report-name-convert…

960da3b

…-iou

eVoloshchak approved these changes Jan 21, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 21, 2026 20:56

abbasifaizan70 added 2 commits January 22, 2026 02:20

fixed lint issues

c72248d

Merge branch 'fix-optimistic-report-name-convert-iou' of https://gith…

a73e6d3

…ub.com/abbasifaizan70/Expensify into fix-optimistic-report-name-convert-iou

abbasifaizan70 dismissed neil-marcellini’s stale review via a73e6d3 January 21, 2026 21:20

neil-marcellini previously approved these changes Jan 21, 2026

View reviewed changes

abbasifaizan70 dismissed neil-marcellini’s stale review via 07f93b5 January 21, 2026 21:50

Fixed lint issues

1e0af7c

abbasifaizan70 force-pushed the fix-optimistic-report-name-convert-iou branch from 07f93b5 to 1e0af7c Compare January 21, 2026 22:01

neil-marcellini approved these changes Jan 21, 2026

View reviewed changes

neil-marcellini merged commit 7e8599e into Expensify:main Jan 21, 2026
27 checks passed

OSBotify mentioned this pull request Jan 21, 2026

Deploy Checklist: New Expensify 2026-01-21 #80164

Closed

78 tasks

jponikarchuk mentioned this pull request Jan 22, 2026

[$250] Report title created offline does not match the custom formula until going online #80197

Closed

7 tasks

Conversation

abbasifaizan70 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Changes:

Fixed Issues

Tests

Prerequisites

Test Case 1: Create New Expense in Workspace

Test Case 2: Offline Mode

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Test 01

Test 02

Uh oh!

codecov bot commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 17, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abbasifaizan70 commented Dec 19, 2025

Uh oh!

neil-marcellini commented Jan 13, 2026

Uh oh!

abbasifaizan70 commented Jan 13, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abbasifaizan70 commented Jan 14, 2026

Uh oh!

eVoloshchak commented Jan 15, 2026

Uh oh!

abbasifaizan70 commented Jan 16, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abbasifaizan70 commented Jan 16, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Jan 16, 2026

Uh oh!

eVoloshchak commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Jan 20, 2026

Uh oh!

abbasifaizan70 commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Jan 21, 2026

Uh oh!

abbasifaizan70 commented Jan 21, 2026

Uh oh!

Uh oh!

abbasifaizan70 commented Dec 17, 2025 •

edited

Loading

codecov bot commented Dec 17, 2025 •

edited by github-actions bot

Loading

eVoloshchak commented Dec 19, 2025 •

edited

Loading

eVoloshchak commented Jan 19, 2026 •

edited

Loading

abbasifaizan70 commented Jan 20, 2026 •

edited

Loading