Skip to content

[No QA] Replace default updateOnyx union type with specific types in type annotations in variable declarations #77949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 12 commits into from
Dec 22, 2025
Merged

[No QA] Replace default updateOnyx union type with specific types in type annotations in variable declarations #77949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
75c271d
Replace default updateOnyx union type with specific types in type ann…
OlGierd03 Dec 18, 2025
6abfe41
Codegen now modify only the files with acutal changes detected
OlGierd03 Dec 18, 2025
86c2370
Replace default updateOnyx union type in src/libs/actions/Report.ts
OlGierd03 Dec 18, 2025
0fab386
Replace default updateOnyx union type in src/libs/actions/IOU.ts
OlGierd03 Dec 18, 2025
7e7b533
Replace default updateOnyx union type in src/libs/actions/Policy/Poli…
OlGierd03 Dec 18, 2025
37887b1
Replace updateOnyx default union type in src/libs/actions/{Card,Trave…
OlGierd03 Dec 18, 2025
d1ad4d2
Run npm run prettier
OlGierd03 Dec 18, 2025
d30fbca
Apply improved codegen with better push method usage analysis and emp…
OlGierd03 Dec 19, 2025
a017ef5
Merge 'main' branch
OlGierd03 Dec 20, 2025
f5896df
Merge 'main' branch
OlGierd03 Dec 22, 2025
d52bd38
Apply codegen to tsx files
OlGierd03 Dec 22, 2025
75ab0cd
Apply codegen to files from ./tests
OlGierd03 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/PersonalDetailsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
let personalDetails: Array<PersonalDetails | null> = [];
let allPersonalDetails: OnyxEntry<PersonalDetailsList> = {};
let emailToPersonalDetailsCache: Record<string, PersonalDetails> = {};
Onyx.connect({

Check warning on line 26 in src/libs/PersonalDetailsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
callback: (val) => {
personalDetails = Object.values(val ?? {});
Expand All @@ -40,7 +40,7 @@
let hiddenTranslation = '';
let youTranslation = '';

Onyx.connect({

Check warning on line 43 in src/libs/PersonalDetailsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
initWithStoredValues: false,
callback: (value) => {
Expand Down Expand Up @@ -236,15 +236,15 @@
personalDetailsCleanup[accountID] = null;
}

const optimisticData: OnyxUpdate[] = [
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.PERSONAL_DETAILS_LIST>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
value: personalDetailsNew,
},
];

const finallyData: OnyxUpdate[] = [
const finallyData: Array<OnyxUpdate<typeof ONYXKEYS.PERSONAL_DETAILS_LIST>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
Expand Down
6 changes: 3 additions & 3 deletions src/libs/PolicyDistanceRatesUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function buildOnyxDataForPolicyDistanceRateUpdates(policyID: string, customUnit:
}
}

const optimisticData: OnyxUpdate[] = [
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.POLICY>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
Expand All @@ -101,7 +101,7 @@ function buildOnyxDataForPolicyDistanceRateUpdates(policyID: string, customUnit:
},
];

const successData: OnyxUpdate[] = [
const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.POLICY>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
Expand All @@ -115,7 +115,7 @@ function buildOnyxDataForPolicyDistanceRateUpdates(policyID: string, customUnit:
},
];

const failureData: OnyxUpdate[] = [
const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.POLICY>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
Expand Down
4 changes: 2 additions & 2 deletions src/libs/ReportTitleUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function updateTitleFieldToMatchPolicy(reportID: string, policy?: Policy): OnyxU
}

// Create the update to set/update the title field in rNVP
const optimisticData: OnyxUpdate[] = [
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${reportID}`,
Expand All @@ -94,7 +94,7 @@ function removeTitleFieldFromReport(reportID: string): OnyxUpdate[] {
return [];
}

const optimisticData: OnyxUpdate[] = [
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${reportID}`,
Expand Down
8 changes: 5 additions & 3 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10361,9 +10361,11 @@ function getTaskAssigneeChatOnyxData(
let optimisticChatCreatedReportAction: OptimisticCreatedReportAction | undefined;
const assigneeChatReportMetadata = getReportMetadata(assigneeChatReportID);
const currentTime = DateUtils.getDBTime();
const optimisticData: OnyxUpdate[] = [];
const successData: OnyxUpdate[] = [];
const failureData: OnyxUpdate[] = [];
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.REPORT_METADATA | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS>> = [];
const successData: Array<
OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.REPORT_METADATA | typeof ONYXKEYS.PERSONAL_DETAILS_LIST | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS>
> = [];
const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS | typeof ONYXKEYS.PERSONAL_DETAILS_LIST>> = [];

Comment on lines +10364 to 10369
Copy link
Contributor

@Julesssss Julesssss Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines for each may be more readable.

Copy link
Contributor

@Julesssss Julesssss Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT 
    | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS
    | typeof ONYXKEYS.PERSONAL_DETAILS_LIST>> = [];

// You're able to assign a task to someone you haven't chatted with before - so we need to optimistically create the chat and the chat reportActions
// Only add the assignee chat report to onyx if we haven't already set it optimistically
Expand Down
2 changes: 1 addition & 1 deletion src/libs/actions/App.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ function setLocale(locale: Locale, currentPreferredLocale: Locale | undefined) {
}

// Optimistically change preferred locale
const optimisticData: OnyxUpdate[] = [
const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.NVP_PREFERRED_LOCALE>> = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.NVP_PREFERRED_LOCALE,
Expand Down
Loading
Loading