Skip to content

[CP Staging] Revert "Early return in isPayer function when policy does not exist"#77952

Merged
AndrewGable merged 1 commit intomainfrom
revert-76510-fix/gbr-reappears-lhn-on-approver-exit
Dec 18, 2025
Merged

[CP Staging] Revert "Early return in isPayer function when policy does not exist"#77952
AndrewGable merged 1 commit intomainfrom
revert-76510-fix/gbr-reappears-lhn-on-approver-exit

Conversation

@tylerkaraszewski
Copy link
Contributor

Reverts #76510

Seems to have caused this issue:
#77840

@tylerkaraszewski tylerkaraszewski self-assigned this Dec 18, 2025
@tylerkaraszewski tylerkaraszewski requested review from a team as code owners December 18, 2025 02:24
@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and mjasikowski and removed request for a team December 18, 2025 02:24
@melvin-bot
Copy link

melvin-bot bot commented Dec 18, 2025

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 18, 2025 02:24
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ReportUtils.ts 72.82% <100.00%> (-0.05%) ⬇️
src/libs/actions/IOU.ts 64.88% <100.00%> (-0.20%) ⬇️
... and 10 files with indirect coverage changes

@AndrewGable AndrewGable merged commit 38b7fdd into main Dec 18, 2025
32 of 34 checks passed
@AndrewGable AndrewGable deleted the revert-76510-fix/gbr-reappears-lhn-on-approver-exit branch December 18, 2025 04:04
@melvin-bot melvin-bot bot added the Emergency label Dec 18, 2025
@melvin-bot

This comment was marked as outdated.

@AndrewGable
Copy link
Contributor

Straight revert, not emergency

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 18, 2025
…rs-lhn-on-approver-exit

Revert "Early return in isPayer function when policy does not exist"

(cherry picked from commit 38b7fdd)

(cherry-picked to staging by AndrewGable)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 18, 2025
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.81-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mountiny mountiny changed the title Revert "Early return in isPayer function when policy does not exist" [CP Staging] Revert "Early return in isPayer function when policy does not exist" Dec 18, 2025
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.84-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants