Custom Columns Release #5 #78019

JS00001 · 2025-12-18T18:33:59Z

Explanation of Change

Adds support for group-by based columns in the columns selector

Fixed Issues

$ #76875

Tests

Go to Reports > Reconciliation
Verify you see the Columns button next to the Filters column.
Click the Columns button
Verify the RHP opens
Verify you see a “Group” column section for:
- Bank account
- Withdrawn
- Withdrawal ID
- Expenses
- Total
Check all columns apart from Withdrawn
Click Save
Verify the RHP closes
Verify the Withdrawn column doesn’t appear in the table
Click the Columns button
Click Reset columns
Verify the Withdrawn column is checked again in the list
Click Save
Verify the Withdrawn column appears in the table again.
Go to Reports > Unapproved Cash
Verify you see the Columns button next to the Filters column.
Click the Columns button
Verify the RHP opens
Verify you see a “Group” column section for:
- From
- Expenses
- Total
Check all columns apart from Expenses
Click Save
Verify the RHP closes
Verify the Expenses column doesn’t appear in the table
Click the Columns button
Click Reset columns
Verify the Expenses column is checked again in the list
Click Save
Verify the Expenses column appears in the table again.
Go to Reports > Statements
Verify you see the Columns button next to the Filters column.
Click the Columns button
Verify the RHP opens
Verify you see a “Group” column section for:
- Card
- Feed
- Expenses
- Total
Check all columns apart from Feed
Click Save
Verify the RHP closes
Verify the Feed column doesn’t appear in the table
Click the Columns button
Click Reset columns
Verify the Feed column is checked again in the list
Click Save
Verify the Feed column appears in the table again.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-12-18.at.5.03.33.PM.mov

codecov · 2025-12-18T18:44:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...stWithSections/Search/TransactionGroupListItem.tsx	`71.42% <ø> (ø)`
...ts/SelectionListWithSections/SearchTableHeader.tsx	`8.47% <ø> (ø)`
src/libs/SearchAutocompleteUtils.ts	`50.35% <0.00%> (ø)`
src/libs/SearchQueryUtils.ts	`69.45% <0.00%> (ø)`
src/components/DraggableList/index.tsx	`0.00% <0.00%> (ø)`
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`68.02% <0.00%> (-0.47%)`	⬇️
src/CONST/index.ts	`83.47% <33.33%> (-3.01%)`	⬇️
src/styles/utils/index.ts	`49.85% <12.50%> (-0.45%)`	⬇️
...onListWithSections/Search/MemberListItemHeader.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SearchColumnsPage.tsx	`0.00% <0.00%> (ø)`
... and 3 more
... and 8 files with indirect coverage changes

….com:Expensify/App into jsenyitko-custom-cols-release-5

…-cols-release-5

OSBotify · 2025-12-19T17:08:34Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff

diff --git a/src/languages/de.ts b/src/languages/de.ts
index 820058cc..59a6eab2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6705,7 +6705,7 @@ Fordere Spesendetails wie Belege und Beschreibungen an, lege Limits und Standard
         columns: 'Spalten',
         resetColumns: 'Spalten zurücksetzen',
         groupColumns: 'Gruppenspalten',
-        expenseColumns: 'Spalten für Ausgaben',
+        expenseColumns: 'Ausgabenspalten',
         statements: 'Abrechnungen',
         unapprovedCash: 'Nicht genehmigtes Bargeld',
         unapprovedCard: 'Nicht genehmigte Karte',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index c7ddfe82..8e401955 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6688,7 +6688,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
         columns: 'Colonne',
         resetColumns: 'Reimposta colonne',
         groupColumns: 'Raggruppa colonne',
-        expenseColumns: 'Colonne di spesa',
+        expenseColumns: 'Colonne delle spese',
         statements: 'Estratti conto',
         unapprovedCash: 'Contanti non approvati',
         unapprovedCard: 'Carta non approvata',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d395bc25..3fcfa91e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6632,7 +6632,7 @@ ${reportName}
         },
         columns: '列',
         resetColumns: '列をリセット',
-        groupColumns: 'グループ列',
+        groupColumns: '列をグループ化',
         expenseColumns: '経費列',
         statements: 'ステートメント',
         unapprovedCash: '未承認の現金',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 7bfa4e7c..c0881fcf 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6675,7 +6675,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
         columns: 'Kolommen',
         resetColumns: 'Kolommen resetten',
         groupColumns: 'Kolommen groeperen',
-        expenseColumns: 'Uitgavekolommen',
+        expenseColumns: 'Uitgavenkolommen',
         statements: 'Afschriften',
         unapprovedCash: 'Niet-goedgekeurde contanten',
         unapprovedCard: 'Niet-goedgekeurde kaart',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index a242a45d..2a7f6b4c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6663,7 +6663,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
         },
         columns: 'Kolumny',
         resetColumns: 'Resetuj kolumny',
-        groupColumns: 'Kolumny grupy',
+        groupColumns: 'Grupuj kolumny',
         expenseColumns: 'Kolumny wydatków',
         statements: 'Wyciągi',
         unapprovedCash: 'Niezaakceptowana gotówka',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 2100f6cd..4800e9c5 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6668,7 +6668,7 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
         columns: 'Colunas',
         resetColumns: 'Redefinir colunas',
         groupColumns: 'Agrupar colunas',
-        expenseColumns: 'Colunas de Despesas',
+        expenseColumns: 'Colunas de despesas',
         statements: 'Extratos',
         unapprovedCash: 'Dinheiro não aprovado',
         unapprovedCard: 'Cartão não aprovado',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx

luacmartins

LGTM 🚀

brunovjk · 2025-12-19T17:19:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-19.at.14.49.41.mov

melvin-bot · 2025-12-19T17:56:14Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-12-19T18:05:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-20T00:00:27Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-12-20T20:22:57Z

@JS00001 No data displayed when Reconciliation and statement selected, Tried with few expensifail account as well. Can this one tested internally?

JS00001 · 2025-12-22T14:30:04Z

Sure

OSBotify · 2025-12-23T00:33:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

JS00001 added 19 commits December 18, 2025 11:51

add col names

4eb43b4

build the group by cols

049d30d

add new columns

2bf6001

rework how reports are filtered

04ee1e2

cleanup more visibility logic

413d442

finish logic for group by visibility

9054e03

add helper fuunc for groupby as well

9454016

get the cols in column page

a5832eb

add translations

0e911ac

add the logic for all sections

4368801

make headers use group ids

3903cce

add col props

1aed730

add cols

5dc647a

custom cols for member list item

38c5563

add withdrawal id header

ae0f0fe

add card list header

a135ff4

add styles

bf3e03e

add translatiosn

28bb6ff

add logic for diff errors

16071be

melvin-bot bot assigned JS00001 Dec 18, 2025

This comment has been minimized.

Sign in to view

JS00001 added 6 commits December 18, 2025 14:49

Merge branches 'main' and 'jsenyitko-custom-cols-release-5' of github…

ab4639d

….com:Expensify/App into jsenyitko-custom-cols-release-5

update logic for new changes

064b0d3

start on managing sorting

2d6b3a0

update to have two lists

6ba4e7a

update container

654bde2

update lang fix layout

bfecb4e

This comment has been minimized.

Sign in to view

fix bug on drag end

072e86b

JS00001 added 2 commits December 19, 2025 09:59

reset mobile

3c98fdf

Merge branch 'main' of github.com:Expensify/App into jsenyitko-custom…

00ac8ec

…-cols-release-5

luacmartins requested review from Krishna2323 and removed request for Krishna2323 December 19, 2025 15:52

JS00001 added 3 commits December 19, 2025 10:52

Merge branch 'main' of github.com:Expensify/App into jsenyitko-custom…

0136030

…-cols-release-5

add required fields

bfe41b3

remove unused translations

800ccfb

JS00001 requested a review from luacmartins December 19, 2025 17:09

luacmartins reviewed Dec 19, 2025

View reviewed changes

src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx Show resolved Hide resolved

fix lint

cf547d0

luacmartins linked an issue Dec 19, 2025 that may be closed by this pull request

[Due for payment 2025-12-30] [Custom Columns][Release 5] Add Custom Columns for Group By views to Columns RHP #76875

Closed

luacmartins approved these changes Dec 19, 2025

View reviewed changes

luacmartins removed the request for review from joekaufmanexpensify December 19, 2025 17:15

brunovjk approved these changes Dec 19, 2025

View reviewed changes

melvin-bot bot requested a review from deetergp December 19, 2025 17:56

JS00001 merged commit c4aea22 into main Dec 19, 2025
35 of 36 checks passed

JS00001 deleted the jsenyitko-custom-cols-release-5 branch December 19, 2025 17:56

OSBotify mentioned this pull request Dec 19, 2025

Deploy Checklist: New Expensify 2025-12-19 #78170

Closed

87 tasks

lanitochka17 mentioned this pull request Dec 20, 2025

Reports -"Oops... Something went wrong" is shown after clicking column title on group-by: table #78227

Closed

7 tasks

jponikarchuk mentioned this pull request Dec 20, 2025

[Due for payment 2025-12-31] Reports - All table columns disappear except Type and Amount after applying columns:froom #78229

Closed

7 tasks

lanitochka17 mentioned this pull request Dec 20, 2025

[Due for payment 2025-12-31] Reports - Empty fields such as From and Tag appear after resetting columns #78230

Closed

7 tasks

melvin-bot bot mentioned this pull request Dec 23, 2025

[Due for payment 2025-12-30] [Custom Columns][Release 5] Add Custom Columns for Group By views to Columns RHP #76875

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Columns Release #5 #78019

Custom Columns Release #5 #78019

Uh oh!

JS00001 commented Dec 18, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

codecov bot commented Dec 18, 2025 •

edited by github-actions bot

Loading

Uh oh!

This comment has been minimized.

OSBotify commented Dec 19, 2025

Uh oh!

Uh oh!

luacmartins left a comment

Uh oh!

brunovjk commented Dec 19, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Dec 19, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 20, 2025

Uh oh!

m-natarajan commented Dec 20, 2025 •

edited

Loading

Uh oh!

JS00001 commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Custom Columns Release #5 #78019

Custom Columns Release #5 #78019

Uh oh!

Conversation

JS00001 commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

codecov bot commented Dec 18, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

OSBotify commented Dec 19, 2025

🦜 Polyglot Parrot! 🦜

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 19, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 20, 2025

Uh oh!

m-natarajan commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JS00001 commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JS00001 commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited by github-actions bot

Loading

brunovjk commented Dec 19, 2025 •

edited

Loading

m-natarajan commented Dec 20, 2025 •

edited

Loading