Tgolen fix transition#78078
Merged
tgolen merged 1 commit intobyoc-bulk-card-assign-r1from Dec 19, 2025
Merged
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
melvin-bot
bot
requested review from
JmillsExpensify and
MarioExpensify
and removed request for
a team
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 31cbc541..64373526 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4859,7 +4859,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
feedName: (feedName: string) => `${feedName}-Karten`,
directFeed: 'Direkt-Feed',
whoNeedsCardAssigned: 'Wer braucht eine zugewiesene Karte?',
- chooseTheCardholder: 'Wähle den Karteninhaber',
+ chooseTheCardholder: 'Wählen Sie den Karteninhaber aus',
chooseCard: 'Wähle eine Karte',
chooseCardFor: (assignee: string) =>
`Wähle eine Karte für <strong>${assignee}</strong>. Du findest die Karte, die du suchst, nicht? <concierge-link>Teile es uns mit.</concierge-link>`,
@@ -4867,7 +4867,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
somethingMightBeBroken:
'<muted-text><centered-text>Oder etwas ist möglicherweise defekt. So oder so: Wenn du Fragen hast, kannst du jederzeit <concierge-link>Concierge kontaktieren</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Wähle ein Startdatum für die Transaktion',
- startDateDescription: 'Wir importieren alle Transaktionen ab diesem Datum. Wenn kein Datum angegeben ist, gehen wir so weit zurück, wie es Ihre Bank zulässt.',
+ startDateDescription: 'Wähle dein Import-Startdatum. Wir synchronisieren alle Transaktionen ab diesem Datum.',
fromTheBeginning: 'Von Anfang an',
customStartDate: 'Benutzerdefiniertes Startdatum',
customCloseDate: 'Benutzerdefiniertes Abschlussdatum',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e8b97f26..62ae867c 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4872,7 +4872,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
somethingMightBeBroken:
'<muted-text><centered-text>Ou quelque chose est peut-être cassé. Dans tous les cas, si vous avez des questions, il vous suffit de <concierge-link>contacter Concierge</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Choisissez une date de début de transaction',
- startDateDescription: 'Nous importerons toutes les transactions à partir de cette date. Si aucune date n’est spécifiée, nous remonterons aussi loin que votre banque le permet.',
+ startDateDescription: 'Choisissez votre date de début d’import. Nous synchroniserons toutes les transactions à partir de cette date.',
fromTheBeginning: 'Depuis le début',
customStartDate: 'Date de début personnalisée',
customCloseDate: 'Date de clôture personnalisée',
@@ -4888,7 +4888,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
chooseCardFeed: 'Choisir le flux de carte',
ukRegulation:
'Expensify Limited est un agent de Plaid Financial Ltd., un établissement de paiement agréé réglementé par la Financial Conduct Authority en vertu des Payment Services Regulations 2017 (numéro de référence de l’entreprise : 804718). Plaid vous fournit des services réglementés d’information sur les comptes par l’intermédiaire de Expensify Limited en tant que son agent.',
- assign: 'Assigner',
+ assign: 'Attribuer',
},
expensifyCard: {
issueAndManageCards: 'Émettre et gérer vos cartes Expensify',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 9c44de8d..57adc459 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4850,7 +4850,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
somethingMightBeBroken:
'<muted-text><centered-text>Oppure qualcosa potrebbe essere rotto. In ogni caso, se hai domande, <concierge-link>contatta Concierge</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Scegli una data di inizio transazione',
- startDateDescription: 'Importeremo tutte le transazioni a partire da questa data. Se non viene specificata alcuna data, risaliremo fino al limite consentito dalla tua banca.',
+ startDateDescription: 'Scegli la data di inizio dell’importazione. Sincronizzeremo tutte le transazioni da questa data in poi.',
fromTheBeginning: "Dall'inizio",
customStartDate: 'Data di inizio personalizzata',
customCloseDate: 'Data di chiusura personalizzata',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d5bd818c..ced47041 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4817,7 +4817,7 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
feedName: (feedName: string) => `${feedName} カード`,
directFeed: 'ダイレクトフィード',
whoNeedsCardAssigned: '誰にカードを割り当てる必要がありますか？',
- chooseTheCardholder: 'カード所有者を選択',
+ chooseTheCardholder: 'カード保有者を選択',
chooseCard: 'カードを選択',
chooseCardFor: (assignee: string) =>
`<strong>${assignee}</strong> に使うカードを選択してください。お探しのカードが見つかりませんか？<concierge-link>お知らせください。</concierge-link>`,
@@ -4825,7 +4825,7 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
somethingMightBeBroken:
'<muted-text><centered-text>または、何かが壊れている可能性があります。いずれにしても、ご不明な点があれば、<concierge-link>Concierge にお問い合わせください</concierge-link>。</centered-text></muted-text>',
chooseTransactionStartDate: '取引の開始日を選択',
- startDateDescription: 'この日付以降のすべての取引をインポートします。日付が指定されていない場合は、ご利用の銀行が許可する限り過去にさかのぼってインポートします。',
+ startDateDescription: 'インポートの開始日を選択してください。この日付以降のすべての取引を同期します。',
fromTheBeginning: '最初から',
customStartDate: 'カスタム開始日',
customCloseDate: 'カスタム締め日',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 65fb1913..cf974682 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4845,7 +4845,7 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
somethingMightBeBroken:
'<muted-text><centered-text>Of er is iets mis. Hoe dan ook, als je vragen hebt, kun je altijd <concierge-link>contact opnemen met Concierge</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Kies een startdatum voor transacties',
- startDateDescription: 'We importeren alle transacties vanaf deze datum. Als er geen datum is opgegeven, gaan we zo ver terug als je bank toestaat.',
+ startDateDescription: 'Kies je startdatum voor importeren. We synchroniseren alle transacties vanaf deze datum.',
fromTheBeginning: 'Vanaf het begin',
customStartDate: 'Aangepaste startdatum',
customCloseDate: 'Aangepaste einddatum',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index c6e063e7..11e74a01 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4836,7 +4836,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
somethingMightBeBroken:
'<muted-text><centered-text>Albo coś mogło się zepsuć. Tak czy inaczej, jeśli masz jakiekolwiek pytania, po prostu <concierge-link>skontaktuj się z Concierge</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Wybierz datę początkową transakcji',
- startDateDescription: 'Zaimportujemy wszystkie transakcje od tej daty. Jeśli nie określisz daty, sięgniemy tak daleko wstecz, jak pozwala Twój bank.',
+ startDateDescription: 'Wybierz datę początkową importu. Zsynchronizujemy wszystkie transakcje od tej daty wzwyż.',
fromTheBeginning: 'Od początku',
customStartDate: 'Niestandardowa data początkowa',
customCloseDate: 'Niestandardowa data zamknięcia',
@@ -5047,7 +5047,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
cardholder: 'Posiadacz karty',
cardName: 'Nazwa karty',
allCards: 'Wszystkie karty',
- assignedCards: 'Przypisano',
+ assignedCards: 'Przypisane',
unassignedCards: 'Nieprzypisane',
integrationExport: ({integration, type}: IntegrationExportParams) => (integration && type ? `${integration} ${type.toLowerCase()} eksport` : `Eksport ${integration}`),
integrationExportTitleXero: ({integration}: IntegrationExportParams) => `Wybierz konto ${integration}, do którego mają być eksportowane transakcje.`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 3e9e7aa7..f6810113 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4829,7 +4829,7 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
feedName: (feedName: string) => `Cartões ${feedName}`,
directFeed: 'Conexão direta',
whoNeedsCardAssigned: 'Quem precisa de um cartão atribuído?',
- chooseTheCardholder: 'Escolha o portador do cartão',
+ chooseTheCardholder: 'Escolha o titular do cartão',
chooseCard: 'Escolha um cartão',
chooseCardFor: (assignee: string) =>
`Escolha um cartão para <strong>${assignee}</strong>. Não encontra o cartão que está procurando? <concierge-link>Avise-nos.</concierge-link>`,
@@ -4837,7 +4837,7 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
somethingMightBeBroken:
'<muted-text><centered-text>Ou algo pode estar quebrado. De qualquer forma, se você tiver alguma dúvida, apenas <concierge-link>entre em contato com a Concierge</concierge-link>.</centered-text></muted-text>',
chooseTransactionStartDate: 'Escolha uma data de início da transação',
- startDateDescription: 'Vamos importar todas as transações a partir desta data. Se nenhuma data for especificada, iremos tão longe quanto o seu banco permitir.',
+ startDateDescription: 'Escolha sua data de início de importação. Faremos a sincronização de todas as transações a partir dessa data.',
fromTheBeginning: 'Desde o início',
customStartDate: 'Data de início personalizada',
customCloseDate: 'Data de fechamento personalizada',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9224cdc9..e1a213f9 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4754,7 +4754,7 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
somethingMightBeBroken:
'<muted-text><centered-text>或者某些功能可能出现故障。无论如何，如果你有任何问题，只需<concierge-link>联系 Concierge</concierge-link>。</centered-text></muted-text>',
chooseTransactionStartDate: '选择交易开始日期',
- startDateDescription: '我们将导入从此日期起的所有交易。如果未指定日期，我们会追溯到银行所允许的最早日期。',
+ startDateDescription: '选择导入的开始日期。我们会从该日期起同步所有交易。',
fromTheBeginning: '从头开始',
customStartDate: '自定义开始日期',
customCloseDate: '自定义结束日期',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
tgolen
requested review from
chrispader
and removed request for
a team,
JmillsExpensify and
MarioExpensify
Contributor
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.86-0 🚀
|
7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari