Skip to content

Revert "[NewFeature] Add ability to require attendees based on category selection"#78135

Merged
arosiclair merged 1 commit intomainfrom
revert-76687-ikevin127-categoryRequireAttendees
Dec 19, 2025
Merged

Revert "[NewFeature] Add ability to require attendees based on category selection"#78135
arosiclair merged 1 commit intomainfrom
revert-76687-ikevin127-categoryRequireAttendees

Conversation

@arosiclair
Copy link
Contributor

@arosiclair arosiclair commented Dec 19, 2025

Reverts #76687

$ #78076
$ #78147

@arosiclair arosiclair self-assigned this Dec 19, 2025
@melvin-bot
Copy link

melvin-bot bot commented Dec 19, 2025

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@github-actions
Copy link
Contributor

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78135.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://78135.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 86.48% <ø> (ø)
src/ROUTES.ts 13.13% <ø> (+0.01%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
src/components/MoneyRequestConfirmationList.tsx 58.45% <ø> (+0.12%) ⬆️
.../components/MoneyRequestConfirmationListFooter.tsx 84.26% <100.00%> (-0.06%) ⬇️
src/hooks/useViolations.ts 3.22% <100.00%> (+0.05%) ⬆️
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 8.34% <ø> (+0.01%) ⬆️
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
... and 8 more
... and 11 files with indirect coverage changes

@arosiclair arosiclair marked this pull request as ready for review December 19, 2025 17:45
@arosiclair arosiclair requested review from a team as code owners December 19, 2025 17:45
@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team December 19, 2025 17:46
@arosiclair arosiclair merged commit d7e7272 into main Dec 19, 2025
36 of 40 checks passed
@arosiclair arosiclair deleted the revert-76687-ikevin127-categoryRequireAttendees branch December 19, 2025 17:46
@melvin-bot
Copy link

melvin-bot bot commented Dec 19, 2025

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Dec 19, 2025
@melvin-bot melvin-bot bot requested review from roryabraham and removed request for a team December 19, 2025 17:46
@melvin-bot
Copy link

melvin-bot bot commented Dec 19, 2025

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@arosiclair
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Dec 19, 2025
…oryRequireAttendees

Revert "[NewFeature] Add ability to require attendees based on category selection"

(cherry picked from commit d7e7272)

(cherry-picked to staging by AndrewGable)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 19, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.84-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.85-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants