Skip to content

[No QA] Fix: useConfirmModal back navigation #78141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 1 commit into from
Jan 5, 2026
Merged

[No QA] Fix: useConfirmModal back navigation #78141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/hooks/useConfirmModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ const useConfirmModal = () => {
const showConfirmModal = (options: ConfirmModalOptions) => {
return context.showModal({
component: ConfirmModalWrapper,
props: options,
props: {
Copy link
Contributor

@github-actions github-actions bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ PERF-4 (docs)

Creating a new object literal on every showConfirmModal call causes unnecessary re-renders. The spread operator ...options combined with the wrapping object creates a new object reference each time, preventing React from optimizing renders.

Suggested fix:

const showConfirmModal = useCallback((options: ConfirmModalOptions) => {
    return context.showModal({
        component: ConfirmModalWrapper,
        props: {
            shouldHandleNavigationBack: true,
            ...options,
        },
    });
}, [context]);

Or if shouldHandleNavigationBack should be overridable:

const showConfirmModal = useCallback((options: ConfirmModalOptions) => {
    return context.showModal({
        component: ConfirmModalWrapper,
        props: {
            ...options,
            shouldHandleNavigationBack: options.shouldHandleNavigationBack ?? true,
        },
    });
}, [context]);

Copy link
Contributor

@roryabraham roryabraham Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hook is correctly compiled by React Compiler, so this should be safe to ignore

shouldHandleNavigationBack: true,
...options,
},
});
};

Expand Down
Loading