Skip to content

Conversation

@jakubkalinski0
Copy link
Contributor

@jakubkalinski0 jakubkalinski0 commented Dec 22, 2025

Explanation of Change

The whole issue comes from forwardRef being deprecated in the near future of react thus we will no longer be able to access the passed ref by element.ref as forwardRef is needed for passing ref as a separate attribute. Now in order to pass there reference it has to be passed as one of the props so we can access it directly or like that -> element.props.ref.

In order to adjust the codebase to new react recommendations in every file that was using forwardRef the ref had to be moved to the props instead of being a separate attribute and forwardRef had to be completely removed.

In response to the number of files that needed adjusting the changes are made in batches with this one being the ninth one.

  1. NOTE: This PR removes the custom react forwardRef as it is no longer needed since all the usages of forwardRef have been removed -> removal of react.d.ts file

  2. [NO QA] NOTE: This PR also takes care of unused ref's noticed in the previous batches -> they are mostly NO QA as it's a simple code cleanup (some will require tests)

  3. UNUSED COMPONENTS (@mountiny): There are 2 components which are used in the code but never activated in App:

    • KeyboardDismissibleFlatList only renders when @components/FlatList is given enableAnimatedKeyboardDismissal=true, but that prop isn’t set to True anywhere today, so the component never mounts in normal app use.
    • AnimatedFlatListWithCellRenderer is used only inside KeyboardDismissibleFlatList, so it likewise never mounts.

The decision what should be done with those components has to be made (there is also a KeyboardDismissibleFlatListContext so it's usefulness also needs to checked)

Modified files are grouped below by the components they are related to. In order to make testing easier there are also screenshots of places in app where you can find those components.

FlatListWithScrollKey
  1. src/components/FlatList/FlatListWithScrollKey/BaseFlatListWithScrollKey.tsx
  2. src/components/FlatList/FlatListWithScrollKey/index.ios.tsx
  3. src/components/FlatList/FlatListWithScrollKey/index.tsx
  4. src/components/FlatList/FlatListWithScrollKey/types.ts
Screenshot 2026-01-19 at 02 36 30
ValidateCodeCountdown
  1. src/pages/signin/ValidateCodeCountdown/index.tsx
  2. src/pages/signin/ValidateCodeCountdown/types.ts
Screenshot 2026-01-19 at 02 33 16

Unused ref's removal requiring testing

ContextMenu
  1. src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
  2. src/components/ContextMenuItem.tsx
Screenshot 2026-01-19 at 02 43 16 1 Screenshot 2026-01-19 at 03 18 34
DatePicker
  1. src/pages/EditReportFieldDate.tsx
  2. src/components/DatePicker/index.tsx
  3. src/components/DatePicker/types.ts
Screenshot 2026-01-19 at 03 13 52 Screenshot 2026-01-19 at 03 14 28
OptionRowRendererComponent
  1. src/components/LHNOptionsList/OptionRowRendererComponent/index.native.tsx
Screenshot 2026-01-19 at 02 57 58

[NO QA] files are listed below:

Files with removed forwardRef's

AnimatedFlatListWithCellRenderer -> not used anywhere in App
  1. src/components/AnimatedFlatListWithCellRenderer.tsx
KeyboardDismissibleFlatList -> not used anywhere in App
  1. src/components/KeyboardDismissibleFlatList/index.ios.tsx
  2. src/components/KeyboardDismissibleFlatList/index.tsx

Unused ref's removal

  1. src/types/modules/react.d.ts - COMPLETELY REMOVED
signin/ValidateCodeForm
  1. src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.tsx
  2. src/pages/signin/ValidateCodeForm/index.android.tsx
  3. src/pages/signin/ValidateCodeForm/index.tsx
ValidateCodeActionForm
  1. src/components/ValidateCodeActionForm/type.ts
PopoverWithoutOverlay
  1. src/components/PopoverWithoutOverlay/index.tsx
  2. src/components/PopoverWithoutOverlay/types.ts
TimePicker
  1. src/components/TimePicker/TimePicker.tsx
  2. tests/ui/components/TimePickerTest.tsx
  3. src/components/AmountTextInput.tsx - clearly not a TimePicker but the testID was added to it to allow for proper testing of the TimePicker component
HighlightableMenuItem
  1. src/components/HighlightableMenuItem.tsx
AvatarCapture
  1. src/pages/settings/Profile/Avatar/AvatarCapture/types.ts
Lottie
  1. src/components/Lottie/index.tsx
AccountValidatePage
  1. src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Fixed Issues

$ #67033
PROPOSAL: N/A

Tests

  1. Open the App and log out
  2. When logged out input your phone or email and press continue
  3. Verify that Request a new code in 00:30 countdown works properly
  4. Complete logging in
  5. Go to any 1:1 chat and input any message
  6. Hover over the message
  7. Verify that the menu pops up and that you can click any item on this menu
  8. Now go to a workspace that you own -> go to Reports and turn on Report fields -> press Add field and choose Type Date
  9. Now create a report to this workspace and create at least 2 expenses within this report
  10. Go to this report and verify that the list of it's transactions renders and works properly
  11. Then press the date field of the report and verify that the EditReportFieldDatePage and DatePicker field on this page render and work properly. Try changing the date of the report and verify that it changed properly

On mobile

  1. Simply log in and go to Inbox
  2. Verify that the list of chats and elements rendered properly
  3. Press any element and verify that it works properly
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-01-19.at.03.50.04.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-19.at.03.47.28.mov

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/AmountTextInput.tsx 100.00% <ø> (ø)
src/components/ContextMenuItem.tsx 0.00% <ø> (ø)
src/components/DatePicker/index.tsx 0.00% <ø> (ø)
...nsList/OptionRowRendererComponent/index.native.tsx 100.00% <100.00%> (ø)
src/components/Lottie/index.tsx 70.90% <100.00%> (+1.41%) ⬆️
src/components/PopoverWithoutOverlay/index.tsx 0.00% <ø> (ø)
src/components/TimePicker/TimePicker.tsx 28.82% <100.00%> (-1.33%) ⬇️
src/components/ValidateCodeCountdown/index.tsx 100.00% <ø> (ø)
src/pages/EditReportFieldDate.tsx 0.00% <ø> (ø)
...report/ContextMenu/BaseReportActionContextMenu.tsx 0.00% <ø> (ø)
... and 11 more
... and 9 files with indirect coverage changes

@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@jakubkalinski0 jakubkalinski0 marked this pull request as ready for review January 19, 2026 02:53
@melvin-bot melvin-bot bot removed the request for review from a team January 19, 2026 02:53
@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Jan 19, 2026

Just to confirm: this is last cleanup PR which removes all deprecated forwardRef / unused ref usages throughout the app?

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2e2e6a89a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jakubkalinski0
Copy link
Contributor Author

jakubkalinski0 commented Jan 19, 2026

@aimane-chnaif It's mostly cleanup but it also takes care of the last few (I believe 8) occurrences of forwardRef. More info is in the PR description - I tried to write it as thoroughly as possible

@joekaufmanexpensify
Copy link
Contributor

No product considerations, removing my review

@joekaufmanexpensify joekaufmanexpensify removed their request for review January 19, 2026 21:38
@jakubkalinski0
Copy link
Contributor Author

ESLINT check fail unrelated - fails on main

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Jan 20, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
DatePicker-ios.mov
FlatListWithScrollKey-ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
ContextMenu.mov
DatePicker.mov
FlatListWithScrollKey.mov

@aimane-chnaif
Copy link
Contributor

Please merge main and fix lint

@jakubkalinski0
Copy link
Contributor Author

@aimane-chnaif on it

* FlatList component that handles initial scroll key.
*/
function FlatListWithScrollKey<T>(props: FlatListWithScrollKeyProps<T>, ref: ForwardedRef<RNFlatList>) {
function FlatListWithScrollKey<T>({ref, ...props}: FlatListWithScrollKeyProps<T>) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: I think we can simplify this component.

import BaseFlatListWithScrollKey from './BaseFlatListWithScrollKey';

export default BaseFlatListWithScrollKey;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t just re-export it because this wrapper forwards the ref that's used to call scroll methods

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should {...props} forward already as props contains ref?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yeah, actually the concern with access to scroll methods isn't relevant, but now I am not sure how major is the difference in props since BaseFlatListWithScrollKey and FlatListWithScrollKey have different prop types.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

description={contextAction.getDescription?.(selection) ?? ''}
isAnonymousAction={contextAction.isAnonymousAction}
isFocused={focusedIndex === index}
shouldPreventDefaultFocusOnPress={contextAction.shouldPreventDefaultFocusOnPress}
onFocus={() => setFocusedIndex(index)}

P2 Badge Restore Enter-key activation for focused context menu items

When navigating the report action context menu with the keyboard (arrow keys), focusedIndex is still tracked and applied to items, but the Enter-key shortcut that previously triggered the focused item was removed along with the imperative ref. As a result, on web/desktop keyboard users can focus items but pressing Enter no longer invokes onPress, so the menu is not operable without a mouse. Consider re‑adding an Enter handler (e.g., useKeyboardShortcut) or otherwise wiring focused items to activate on Enter.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@aimane-chnaif
Copy link
Contributor

@chatgpt-codex-connector
Copy link

To use Codex here, create a Codex account and connect to github.

@melvin-bot melvin-bot bot requested a review from mountiny January 23, 2026 12:56
@jakubkalinski0
Copy link
Contributor Author

@aimane-chnaif I've got carried away with those displayNames and forgot to remove them 😆

@mountiny mountiny changed the title Jakubkalinski0/fix console errors related to forward ref batch9 Fix console errors related to forward ref batch9 Jan 24, 2026
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lets give it a go, but let's be on a look out for the issues in the flows using the arrows

@mountiny mountiny merged commit f251b86 into Expensify:main Jan 24, 2026
32 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants