GPS distance request tab - desktop content#78287
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (103KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@joekaufmanexpensify and @cristipaval please ignore, @dukenv0307 and @AndrewGable will review this |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-07.at.21.59.12.moviOS: HybridAppScreen.Recording.2026-01-07.at.22.00.05.moviOS: mWeb SafariScreen.Recording.2026-01-07.at.21.56.19.movMacOS: Chrome / SafariScreen.Recording.2026-01-07.at.21.53.44.mov |
|
🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #79014. |
|
@Expensify/design All yours |
|
@dubielzyk-expensify did we end up deciding to use the app callout on desktop? I remember there being some convo around doing something different. (But personally, I prefer this approach.) |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Whats next project
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
We didn't. This looks according to what we designed 👍 |
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.96-1 🚀
|
That looks good. Thank you!! |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|



Explanation of Change
Showing GPS tab on the web with web specific content
Fixed Issues
$ #77224
Tests
Track DistanceGPStabGPStabDownload the appbutton opens https://use.expensify.com/expensify-mobile-appOffline tests
Same as Tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2025-12-22.at.15.40.27.mov