Update company export page route params#78323
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Evidence: Screen.Recording.2025-12-23.at.11.15.04.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Update company export page route params (cherry picked from commit 72de675) (cherry-picked to staging by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.86-4 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.87-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀
|
Explanation of Change
Fixed Issues
$ #78317
$ #78334
$ #78348
$ #78346
PROPOSAL: N/A
Tests
Pre-condition: Log in with an account with assigned company cards and link an accounting service (Quickbooks on this case)
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Pre-condition: Log in with an account with assigned company cards and link an accounting service (Quickbooks on this case)
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-23.at.11.15.04.mov