feat: Add promo offer to Xero on Accounting page#78586
feat: Add promo offer to Xero on Accounting page#78586mountiny merged 10 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Ollyws Are you able to review? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
@mountiny Yeah will do asap. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Question for @LLPeckham : Do we want the promo offer even when you're connected to another accounting solution? It's currently built so it only shows when you're not connected: cc @Expensify/design for visibility as well |
|
Let me know when it's ready for another design review 👍 |
|
@dubielzyk-expensify -- Sorry just got back from OOO! To answer your question above -- I think we should keep the logic the same for now, so yes let's only show it when you're not connected.
|
|
Alright. I think we're ready to go from a UX perspective then. Let's get this into code review as we'll wanna get this out before our newsletter mid-Jan 👍 |
|
This one from Jon's comment above:
Basically just trying out the condensed version of the badge but otherwise I think it's the same as how this PR is currently implementing it. |
|
Yep, let's roll with that |
|
@dubielzyk-expensify I updated, here is the result.
|
|
@dubielzyk-expensify @dannymcclain thoughts? |
|
Yeah I think that's better - send it! |
|
Agree. Thanks for the changes! Let's get this shipped |
|
Will finish off the review today. |
|
@Ollyws I notice that the bug also happens on other pages. Example edit workflow page.
|
|
@Ollyws can you also repro on other pages? |
|
Yeah good point I can also repro on other pages, so we can say this is out of scope here. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: HybridApp03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4 |
|
Do we have a timeline on when this will be live? |
mountiny
left a comment
There was a problem hiding this comment.
Thanks for the thorough testing and working with the design team to align on the best result
|
@NickTooker I believe by the end of the week, we should be live, even if we need to revert due to some unforseen blockers. Wednesday is the soonest ETA 🤞 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|









Explanation of Change
feat: Add promo offer to Xero on Accounting page
Fixed Issues
$ #77750
PROPOSAL: #77750 (comment)
Tests
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-30.at.22.56.55.mov
Android: mWeb Chrome
Screen.Recording.2025-12-30.at.21.51.19.mov
iOS: Native
Screen.Recording.2025-12-30.at.22.56.34.mov
iOS: mWeb Safari
Screen.Recording.2025-12-30.at.21.52.20.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-30.at.21.49.39.mov