fix add approver cut off by Nodebrute · Pull Request #78607 · Expensify/App

Nodebrute · 2025-12-30T19:30:30Z

Explanation of Change

Fixed Issues

$ #77357
PROPOSAL: #77357 (comment)

Tests

Precondition:

Android 16 only.
Device font size is minimum.

Go to workspace -> categories -> add category "Add approver" -> save
Go to global create menu (+) -> create expense -> category
Verify Add approver is shown instead of just Add

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Precondition:

Android 16 only.
Device font size is minimum.

Go to workspace -> categories -> add category "Add approver" -> save
Go to global create menu (+) -> create expense -> category
Verify Add approver is shown instead of just Add

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-30T19:31:02Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/TagPicker.tsx

codecov · 2025-12-30T19:39:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/CategoryPicker.tsx	`0.00% <ø> (ø)`
src/components/TagPicker.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

Nodebrute · 2025-12-30T19:40:39Z

The original plan was to migrate the Category Picker to use SelectionList instead of SelectionListWithSections. However, based on the component guidelines, SelectionListWithSections is intended for displaying data organized into multiple sections, which the Category Picker also falls under.

App/contributingGuides/SELECTION_LIST.md

Line 11 in ae4cd7c

    
           - [**`SelectionListWithSections`**](../src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx) - For displaying data organized into multiple sections

Additionally, as per the migration plan outlined in this comment, the intention is to first handle non-section use cases and later address section-based ones, potentially by optimizing SelectionList or introducing a new specialized component for multi-section scenarios. Given this, keeping the Category Picker on SelectionListWithSections aligns with the current guidance and migration strategy.

situchan · 2025-12-30T19:47:08Z

Agreed. Thanks for the explanation. I also recently noticed while reviewing PRs we should use SelectionListWithSections for sectioned list. (at least for now)

situchan · 2025-12-30T19:50:11Z

src/components/CategoryPicker.tsx

            initiallyFocusedOptionKey={selectedOptionKey ?? undefined}
            addBottomSafeAreaPadding={addBottomSafeAreaPadding}
            contentContainerStyle={contentContainerStyle}
+            listItemTitleStyles={styles.mnw100}


Can we use the same approach as used in new SelectionList? Or is mnw100 already?

The new SelectionList doesn't use a special approach, it uses FlashList instead of SectionList, which avoids the truncation issue. Since SelectionListWithSections uses SectionList, adding mnw100 via listItemTitleStyles is the correct fix for this component.

JS00001 · 2025-12-31T14:11:58Z

haha why did this assign so many people

situchan · 2026-01-02T19:30:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

situchan · 2026-01-02T19:55:29Z

src/components/CategoryPicker.tsx

            initiallyFocusedOptionKey={selectedOptionKey ?? undefined}
            addBottomSafeAreaPadding={addBottomSafeAreaPadding}
            contentContainerStyle={contentContainerStyle}
+            listItemTitleStyles={styles.mnw100}


This doesn't seem to fix the root cause.

As you see, text still takes the 2 lines height, which leads to bug of text not centered vertically.

I debugged this and can’t reproduce the issue. The attached screenshot is from Android 16 with the minimum font size.

Can you test on Pixel_8a Android 15 with minimum font size?

joekaufmanexpensify

Makes sense 👍

JS00001 · 2026-01-06T14:55:43Z

@Nodebrute any updates on this one?

Nodebrute · 2026-01-12T19:34:03Z

Trying to repro on Pixel_8a

Nodebrute · 2026-01-19T17:01:39Z

@situchan i have updated the code and tested it on both android 16 and android 15 pixel 8_a

situchan · 2026-01-25T20:16:01Z

src/components/TagPicker.tsx


    const selectedOptionKey = sections.at(0)?.data?.find((policyTag) => policyTag.searchText === selectedTag)?.keyForList;

+    const listItemTitleStyles = useMemo(() => [styles.breakAll, styles.w100], [styles.breakAll, styles.w100]);


This component is react compilable so no need useMemo

Suggested change

const listItemTitleStyles = useMemo(() => [styles.breakAll, styles.w100], [styles.breakAll, styles.w100]);

const listItemTitleStyles = [styles.breakAll, styles.w100];

JS00001 · 2026-01-26T15:56:17Z

@Nodebrute could we update to remove the memoization, and then we can get this merged?

Nodebrute · 2026-01-27T10:02:31Z

@situchan it's ready

OSBotify · 2026-01-27T15:45:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:11:24Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:56:37Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix add approver cut off

4e6cd62

Nodebrute requested review from a team as code owners December 30, 2025 19:30

melvin-bot bot assigned Nodebrute Dec 30, 2025

melvin-bot bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify, mollfpr and trjExpensify and removed request for a team December 30, 2025 19:30

melvin-bot bot removed the request for review from a team December 30, 2025 19:31

github-actions bot reviewed Dec 30, 2025

View reviewed changes

src/components/TagPicker.tsx Outdated Show resolved Hide resolved

fix usememo

c2222c1

Nodebrute mentioned this pull request Dec 30, 2025

[$250] Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page #77357

Closed

8 tasks

situchan reviewed Dec 30, 2025

View reviewed changes

JS00001 requested review from JS00001 and removed request for JmillsExpensify, flaviadefaria, heyjennahay, mollfpr and trjExpensify December 31, 2025 14:12

situchan reviewed Jan 2, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Jan 5, 2026

View reviewed changes

Merge branch 'Expensify:main' into fixcategorypicker

f97d06a

Nodebrute and others added 2 commits January 19, 2026 21:44

Merge branch 'Expensify:main' into fixcategorypicker

3b8b1fd

change minwidth to width

37a2390

Nodebrute dismissed joekaufmanexpensify’s stale review via 37a2390 January 19, 2026 16:49

situchan approved these changes Jan 25, 2026

View reviewed changes

Nodebrute and others added 2 commits January 27, 2026 14:49

Merge branch 'Expensify:main' into fixcategorypicker

6b1fa38

remove memo

88623a7

situchan approved these changes Jan 27, 2026

View reviewed changes

JS00001 approved these changes Jan 27, 2026

View reviewed changes

JS00001 merged commit eb7175e into Expensify:main Jan 27, 2026
30 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks


		const selectedOptionKey = sections.at(0)?.data?.find((policyTag) => policyTag.searchText === selectedTag)?.keyForList;

		const listItemTitleStyles = useMemo(() => [styles.breakAll, styles.w100], [styles.breakAll, styles.w100]);

	const listItemTitleStyles = useMemo(() => [styles.breakAll, styles.w100], [styles.breakAll, styles.w100]);
	const listItemTitleStyles = [styles.breakAll, styles.w100];

Conversation

Nodebrute commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 30, 2025

Uh oh!

Uh oh!

codecov bot commented Dec 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Nodebrute commented Dec 30, 2025

Uh oh!

situchan commented Dec 30, 2025

Uh oh!

situchan Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nodebrute Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Dec 31, 2025

Uh oh!

situchan commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Nodebrute Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nodebrute Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Jan 6, 2026

Uh oh!

Nodebrute commented Jan 12, 2026

Uh oh!

Nodebrute commented Jan 19, 2026

Uh oh!

situchan Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Jan 26, 2026

Uh oh!

Nodebrute commented Jan 27, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nodebrute commented Dec 30, 2025 •

edited

Loading

codecov bot commented Dec 30, 2025 •

edited by github-actions bot

Loading

situchan Dec 30, 2025 •

edited

Loading

situchan commented Jan 2, 2026 •

edited

Loading

situchan Jan 6, 2026 •

edited

Loading