remove ONYXKEYS.ONBOARDING_COMPANY_SIZE in src/libs/ReportUtils.ts by hungvu193 · Pull Request #78623 · Expensify/App

hungvu193 · 2025-12-31T03:54:27Z

Explanation of Change

Remove Onyx.connect for ONYXKEYS.ONBOARDING_COMPANY_SIZE in ReportUtils.ts.

Fixed Issues

$ #66429
PROPOSAL: N/A

Tests

Same as QA Tests.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Login with a brand new account.
Go through on boarding steps > Choose Manage my team expenses > Choose any option.
Verify that you can complete the onboarding steps without any issues.
Verify that CompleteGuidedSetup is called with the correct companySize param.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-31.at.13.52.13.mov

codecov · 2025-12-31T04:09:00Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`72.46% <ø> (-0.07%)`	⬇️
src/libs/actions/IOU/index.ts	`68.02% <ø> (-0.23%)`	⬇️
src/libs/actions/Policy/Policy.ts	`34.08% <100.00%> (+0.05%)`	⬆️
src/libs/actions/Report.ts	`55.07% <ø> (-0.13%)`	⬇️
.../OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx	`80.55% <100.00%> (+0.55%)`	⬆️
.../pages/OnboardingPurpose/BaseOnboardingPurpose.tsx	`2.85% <0.00%> (-0.09%)`	⬇️
... and 1 file with indirect coverage changes

melvin-bot · 2025-12-31T06:59:07Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/IOU/index.ts

src/libs/actions/Policy/Policy.ts

src/libs/ReportUtils.ts

DylanDylann · 2026-01-05T09:51:17Z

@hungvu193 Could you verify again that we’re not missing the companySize parameter in any createWorkspace usage (If needed)?

DylanDylann · 2026-01-05T10:00:05Z

@hungvu193 How about the missing new param here? Is this intentional?

hungvu193 · 2026-01-05T10:05:37Z

@hungvu193 How about the missing new param here? Is this intentional?

Yep. companySize only makes sense if you chose Manage team.

DylanDylann · 2026-01-05T10:06:48Z

@hungvu193 To be safe, we should clear reasons in all cases where we skip passing the companySize parameter. Right now, it’s missing in many places without a clear reason, which I think is risky.

hungvu193 · 2026-01-05T10:11:02Z

@hungvu193 To be safe, we should clear reasons in all cases where we skip passing the companySize parameter. Right now, it’s missing in many places without a clear reason, which I think is risky.

So probably we should leave a comment to explain when companySize is required?

DylanDylann · 2026-01-05T16:05:22Z

@hungvu193 No, I mean that we have some missing places. But I want we should verify that all missing places are intentional

hungvu193 · 2026-01-07T16:02:50Z

@hungvu193 No, I mean that we have some missing places. But I want we should verify that all missing places are intentional

That's all expected since we only need companySize when Manage team option is selected.
What are the missing places that you're referring to? So I can explain 🤔

DylanDylann · 2026-01-12T09:36:49Z

@hungvu193 What about this place?

App/src/pages/OnboardingWorkspaceOptional/BaseOnboardingWorkspaceOptional.tsx

Line 81 in d335917

completeOnboardingReport({

tests/unit/ReportUtilsTest.ts

DylanDylann · 2026-01-12T09:39:49Z

The rest looks fine. Please also merge the new main

hungvu193 · 2026-01-12T09:56:14Z

@hungvu193 What about this place?

App/src/pages/OnboardingWorkspaceOptional/BaseOnboardingWorkspaceOptional.tsx

Line 81 in d335917

completeOnboardingReport({

This screen is specific to the CONST.ONBOARDING_CHOICES.PERSONAL_SPEND case, so we don't need companySize there.

DylanDylann · 2026-01-12T10:47:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-01-12.at.17.41.56.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

DylanDylann

LGTM

melvin-bot · 2026-01-12T10:47:10Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #66429 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

DylanDylann · 2026-01-12T10:48:32Z

cc @tgolen

cristipaval · 2026-01-12T11:27:30Z

Looks good to me, but it is my first PR I am reviewing, related to this initiative. I'll wait for @tgolen to review it finally.

tgolen · 2026-01-12T16:52:44Z

Looks like ESLint is failing. Can you please look into that?

DylanDylann · 2026-01-12T17:07:59Z

cc @hungvu193

hungvu193 · 2026-01-13T02:15:22Z

All yours @tgolen

OSBotify · 2026-01-13T14:40:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T03:23:44Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:31:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove ONYXKEYS.ONBOARDING_COMPANY_SIZE in src/libs/ReportUtils.ts

b4be2fc

melvin-bot bot assigned hungvu193 Dec 31, 2025

fix prettier

3be7e17

hungvu193 added 2 commits December 31, 2025 13:43

update companySize references

df93cd1

fix: Linting

3ebbafc

hungvu193 marked this pull request as ready for review December 31, 2025 06:59

hungvu193 requested review from a team as code owners December 31, 2025 06:59

melvin-bot bot requested a review from DylanDylann December 31, 2025 06:59

melvin-bot bot removed the request for review from a team December 31, 2025 06:59

hungvu193 mentioned this pull request Dec 31, 2025

[Due for payment 2026-01-21] Remove Onyx.connect() for the key: ONYXKEYS.ONBOARDING_COMPANY_SIZE in src/libs/ReportUtils.ts #66429

Closed

DylanDylann reviewed Dec 31, 2025

View reviewed changes

src/libs/actions/IOU/index.ts Outdated Show resolved Hide resolved

DylanDylann reviewed Dec 31, 2025

View reviewed changes

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into chore-66429

6a6ba86

DylanDylann reviewed Jan 5, 2026

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

update companySize mandatory for prepareOnboardingOnyxData

a95ecc6

add default companySize value

5082987

prettier changed

4c2d899

hungvu193 added 4 commits January 7, 2026 22:19

resolve conflict

13f88b9

merge submodule

0129c67

fix linting

a3ebb31

Merge remote-tracking branch 'origin/main' into chore-66429

8cdcd69

hungvu193 requested a review from DylanDylann January 12, 2026 04:14

DylanDylann reviewed Jan 12, 2026

View reviewed changes

tests/unit/ReportUtilsTest.ts Show resolved Hide resolved

hungvu193 added 3 commits January 12, 2026 17:26

add test for companySize: MICRO case

fcbf984

Merge branch 'chore-66429' of github.com:hungvu193/App into chore-66429

d55302e

Merge remote-tracking branch 'origin/main' into chore-66429

5156e0a

DylanDylann approved these changes Jan 12, 2026

View reviewed changes

melvin-bot bot requested a review from cristipaval January 12, 2026 10:47

cristipaval approved these changes Jan 12, 2026

View reviewed changes

tgolen approved these changes Jan 12, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into chore-66429

5dd00d5

cristipaval approved these changes Jan 13, 2026

View reviewed changes

cristipaval merged commit 9aae08e into Expensify:main Jan 13, 2026
30 checks passed

OSBotify mentioned this pull request Jan 14, 2026

Deploy Checklist: New Expensify 2026-01-14 #79522

Closed

39 tasks

Conversation

hungvu193 commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Jan 5, 2026

Uh oh!

DylanDylann commented Jan 5, 2026

Uh oh!

hungvu193 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Jan 5, 2026

Uh oh!

hungvu193 commented Jan 5, 2026

Uh oh!

DylanDylann commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Jan 7, 2026

Uh oh!

DylanDylann commented Jan 12, 2026

Uh oh!

Uh oh!

DylanDylann commented Jan 12, 2026

Uh oh!

hungvu193 commented Jan 12, 2026

Uh oh!

DylanDylann commented Jan 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 12, 2026

Uh oh!

DylanDylann commented Jan 12, 2026

Uh oh!

cristipaval commented Jan 12, 2026

Uh oh!

tgolen commented Jan 12, 2026

Uh oh!

DylanDylann commented Jan 12, 2026

Uh oh!

hungvu193 commented Jan 13, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hungvu193 commented Dec 31, 2025 •

edited

Loading

codecov bot commented Dec 31, 2025 •

edited by github-actions bot

Loading

hungvu193 commented Jan 5, 2026 •

edited

Loading

DylanDylann commented Jan 5, 2026 •

edited

Loading