[Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts by linhvovan29546 · Pull Request #78751 · Expensify/App

linhvovan29546 · 2026-01-01T09:44:42Z

Explanation of Change

This PR deprecates currentUserEmail as part 1 of removing Onyx.connect() for the ONYXKEYS.SESSION key in src/libs/actions/Report.ts. currentUserEmail will be removed completely after the migration is finished.

Fixed Issues

$ #73648
PROPOSAL: N/A

Tests

Test 1:

Create a single expense.
Open the newly created expense.
Click the "More" button.
Verify that the "Split" action is displayed in the menu.
Verify that you can split expense, and edit split expense

Test 2:

Open any expense.
Click the "More" button.
Select "Download as PDF".
Verify that the expense PDF downloads successfully.

Test 3:

Go to Reports > Expenses.
Select the checkbox for the expense created in Test 1.
Open the selected-items (bulk actions) dropdown.
Verify that the"Split" action is displayed in the dropdown for the selected expense.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-02.at.11.56.55.mov

Android: mWeb Chrome

Screen.Recording.2026-01-02.at.11.54.42.mov

iOS: Native

Screen.Recording.2026-01-02.at.11.52.32.mov

iOS: mWeb Safari

Screen.Recording.2026-01-02.at.11.43.25.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-02.at.11.23.03.mov

Screen.Recording.2026-01-02.at.11.32.57.mov

Screen.Recording.2026-01-02.at.11.40.24.mov

codecov · 2026-01-01T09:53:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.20% <100.00%> (ø)`
src/hooks/useSelectedTransactionsActions.ts	`82.24% <100.00%> (+0.10%)`	⬆️
src/hooks/useTodos.ts	`94.73% <100.00%> (ø)`
src/libs/PolicyUtils.ts	`53.67% <100.00%> (-0.07%)`	⬇️
src/libs/ReportPreviewActionUtils.ts	`91.34% <100.00%> (ø)`
src/libs/ReportPrimaryActionUtils.ts	`90.27% <100.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`91.78% <100.00%> (-0.02%)`	⬇️
src/libs/SearchUIUtils.ts	`60.07% <100.00%> (+0.68%)`	⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.42% <0.00%> (ø)`
src/pages/PrivateNotes/PrivateNotesEditPage.tsx	`0.00% <0.00%> (ø)`
... and 6 more
... and 9 files with indirect coverage changes

src/libs/actions/Report.ts

melvin-bot · 2026-01-02T07:42:04Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Report.ts

src/components/Search/index.tsx

src/libs/actions/Report.ts

linhvovan29546 · 2026-01-04T02:54:07Z

I've updated

linhvovan29546 · 2026-01-09T03:39:51Z

Can you please keep the currentUserLogin name instead of currentUserEmail?

I've updated

tgolen · 2026-01-09T18:48:25Z

src/components/ReportActionItem/MoneyRequestView.tsx

    const [originalTransaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${getNonEmptyStringOnyxID(transaction?.comment?.originalTransactionID)}`, {canBeMissing: true});
    const {isExpenseSplit} = getOriginalTransactionWithSplitInfo(transaction, originalTransaction);
-    const isSplitAvailable = moneyRequestReport && transaction && isSplitAction(moneyRequestReport, [transaction], originalTransaction, policy);
+    const isSplitAvailable = moneyRequestReport && transaction && isSplitAction(moneyRequestReport, [transaction], originalTransaction, currentUserPersonalDetails.email ?? '', policy);


This component already has const currentUserEmailParam = currentUserPersonalDetails.login ?? '';. Would you please:

Rename that const to currentUserLogin

Update the existing references to the new constant name

Use that same constant here for isSplitAction()

tgolen · 2026-01-09T18:51:51Z

src/components/Search/index.tsx

                    isHeld: isOnHold(transactionItem),
                    canUnhold: canUnholdRequest,
-                    canSplit: isSplitAction(transactionItem.report, [itemTransaction], originalItemTransaction, transactionItem.policy),
+                    canSplit: isSplitAction(transactionItem.report, [itemTransaction], originalItemTransaction, email ?? '', transactionItem.policy),


NAB: If email is aliased to be currentUserLogin, I think that would make it more consistent everywhere. Better yet, I think this component should use const {accountID, login} = useCurrentUserPersonalDetails(); (instead of email)

tgolen · 2026-01-09T18:53:59Z

src/components/MoneyReportHeader.tsx

            return;
        }
-        downloadReportPDF(reportPDFFilename, moneyRequestReport?.reportName ?? '', translate);
+        downloadReportPDF(reportPDFFilename, moneyRequestReport?.reportName ?? '', translate, email ?? '');


This component already has currentUserLogin so reference that instead.

tgolen · 2026-01-09T18:54:14Z

src/hooks/useSelectedTransactionsActions.ts

    const {duplicateTransactions, duplicateTransactionViolations} = useDuplicateTransactionsAndViolations(selectedTransactionIDs);
    const isReportArchived = useReportIsArchived(report?.reportID);
    const {deleteTransactions} = useDeleteTransactions({report, reportActions, policy});
+    const {email} = useCurrentUserPersonalDetails();


Use login from this instead

tgolen · 2026-01-09T18:54:38Z

src/hooks/useTodos.ts

                reportsToPay.push(report);
            }
-            if (isExportAction(report, policy, reportActions)) {
+            if (isExportAction(report, email, policy, reportActions)) {


Use login here too

tgolen · 2026-01-09T18:56:14Z

src/libs/ReportSecondaryActionUtils.ts


 function getSecondaryReportActions({
-    currentUserEmail,
+    currentUserEmail: currentUserLogin,


Rename the function parameter to currentUserLogin rather than keeping it currentUserEmail (this is the only place that getSecondaryReportActions() is called, so it's an easy change)

tgolen · 2026-01-09T18:56:32Z

src/pages/iou/SplitExpenseCreateDateRagePage.tsx

    const currentPolicy = Object.keys(policy?.employeeList ?? {}).length
        ? policy
        : currentSearchResults?.data?.[`${ONYXKEYS.COLLECTION.POLICY}${getNonEmptyStringOnyxID(currentReport?.policyID)}`];
+    const {email} = useCurrentUserPersonalDetails();


Suggested change

const {email} = useCurrentUserPersonalDetails();

const {login} = useCurrentUserPersonalDetails();

tgolen · 2026-01-09T18:56:41Z

src/pages/iou/SplitExpenseEditPage.tsx

    const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${currentReport?.policyID}`, {canBeMissing: false});

    const [policyTags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${currentReport?.policyID}`, {canBeMissing: false});
+    const {email} = useCurrentUserPersonalDetails();


Suggested change

const {email} = useCurrentUserPersonalDetails();

const {login} = useCurrentUserPersonalDetails();

tgolen · 2026-01-09T18:57:13Z

src/pages/iou/SplitExpensePage.tsx

    const searchHash = searchContext?.currentSearchHash ?? CONST.DEFAULT_NUMBER_ID;
    const [currentSearchResults] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${searchHash}`, {canBeMissing: true});
    const allTransactions = useAllTransactions();
+    const currentUserPersonalDetails = useCurrentUserPersonalDetails();


Can this be destructured to use {login} like the other components?

The function updateSplitTransactionsFromSplitExpensesFlow requires the full currentUserPersonalDetails object.

tgolen · 2026-01-09T18:57:21Z

src/pages/PrivateNotes/PrivateNotesEditPage.tsx

    const styles = useThemeStyles();
    const {translate} = useLocalize();
    const personalDetailsList = usePersonalDetails();
+    const {email} = useCurrentUserPersonalDetails();


Suggested change

const {email} = useCurrentUserPersonalDetails();

const {login} = useCurrentUserPersonalDetails();

linhvovan29546 · 2026-01-09T22:18:50Z

@tgolen const {email} = useCurrentUserPersonalDetails() This is used in many places throughout the app, not just in this PR. I think it would be better to update it in a separate PR.

tgolen · 2026-01-09T22:20:39Z

Yeah, we could, but I don't think it would hurt to start updating it in a few places that we come across it.

linhvovan29546 · 2026-01-09T22:24:33Z

~~Currently, useCurrentUserPersonalDetails doesn't have a login field. With this change, we'll define both email and login fields, right?~~

…art1

linhvovan29546 · 2026-01-09T23:33:25Z

@tgolen I've updated

neil-marcellini · 2026-01-12T15:32:30Z

Dropping off here, Tim has it under control 👋

tgolen · 2026-01-12T15:49:24Z

@linhvovan29546 this picked up quite a few conflicts. Could you please fix them and then I'll take another look at it.

…art1

linhvovan29546 · 2026-01-12T16:29:34Z

@tgolen I'v resolved conflict

tgolen

Great, thanks for helping to clean this up a little bit!

OSBotify · 2026-01-12T16:57:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-13T03:39:25Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:55:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: remove currentUserEmail from Onyx.connect

df1d586

melvin-bot bot assigned linhvovan29546 Jan 1, 2026

linhvovan29546 changed the title ~~fix: remove currentUserEmail from Onyx.connect~~ [Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts Jan 1, 2026

linhvovan29546 changed the title ~~[Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts~~ [WIP][Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts Jan 1, 2026

linhvovan29546 added 8 commits January 1, 2026 18:27

chore: remove currentUserEmail from onyx

f0f50d9

chore: disable estlint until migration success

b1faaff

chore: prettier

611b998

chore: make current user email required

dc8b49f

chore: pass email to isSplitAction

5bcaeee

test: add test for short mention in comment edits

23fdb8a

test: add test export to accounting action

bafad57

test: add test export to accounting action

f378b04

linhvovan29546 mentioned this pull request Jan 2, 2026

[Due for payment 2026-03-13] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts #73648

Closed

linhvovan29546 changed the title ~~[WIP][Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts~~ [Part 1]Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts Jan 2, 2026

linhvovan29546 added 2 commits January 2, 2026 12:07

chore: update prop

975f680

chore: eslint fail

51303ad

linhvovan29546 commented Jan 2, 2026

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

linhvovan29546 marked this pull request as ready for review January 2, 2026 07:41

linhvovan29546 requested review from a team as code owners January 2, 2026 07:41

melvin-bot bot requested review from parasharrajat and removed request for a team January 2, 2026 07:42

parasharrajat suggested changes Jan 3, 2026

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/components/Search/index.tsx Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

linhvovan29546 added 3 commits January 4, 2026 09:20

chore: rename param

543bae4

chore: update current user email and account id to deprecated

93242bc

chore: update param name

2f13241

linhvovan29546 requested a review from parasharrajat January 4, 2026 02:54

chore: rename currentUserEmail to currentUserLogin

68f519c

parasharrajat approved these changes Jan 9, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 9, 2026 07:40

tgolen requested changes Jan 9, 2026

View reviewed changes

linhvovan29546 added 7 commits January 10, 2026 05:46

chore: migrate email field to login

a56f33c

chore: migrate email field to login

af76efb

chore: migrate email field to login

6c12a49

Merge branch 'main' into fix/73648-remove-onyxkey-session-in-report-p…

a7ef374

…art1

chore: add login to deps

c4e9016

chore: migrate email field to login

fa3a028

chore: migrate email field to login

fb6340b

parasharrajat approved these changes Jan 10, 2026

View reviewed changes

neil-marcellini removed their request for review January 12, 2026 15:32

linhvovan29546 added 3 commits January 12, 2026 22:59

Merge branch 'main' into fix/73648-remove-onyxkey-session-in-report-p…

8f99610

…art1

chore: update prop name

290ffec

chore: fix typecheck fail

51fd696

tgolen approved these changes Jan 12, 2026

View reviewed changes

tgolen merged commit abd5853 into Expensify:main Jan 12, 2026
30 checks passed

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

	const {email} = useCurrentUserPersonalDetails();
	const {login} = useCurrentUserPersonalDetails();

Conversation

linhvovan29546 commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 1, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

melvin-bot bot commented Jan 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linhvovan29546 commented Jan 4, 2026

Uh oh!

linhvovan29546 commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Jan 9, 2026

Uh oh!

tgolen commented Jan 9, 2026

Uh oh!

linhvovan29546 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Jan 9, 2026

Uh oh!

neil-marcellini commented Jan 12, 2026

Uh oh!

tgolen commented Jan 12, 2026

Uh oh!

linhvovan29546 commented Jan 12, 2026

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

linhvovan29546 commented Jan 1, 2026 •

edited

Loading

codecov bot commented Jan 1, 2026 •

edited by github-actions bot

Loading

linhvovan29546 Jan 9, 2026 •

edited

Loading

linhvovan29546 commented Jan 9, 2026 •

edited

Loading