[Hold Web-Expensify#50016] RBR for Concierge on export error#78886
Closed
KioCoan wants to merge 5 commits intoExpensify:mainfrom
Closed
[Hold Web-Expensify#50016] RBR for Concierge on export error#78886KioCoan wants to merge 5 commits intoExpensify:mainfrom
KioCoan wants to merge 5 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Dismiss Export Error Action (
src/libs/actions/ReportActions.ts):- Added dismissExportError() function that calls the new DismissExportError API
- Optimistically removes the action from the UI
- On failure, restores the action with an error message
API Types (
src/libs/API/types.ts,src/libs/API/parameters/):- Added DISMISS_EXPORT_ERROR to WRITE_COMMANDS
- Created
DismissExportErrorParamstype- Added parameter mapping to
WriteCommandParametersReport Action Item (
src/pages/home/report/PureReportActionItem.tsx):- Modified
dismissErrorcallback to calldismissExportErrorfor INTEGRATIONS_MESSAGE actions- This allows users to dismiss export error messages by clicking the X button
LHN Scroll to Error (
src/pages/home/sidebar/SidebarLinks.tsx):- Added logic to find report actions with errors when navigating from LHN
- When clicking on a report with RBR in the LHN, the chat now scrolls to the specific error action
Fixed Issues
https://github.com/Expensify/Expensify/issues/583294
Tests
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.