feat: add close icon to header for concierge chat in desktop by samranahm · Pull Request #78955 · Expensify/App

samranahm · 2026-01-06T22:17:19Z

Explanation of Change

Fixed Issues

$ #78870
PROPOSAL: #78870 (comment)

Tests

Open the app on desktop web and click the Concierge chat button in the upper-right corner.
Verify the Concierge RHP opens and the back button displays a close (X) icon instead of a left chevron (back arrow).
Hover over the icon and verify the tooltip text is “Close”.
Open a report and click the report header to open the Report Details page.
Verify the Report Details RHP (and all other RHPs) use a back arrow icon.
Click the Concierge button again and verify the Concierge chat RHP and Report Details RHP are open side by side.
Verify the Report Details back arrow shows the “Back” tooltip, and the Concierge chat shows the close (X) icon with the “Close” tooltip.
Open the Concierge chat on a small screen and verify it shows a back arrow instead of the close (X) icon.

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Android.mWeb.Chrome.mov

iOS: Native

iOS: mWeb Safari

IOS.mWeb.safari.mov

MacOS: Chrome / Safari

macOS.Chrome.mp4

Copilot

Pull request overview

This PR adds a close icon to the header for the Concierge chat when displayed in a side panel on desktop, replacing the standard back arrow. This provides a clearer user experience indicating that the Concierge chat can be closed rather than navigated back from.

Conditionally displays a close (X) icon instead of a back arrow for Concierge chat in side panels on desktop
Updates tooltip and accessibility labels to reflect "Close" vs "Back" based on the icon shown
Maintains back arrow behavior on small screens and for non-Concierge chats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T22:23:26Z

src/pages/home/HeaderView.tsx

+    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
+    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
+    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');


The new behavior for showing a close icon for concierge chat in the side panel lacks test coverage. Consider adding a test case that verifies the close icon is displayed when the header is rendered for a concierge chat in a side panel on desktop, and that the back arrow is shown in other scenarios.

Copilot · 2026-01-06T22:23:26Z

src/pages/home/HeaderView.tsx

-                                    accessibilityLabel={translate('common.back')}
+                                    accessibilityLabel={backButtonLabel}
                                    role={CONST.ROLE.BUTTON}
                                    sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}


The sentry label remains 'BACK_BUTTON' even when the button functions as a close button for the concierge chat. This could make analytics and error tracking less accurate. Consider using a conditional sentry label or adding a CLOSE_BUTTON constant to CONST.SENTRY_LABEL.HEADER_VIEW to differentiate between the two button types.

Suggested change

sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}

sentryLabel={isChatUsedForOnboarding ? 'HEADER_VIEW.CLOSE_BUTTON' : CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}

ZhenjaHorbach · 2026-01-07T09:16:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

2026-01-07.10.43.24.mov

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

samranahm · 2026-01-07T09:24:50Z

Let me merge main to fix the performance check.

ZhenjaHorbach · 2026-01-07T09:45:30Z

LGTM!

OSBotify · 2026-01-07T17:43:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-08T16:49:40Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:18:39Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:15:01Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:21:57Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: add close icon to header for concierge chat

4894c73

Copilot AI review requested due to automatic review settings January 6, 2026 22:17

samranahm requested review from a team as code owners January 6, 2026 22:17

melvin-bot bot assigned samranahm Jan 6, 2026

melvin-bot bot requested review from JmillsExpensify, ZhenjaHorbach and blimpich January 6, 2026 22:17

Copilot started reviewing on behalf of samranahm January 6, 2026 22:17 View session

samranahm mentioned this pull request Jan 6, 2026

[Due for payment 2026-01-16] [$150] Use X icon for closing the Concierge RHP instead of chevron #78870

Closed

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Merge branch 'Expensify:main' into 78870/concierge-rhp-use-close-icon

5fef001

ZhenjaHorbach approved these changes Jan 7, 2026

View reviewed changes

blimpich approved these changes Jan 7, 2026

View reviewed changes

blimpich merged commit d2fe104 into Expensify:main Jan 7, 2026
31 checks passed

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add close icon to header for concierge chat in desktop#78955

feat: add close icon to header for concierge chat in desktop#78955
blimpich merged 2 commits intoExpensify:mainfrom
samranahm:78870/concierge-rhp-use-close-icon

samranahm commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

ZhenjaHorbach commented Jan 7, 2026 •

edited

Loading

Uh oh!

samranahm commented Jan 7, 2026

Uh oh!

ZhenjaHorbach commented Jan 7, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
	sentryLabel={isChatUsedForOnboarding ? 'HEADER_VIEW.CLOSE_BUTTON' : CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}

Conversation

samranahm commented Jan 6, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

samranahm commented Jan 7, 2026

Uh oh!

ZhenjaHorbach commented Jan 7, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented Jan 7, 2026 •

edited

Loading