fix: infinite loading appears when logging in via hellogorgeous link by paulnjs · Pull Request #78987 · Expensify/App

paulnjs · 2026-01-07T10:39:59Z

Explanation of Change

Fix regression in #78626

Fixed Issues

$#73506
PROPOSAL:#73506 (comment)

Tests

Logout if you’re currently logged in
Open the following link in your browser: https://staging.new.expensify.com/r/hellogorgeous
Log in using a Google account
Verify the app redirects to your most recently accessed report (or the Concierge report for new users), rather than getting stuck in an infinite loading state.
On small screen, tap the back button and verify you go back to the Inbox page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Logout if you’re currently logged in
Open the following link in your browser: https://staging.new.expensify.com/r/hellogorgeous
Log in using a Google account
Verify the app redirects to your most recently accessed report (or the Concierge report for new users), rather than getting stuck in an infinite loading state.
On small screen, tap the back button and verify you go back to the Inbox page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-11-22.at.10.33.56.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-11-22.at.10.28.00.mov

MacOS: Chrome / Safari

chorme.mov

Screen.Recording.2026-01-07.at.17.55.26.mov

codecov · 2026-01-07T10:48:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/Link.ts	`30.50% <0.00%> (ø)`
... and 5 files with indirect coverage changes

melvin-bot · 2026-01-07T11:26:21Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paulnjs · 2026-01-07T11:28:24Z

@joekaufmanexpensify I'am unable to test #78610. Could you please help to build and test this issue?

ahmedGaber93 · 2026-01-08T20:55:11Z

src/libs/actions/Link.ts

                                    callback: (report) => {
                                        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-                                        if (report?.errorFields?.notFound || report?.reportID) {
+                                        if (report?.errorFields?.notFound || report?.reportID || (report === undefined && /\D/.test(reportID))) {


Suggested change

if (report?.errorFields?.notFound || report?.reportID || (report === undefined && /\D/.test(reportID))) {

if (report?.errorFields?.notFound || report?.reportID || (report === undefined && !CONST.REGEX.NUMBER.test(reportID))) {

Let's use !CONST.REGEX.NUMBER.test(reportID) if it will do the same job.

@ahmedGaber93 !CONST.REGEX.NUMBER.test(reportID) will return true if reportID is empty while /\D/.test(reportID) return false

Okay, we can use the existing regex CONST.REGEX.NON_NUMERIC for that. I’m just looking forward to some additional cleanup.

ahmedGaber93 · 2026-01-08T21:29:56Z

@paulnjs Are you facing the same issue? iOS - public room deeplink doesn’t always open correctly and sometimes redirects to the login screen.

20260108232632215.mp4

ahmedGaber93 · 2026-01-08T21:30:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

202601121539376512.mov

20260112154318143.mp4

Android: mWeb Chrome

20260110145047021.mp4

iOS: HybridApp

20260108231303564.mp4

20260108231104272.mp4

iOS: mWeb Safari

20260108225116855.mp4

MacOS: Chrome / Safari

20260108201420187.mp4

paulnjs · 2026-01-09T08:40:00Z

Are you facing the same issue?

@ahmedGaber93 It's still working well with me

Screen.Recording.2026-01-09.at.15.38.38.mov

ahmedGaber93 · 2026-01-10T12:56:00Z

It's still working well with me

I’m also able to reproduce it without this PR change.

Could you please complete the cleanup mentioned here so we can move forward? #78987 (comment)

paulnjs · 2026-01-12T05:25:10Z

@ahmedGaber93 Updated, the test fail from main and could you help to test #78610? I'm unable to test it with Google account.

ahmedGaber93 · 2026-01-12T14:02:00Z

@paulnjs I’m not able to reproduce #78610 on the standalone app. And unfortunately, I can’t test the deep link on the hybrid DEV app on android at the moment—I’ve asked on Slack about fixing this.

Could you please add test cases for this scenario?

I’ll request an ad-hoc build so I can test it on the hybrid app as well.

ahmedGaber93 · 2026-01-12T14:08:05Z

@aldo-expensify I’m having issues opening deep links on the Android hybrid dev app. Could you please trigger an ad-hoc Android build so we can test this issue on the hybrid app?

github-actions · 2026-01-12T14:29:46Z

🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-12T14:56:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78987.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f68574ccf590a57eda97b93db2daeb039d252bb0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-80f6a7bdcf4b9a4b0c3797c333eeec65f04572cf/index.html

Web 🕸️
https://78987.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ahmedGaber93 · 2026-01-12T15:43:44Z

Works well on Android hybrid app.

Exist account

Android: HybridApp

WhatsApp.Video.2026-01-12.at.5.39.04.PM.mp4

New account

Android: HybridApp

WhatsApp.Video.2026-01-12.at.5.38.57.PM.mp4

ahmedGaber93 · 2026-01-12T15:46:41Z

@paulnjs just a reminder to please add test cases for this scenario. Thanks!

On small screen, tap the back button and verify you go back to the Inbox page.

paulnjs · 2026-01-12T17:33:07Z

@ahmedGaber93 Added. Thanks for reminder!

OSBotify · 2026-01-12T18:07:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-13T03:39:49Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:56:06Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: infinite loading appears when logging in via hellogorgeous link

7a36dd2

melvin-bot bot assigned paulnjs Jan 7, 2026

Merge branch 'main' into paulnjs-fix/73506-part-2

0b8db13

paulnjs marked this pull request as ready for review January 7, 2026 11:26

paulnjs requested review from a team as code owners January 7, 2026 11:26

melvin-bot bot requested review from ahmedGaber93 and joekaufmanexpensify and removed request for a team January 7, 2026 11:26

joekaufmanexpensify previously approved these changes Jan 7, 2026

View reviewed changes

ahmedGaber93 suggested changes Jan 8, 2026

View reviewed changes

paulnjs added 2 commits January 12, 2026 09:18

Merge branch 'main' into paulnjs-fix/73506-part-2

9191cdc

update code

4ea2031

paulnjs dismissed joekaufmanexpensify’s stale review via 4ea2031 January 12, 2026 02:20

ahmedGaber93 approved these changes Jan 12, 2026

View reviewed changes

melvin-bot bot requested a review from aldo-expensify January 12, 2026 15:46

aldo-expensify approved these changes Jan 12, 2026

View reviewed changes

Merge branch 'main' into paulnjs-fix/73506-part-2

d55a14d

aldo-expensify merged commit a2dafc1 into Expensify:main Jan 12, 2026
28 checks passed

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

paulnjs mentioned this pull request Feb 20, 2026

Infinite loading appears when tap back from a redirect after logging in via deeplink #78610

Open

7 tasks

	if (report?.errorFields?.notFound \|\| report?.reportID \|\| (report === undefined && /\D/.test(reportID))) {
	if (report?.errorFields?.notFound \|\| report?.reportID \|\| (report === undefined && !CONST.REGEX.NUMBER.test(reportID))) {

Conversation

paulnjs commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 7, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 7, 2026

Uh oh!

paulnjs commented Jan 7, 2026

Uh oh!

ahmedGaber93 Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

paulnjs Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Jan 8, 2026

Uh oh!

ahmedGaber93 commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

paulnjs commented Jan 9, 2026

Uh oh!

ahmedGaber93 commented Jan 10, 2026

Uh oh!

paulnjs commented Jan 12, 2026

Uh oh!

ahmedGaber93 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

ahmedGaber93 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulnjs commented Jan 12, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paulnjs commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited by github-actions bot

Loading

ahmedGaber93 commented Jan 8, 2026 •

edited

Loading

ahmedGaber93 commented Jan 12, 2026 •

edited

Loading

ahmedGaber93 commented Jan 12, 2026 •

edited

Loading

ahmedGaber93 commented Jan 12, 2026 •

edited

Loading