Skip to content

[Do not review] Multifactor Authentication - Test branch#78996

Closed
JakubKorytko wants to merge 6 commits intoExpensify:mainfrom
software-mansion-labs:korytko/multifactor-authentication-release-1
Closed

[Do not review] Multifactor Authentication - Test branch#78996
JakubKorytko wants to merge 6 commits intoExpensify:mainfrom
software-mansion-labs:korytko/multifactor-authentication-release-1

Conversation

@JakubKorytko
Copy link
Copy Markdown
Contributor

@JakubKorytko JakubKorytko commented Jan 7, 2026

Explanation of Change

This PR introduces the initial release of Multifactor Authentication for the EU/UK Expensify Cards project.
It is not yet complete; the following must be done before it can be opened:

  • Add the tests to cover the automated tests section of the 3DS doc
  • Wait for the backend implementation to be ready - current videos in this PR are recorded using mocked backend
  • Comment the code
  • Show the settings deep link notification page when the biometrics are not enabled
  • Fix the 'go back' button navigation (perhaps a new trigger for going back is needed)
  • Add the fingerprint hashing Store the public key in base64 format (convo)
  • Split this PR into smaller ones

Potential follow-ups / changes with lower priority:

Fixed Issues

$ #79058
$ #79059
PROPOSAL: N/A

Tests

TBA

Offline tests

TBA

QA Steps

TBA

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 83.89% <ø> (+1.69%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
...onents/MultifactorAuthentication/config/helpers.ts 100.00% <100.00%> (ø)
...mponents/MultifactorAuthentication/config/index.ts 100.00% <100.00%> (ø)
...ntication/config/scenarios/DefaultUserInterface.ts 100.00% <100.00%> (ø)
...ultifactorAuthentication/config/scenarios/index.ts 100.00% <100.00%> (ø)
...thentication/useMultifactorAuthenticationStatus.ts 100.00% <100.00%> (ø)
...on/useNativeBiometrics/useNativeBiometricsSetup.ts 100.00% <100.00%> (ø)
...ionModal/ValidateCodeForm/BaseValidateCodeForm.tsx 83.33% <ø> (ø)
src/components/ValidateCodeCountdown/index.tsx 100.00% <ø> (ø)
... and 26 more
... and 257 files with indirect coverage changes

@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch 2 times, most recently from 979f920 to 5ff2e34 Compare January 7, 2026 14:16
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jan 7, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch from f9c3c88 to 2486d0b Compare January 7, 2026 19:27
@JakubKorytko JakubKorytko changed the title [WIP] [Expensify Cards EU/UK] Multifactor Authentication Release 1 [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in Troubleshoot Menu Jan 8, 2026
@JakubKorytko JakubKorytko changed the title [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in Troubleshoot Menu [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in the Troubleshoot Menu Jan 8, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch 7 times, most recently from 775c44f to 9dd9a89 Compare January 12, 2026 13:46
@JakubKorytko JakubKorytko changed the title [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in the Troubleshoot Menu [CANCELED] [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in the Troubleshoot Menu Jan 13, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch 14 times, most recently from 5b79969 to 072675d Compare January 14, 2026 14:47
@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch 19 times, most recently from a7eabb5 to 8618ce9 Compare January 19, 2026 17:56
@JakubKorytko JakubKorytko changed the title [CANCELED] [WIP] [Release 1] [Expensify Cards EU/UK] Multifactor Authentication - Biometrics Test in the Troubleshoot Menu [Do not review] Multifactor Authentication - Test branch Jan 19, 2026
@JakubKorytko JakubKorytko force-pushed the korytko/multifactor-authentication-release-1 branch from 8618ce9 to e4bba27 Compare January 19, 2026 18:05
@JakubKorytko
Copy link
Copy Markdown
Contributor Author

everything splitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant