[Do not review] Multifactor Authentication - Test branch#78996
Closed
JakubKorytko wants to merge 6 commits intoExpensify:mainfrom
Closed
[Do not review] Multifactor Authentication - Test branch#78996JakubKorytko wants to merge 6 commits intoExpensify:mainfrom
JakubKorytko wants to merge 6 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
979f920 to
5ff2e34
Compare
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
f9c3c88 to
2486d0b
Compare
775c44f to
9dd9a89
Compare
5b79969 to
072675d
Compare
a7eabb5 to
8618ce9
Compare
8618ce9 to
e4bba27
Compare
Contributor
Author
|
everything splitted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR introduces the initial release of Multifactor Authentication for the EU/UK Expensify Cards project.
It is not yet complete; the following must be done before it can be opened:
Add the fingerprint hashingStore the public key in base64 format (convo)Potential follow-ups / changes with lower priority:
scenarioandnotificationPathsas a part of MultifactorAuthenticationPartialStatus instead of passing them as the arguments of setStatusFixed Issues
$ #79058
$ #79059
PROPOSAL: N/A
Tests
TBA
Offline tests
TBA
QA Steps
TBA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari