Skip to content

[No QA] Update Global-Reimbursement-EU.md#79038

Merged
sakluger merged 3 commits intomainfrom
sakluger-patch-4
Jan 9, 2026
Merged

[No QA] Update Global-Reimbursement-EU.md#79038
sakluger merged 3 commits intomainfrom
sakluger-patch-4

Conversation

@sakluger
Copy link
Contributor

@sakluger sakluger commented Jan 7, 2026

@RachCHopkins please review

Explanation of Change

  • Added a note about ensuring beneficiary name matches with the bank.
  • Also changed "Deposit-only bank account" to "Personal bank account" to match the product.

Fixed Issues

https://github.com/Expensify/Expensify/issues/581325

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Add note about ensuring beneficiary name matches with the bank.
@sakluger sakluger requested a review from RachCHopkins January 7, 2026 21:09
@sakluger sakluger requested a review from a team as a code owner January 7, 2026 21:09
@melvin-bot melvin-bot bot removed the request for review from a team January 7, 2026 21:09
- Go to **Settings > Account > Wallet**.
- Click **Add deposit-only bank account** and input their account details.
- Click **Add Personal Bank Account** and input their account details.
- When you add your bank account, please ensure that the name on the account is an exact match to the name at the bank's end. Any mismatch may cause delays or prevent processing entirely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: This sentence is overly verbose and uses formal language ("at the bank's end", "entirely"). Simplify for 8th-grade reading level.

Suggested revision:

- Make sure the name on your account exactly matches your bank records. Name mismatches can delay or block payments.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

HelpDot Documentation Review

Overall Assessment

This PR makes two small but important improvements to the Global Reimbursement EU documentation: (1) updates outdated UI terminology from "deposit-only bank account" to "Personal Bank Account" to match the current product, and (2) adds a critical warning about ensuring beneficiary names match bank records to prevent payment processing issues.

Scores Summary

  • Readability: 7/10 - The added warning is important but grammatically awkward with redundant phrasing ("the name on the account" / "the name at the bank's end"). The sentence structure could be more concise and natural.
  • AI Readability: 9/10 - Clear context and proper structure. The terminology update improves accuracy for AI parsing. Minor improvement possible: the warning could be formatted as a callout/note block for better visibility.
  • Style Compliance: 8/10 - Correctly updates UI terminology to match product standards. The warning follows instructional style but lacks the formatting conventions typically used for important notices (e.g., blockquote or bold emphasis).

Key Findings

Positive aspects:

  • Addresses a real user issue (name mismatch causing payment delays)
  • Updates terminology to match current product UI
  • Places the warning at the logical point in the workflow

Areas for improvement:

  • The new sentence is grammatically awkward: "ensure that the name on the account is an exact match to the name at the bank's end" could be simplified to "ensure the account name exactly matches the name registered with your bank"
  • Redundant language: "Any mismatch may cause delays or prevent processing entirely" - "or prevent processing entirely" is redundant since prevention is implied by delays
  • Missing visual emphasis: Critical warnings about processing delays typically use formatting like blockquotes, bold text, or callout blocks
  • The warning appears as a sub-bullet under employees' instructions, but it's important enough to warrant its own step or prominent callout

Recommendations

Priority actions:

  1. Simplify the warning text to: "Ensure your account name exactly matches the name registered with your bank. Mismatches may delay or prevent payment processing."
  2. Add visual emphasis using markdown formatting (blockquote or bold text for the note label)
  3. Consider elevating this warning to a standalone bullet point at the same level as the wallet instructions, rather than nested within

Files Reviewed

  • docs/articles/expensify-classic/bank-accounts-and-payments/payments/Global-Reimbursement-EU.md: Minor improvements needed to grammar and formatting; content change is valuable and addresses user needs.

Note: This is a small PR with limited scope. The suggestions above are refinements rather than critical issues.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2026

A preview of your ExpensifyHelp changes have been deployed to https://2f40eff7.helpdot.pages.dev ⚡️

Updated articles:

@sakluger sakluger requested a review from johncschuster January 9, 2026 18:47
- Go to **Settings > Account > Wallet**.
- Click **Add deposit-only bank account** and input their account details.
- Click **Add Personal Bank Account** and input their account details.
- Ensure the name on the account in Expensify exactly matches the name at the bank. Any mismatch may cause delays or prevent processing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave ChatGPT a heaping helping of context into this change, and it made a suggestion. I think it might be valuable to make it a little more clear just how important this is. Here's what ChatGPT gave me:

Important: The name on an employee’s bank account must exactly match the name entered in Expensify.
This verification is required for every payment, and mismatches may cause delays or prevent processing.

Do with that what you will!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@johncschuster johncschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sakluger sakluger merged commit 8babc8e into main Jan 9, 2026
12 of 14 checks passed
@sakluger sakluger deleted the sakluger-patch-4 branch January 9, 2026 19:10
@melvin-bot melvin-bot bot added the Emergency label Jan 9, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2026

@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@sakluger sakluger removed the Emergency label Jan 9, 2026
@sakluger
Copy link
Contributor Author

sakluger commented Jan 9, 2026

All checks passed except for the checklist, which is not required for helpdot updates.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/sakluger in version: 9.3.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants