fix: Refactor ConfirmModal usage to useConfirmModal in IOU#79076
fix: Refactor ConfirmModal usage to useConfirmModal in IOU#79076roryabraham merged 3 commits intoExpensify:mainfrom
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ZhenjaHorbach Not sure what happen with the previous PR, I created another one |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-12-11.14.49.37.mov2025-12-11.14.50.37.mov2025-12-11.14.51.16.mov2025-12-11.14.52.00.movAndroid: mWeb Chrome2025-12-11.14.55.19.mov2025-12-11.14.55.51.mov2025-12-11.14.56.27.mov2025-12-11.14.57.08.moviOS: HybridApp2025-12-11.14.37.13.mov2025-12-11.14.38.17.mov2025-12-11.14.39.01.mov2025-12-11.14.40.26.moviOS: mWeb Safari2025-12-11.14.04.37.mov2025-12-11.14.11.38.mov2025-12-11.14.12.53.mov2025-12-11.14.19.19.movMacOS: Chrome / Safari2025-12-11.13.43.07.mov2025-12-11.13.51.47.mov2025-12-11.13.55.43.mov |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.97-0 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.99-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀
|
Explanation of Change
Refactor ConfirmModal usage to useConfirmModal in IOU
Fixed Issues
$ #76694
PROPOSAL:
Tests
Precondition: Enabled perdiem with rates
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-07.at.00.05.48.mov
Android: mWeb Chrome
Screen.Recording.2025-12-07.at.00.05.00.mov
Screen.Recording.2025-12-06.at.23.41.24.mov
iOS: Native
Screen.Recording.2025-12-07.at.00.06.17.mov
iOS: mWeb Safari
Screen.Recording.2025-12-07.at.00.06.49.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-06.at.23.39.29.mov
Screen.Recording.2025-12-06.at.23.40.07.mov
Screen.Recording.2025-12-06.at.23.40.41.mov