Merged
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
adhorodyski
reviewed
Jan 8, 2026
| */ | ||
| function markOpenReportEnd(reportId: string) { | ||
| endSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportId}`); | ||
| function markOpenReportEnd(reportId: string, isTransactionThread?: boolean, isOneTransactionThread?: boolean) { |
Contributor
There was a problem hiding this comment.
I think this is the only part of the PR I don't like 😅 Can we at least untangle the if/else blocks so it early returns instead of nesting the statements?
Contributor
|
@elirangoshen |
Contributor
Author
I don't think, what do you think @rlinoz ? |
rlinoz
reviewed
Jan 8, 2026
| function markOpenReportEnd(reportId: string) { | ||
| endSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportId}`); | ||
| function markOpenReportEnd(reportId: string, isTransactionThread?: boolean, isOneTransactionThread?: boolean) { | ||
| const transactionThreadSpanId = `${CONST.TELEMETRY.SPAN_OPEN_TRANSACTION_THREAD}_${reportId}`; |
Contributor
There was a problem hiding this comment.
I think if we add more attributes to the span we don't need the new span name, unless there is really a need for it.
Having the attributes below should allow us to filter any specific report we want I think..
isTransactionThread
isOneTransactionReport
report.type
Contributor
Author
There was a problem hiding this comment.
I thought about it , yes its better this way ill modify it
Contributor
Author
There was a problem hiding this comment.
Ok I modified it and added screeshot :)
rlinoz
reviewed
Jan 9, 2026
| function markOpenReportEnd(reportId: string) { | ||
| endSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportId}`); | ||
| function markOpenReportEnd(reportId: string, isTransactionThread?: boolean, isOneTransactionThread?: boolean) { | ||
| let reportType = 'report'; |
Contributor
Contributor
Author
There was a problem hiding this comment.
Sure I modified it as well
rlinoz
previously approved these changes
Jan 9, 2026
Contributor
rlinoz
left a comment
rlinoz
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Lint is failing though @elirangoshen
Contributor
Author
yes I fixed that now |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
91 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.0-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$#78953
PROPOSAL: This PR adding report transaction thread events to sentry tracking
it also adding attribute in case is it one report transaction
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Since its only adding tracking to sentry, you can verify open reports is working properly
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari