Fix report carousel disappearing after approve by skipping action filter#79132
Conversation
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
After following steps in #77957, report carousel keeps remaining until back online. Step:
Hope this would be fine. bug.mov |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b55c6037b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
Jason reported this, all good 👍
…-disappears-on-approve
…-disappears-on-approve
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|
|
BTW I'm reverting the changes in this PR. The client side filtering added caused a bad regression (and we shouldn't be doing this on the client anyways), so the flag added to skip the client-side filtering is also unnecessary #79714 |
Explanation of Change
Action-based filtering is not needed for report navigation, so we added
shouldSkipActionFilteringto bypass this logic.Fixed Issues
$ #79082
PROPOSAL: #79082 (comment)
Tests
Same QA step
Offline tests
QA Steps
Prerequisite: Be an approver on a policy with multiple reports awaiting your approval
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-09.at.02.04.53.mp4
Android: mWeb Chrome
Screen.Recording.2026-01-09.at.02.06.21.mp4
iOS: Native
Screen.Recording.2026-01-09.at.02.09.44.mp4
iOS: mWeb Safari
Screen.Recording.2026-01-09.at.02.10.59.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-01-09.at.01.57.19.mp4