[A11y] Labels & Descriptions#79146
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
Just for work tracking, assigned myself to the closed issues due to reviewing this PR |
|
@joekaufmanexpensify @dangrous I reviewed this PR and the release 7 days ago. Could you please help process the payment for me? |
Explanation of Change
Part of
Improves screen reader labels and descriptions for better accessibility by adding descriptive accessibility labels to interactive elements, including context like display names, emails, dates in labels, adding format hints for input fields, and properly translating accessibility labels.
Fixed Issues
$ #74843
$ #74865
$ #74871
$ #74881
$ #74887
$ #75469
$ #76904
$ #76912
$ #77371
$ #77378
$ #77424
$ #77449
$ #77456
$ #77457
$ #77464
$ #77533
$ #77557
$ #77559
$ #77569
$ #76913
$ #77450
$ #77452
$ #77453
$ #77455
$ #77461
$ #77564
Tests
MenuItem - Title & Description (#74843, #77455, #77564)
read")
Text Input with Hint (#77378)
Distance Amount Input (#74871)
Money Request Amount (#77557)
Account Button (#75469)
Search Menu Button (#77464)
Referral CTA (#77457)
Selection List Items (#77450)
delegate)
Workspace Members (#77453)
Language Selection (#74887)
Offline tests
N/A - These are accessibility attribute changes that don't affect offline behavior.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-01-21.at.06.22.00.mov