Revert "Merge pull request #78350 from abzokhattab/workflow-approval-…#79169
Closed
arosiclair wants to merge 1 commit intomainfrom
Closed
Revert "Merge pull request #78350 from abzokhattab/workflow-approval-…#79169arosiclair wants to merge 1 commit intomainfrom
arosiclair wants to merge 1 commit intomainfrom
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 739b348b..02665dd2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2266,7 +2266,7 @@ ${amount} für ${merchant} – ${date}`,
},
workflowsApproverPage: {
genericErrorMessage: 'Der Genehmiger konnte nicht geändert werden. Bitte versuche es erneut oder kontaktiere den Support.',
- header: 'Zur Genehmigung an dieses Mitglied senden:',
+ header: 'Zur Freigabe an dieses Mitglied senden:',
},
workflowsPayerPage: {
title: 'Autorisierter Zahler',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b89290d4..2770eb93 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2267,10 +2267,7 @@ ${amount} pour ${merchant} - ${date}`,
title: 'Dépenses de',
header: 'Lorsque les membres suivants soumettent des dépenses :',
},
- workflowsApproverPage: {
- genericErrorMessage: 'Le valideur n’a pas pu être modifié. Veuillez réessayer ou contacter l’assistance.',
- header: 'Envoyer à ce membre pour approbation :',
- },
+ workflowsApproverPage: {genericErrorMessage: 'Le valideur n’a pas pu être modifié. Veuillez réessayer ou contacter l’assistance.', header: 'Envoyer à ce membre pour approbation :'},
workflowsPayerPage: {
title: 'Payeur autorisé',
genericErrorMessage: 'Le payeur autorisé n’a pas pu être modifié. Veuillez réessayer.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 5c77ca65..b233411d 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2257,10 +2257,7 @@ ${amount} per ${merchant} - ${date}`,
title: 'Spese da',
header: 'Quando i seguenti membri inviano note spese:',
},
- workflowsApproverPage: {
- genericErrorMessage: "Non è stato possibile modificare l'approvatore. Riprova o contatta l'assistenza.",
- header: 'Invia a questo membro per approvazione:',
- },
+ workflowsApproverPage: {genericErrorMessage: "Non è stato possibile modificare l'approvatore. Riprova o contatta l'assistenza.", header: "Invia a questo membro per l'approvazione:"},
workflowsPayerPage: {
title: 'Pagatore autorizzato',
genericErrorMessage: 'Non è stato possibile modificare il pagatore autorizzato. Riprova.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 0bb3d839..ef528820 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2250,10 +2250,7 @@ ${merchant} への ${amount}（${date}）`,
title: '経費（発生日）',
header: '次のメンバーが経費を提出したとき:',
},
- workflowsApproverPage: {
- genericErrorMessage: '承認者を変更できませんでした。もう一度お試しいただくか、サポートにお問い合わせください。',
- header: 'このメンバーに承認用として送信:',
- },
+ workflowsApproverPage: {genericErrorMessage: '承認者を変更できませんでした。もう一度お試しいただくか、サポートにお問い合わせください。', header: 'このメンバーに承認用として送信'},
workflowsPayerPage: {
title: '認可された支払担当者',
genericErrorMessage: '支払権限者を変更できませんでした。もう一度お試しください。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index f5e07eba..8c6f96ab 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2257,7 +2257,7 @@ ${amount} voor ${merchant} - ${date}`,
},
workflowsApproverPage: {
genericErrorMessage: 'De fiatteur kon niet worden gewijzigd. Probeer het opnieuw of neem contact op met support.',
- header: 'Naar dit lid sturen ter goedkeuring:',
+ header: 'Versturen naar dit lid ter goedkeuring:',
},
workflowsPayerPage: {
title: 'Geautoriseerde betaler',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index fa97ce86..5f666445 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2250,10 +2250,7 @@ ${amount} para ${merchant} - ${date}`,
title: 'Despesas de',
header: 'Quando os seguintes membros enviarem despesas:',
},
- workflowsApproverPage: {
- genericErrorMessage: 'O aprovador não pôde ser alterado. Tente novamente ou entre em contato com o suporte.',
- header: 'Enviar para este membro para aprovação:',
- },
+ workflowsApproverPage: {genericErrorMessage: 'O aprovador não pôde ser alterado. Tente novamente ou entre em contato com o suporte.', header: 'Enviar para este membro para aprovação:'},
workflowsPayerPage: {
title: 'Pagador autorizado',
genericErrorMessage: 'O pagador autorizado não pôde ser alterado. Tente novamente.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 879599a7..809b721b 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2220,10 +2220,7 @@ ${amount}，商户：${merchant} - ${date}`,
title: '来自的报销',
header: '当以下成员提交报销时：',
},
- workflowsApproverPage: {
- genericErrorMessage: '无法更改审批人。请重试或联系支持。',
- header: '发送给该成员以供审批：',
- },
+ workflowsApproverPage: {genericErrorMessage: '无法更改审批人。请重试或联系支持。', header: '发送给此成员以供批准：'},
workflowsPayerPage: {
title: '授权付款人',
genericErrorMessage: '无法更改授权付款人。请重试。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
|
not sure if we need to revert ... most of the issues are not bugs ... or happens on prod the only actual bug till now is #79142 |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…limit-followup"
This reverts commit 984c986, reversing changes made to f903a08.
Explanation of Change
Reverts #78350
Fixed Issues
$ #79142
$ #79151
$ #79154
$ #79167