Update search total amount footer logic by ShridharGoel · Pull Request #79178 · Expensify/App

ShridharGoel · 2026-01-09T07:21:44Z

Explanation of Change

This would prevent showing the footer when user is on the expenses tab. But we will always show the footer if it is a saved search (even when the only query is type:expense but there are column changes and then the user saves it).

Fixed Issues

$ #78149
PROPOSAL: #78149 (comment)

Tests

Go to workspace chat.
Create an expense.
Go to Reports > Expenses.
→ Total spend footer is not shown on Reports > Expenses - Expected.
Click Columns.
Select any column and click Save.
Click Filters > Save search.
Click Expenses on LHN.
Total spend footer should not appear on Reports > Expenses.
Ensure that the footer shows for all suggested searches and saved searches.
Go to Reports > Expenses
Select a few expenses.
Ensure that the footer shows when there are selections.
Unselect all.
Footer should not show after unselection.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Untitled.7.mov

Android: mWeb Chrome

Screen.Recording.2026-01-09.at.12.49.54.PM.mov

iOS: Native

Screen.Recording.2026-01-09.at.12.49.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-01-09.at.12.50.44.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-09.at.12.39.58.PM.mov

melvin-bot · 2026-01-09T07:21:51Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-09T07:30:52Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSearchShouldCalculateTotals.ts	`100.00% <100.00%> (+41.66%)`	⬆️
src/pages/Search/SearchPageNarrow.tsx	`82.35% <ø> (-0.51%)`	⬇️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SearchPage.tsx	`23.26% <83.33%> (-0.87%)`	⬇️
src/components/Search/index.tsx	`27.10% <42.85%> (+0.24%)`	⬆️
... and 7 files with indirect coverage changes

brunovjk · 2026-01-09T14:25:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

79178_android_native.mov

Android: mWeb Chrome

79178_android_web.mov

iOS: HybridApp

79178_ios_native.mov

iOS: mWeb Safari

79178_ios_web.mov

MacOS: Chrome / Safari

79178_web_chrome.mov

src/pages/Search/SearchPage.tsx

src/pages/Search/SearchPageNarrow.tsx

JS00001 · 2026-01-09T19:35:58Z

src/libs/SearchUIUtils.ts

+    selectedTransactionsCount: number;
+};
+
+function shouldShowSearchPageFooter({isSavedSearch, resultsCount, isDefaultExpensesSearch, selectedTransactionsCount}: ShouldShowSearchPageFooterParams) {


I dont think this !isDefaultExpensesSearch is correct 🤔 We dont want to show the footer on any of the normal views. Expenses, reports, chats

resultsCount is !!metadata?.count which will be not be present for reports and chats, so that's why only !isDefaultExpensesSearch was needed. What do you think?

But wont resultsCount not be present for expenses either? On the default expense search, we shouldnt be querying metadata. (shouldCalculateTotals: true)

If we take a step back, I think we're fixing the wrong thing here. This is only updating the UI to not show the footer bar. But the problem is that, we should not be querying the footer totals from the BE at all when we are not on a suggested search or saved search. I think that we should be updating the logic for when shouldCalculateTotals: true is sent

JS00001

coming from my other comment:

If we take a step back, I think we're fixing the wrong thing here. This is only updating the UI to not show the footer bar. But the problem is that, we should not be querying the footer totals from the BE at all when we are not on a suggested search or saved search. I think that we should be updating the logic for when shouldCalculateTotals: true is sent

JS00001 · 2026-01-13T12:38:47Z

@ShridharGoel let us know when this is ready again!

ShridharGoel · 2026-01-13T13:15:37Z

@JS00001 It's ready now

JS00001

Nice, I think this is better aligned w/ what we want to do

@brunovjk could you please re-review?

brunovjk · 2026-01-13T18:44:36Z

After saving a "search with a selected column," the total takes a while to update, sometimes after a delay and sometimes only if I go to another tab and return to the "saved search."

Screen.Recording.2026-01-13.at.15.39.01.mov

@ShridharGoel and @JS00001 I don't believe that's expected, right? Thank you.

JS00001 · 2026-01-14T12:03:07Z

@brunovjk No, it should show a loading skeleton if loading for the first time. If its already been loaded/cached then the result should be instantly

ShridharGoel · 2026-01-14T19:22:10Z

Trying to find a solution for the extra time it takes the footer to update. Likely this happens because the Onyx saved search entry is added asynchronously (and often only after the API response), so for a short window shouldCalculateTotals stays false and when it becomes true then only the total gets calculated.

ShridharGoel · 2026-01-19T08:49:11Z

@brunovjk Updated

src/pages/Search/SearchPage.tsx

brunovjk · 2026-01-19T12:31:20Z

Thanks for the hard work @ShridharGoel, but we have another bug:

When saving the "search," the footer doesn't appear (sometimes it appears and then disappears) until we click on another tab and return to the saved search.

Screen.Recording.2026-01-19.at.09.29.57.mov

Can you reproduce this as well? Thank you.

ShridharGoel · 2026-01-26T22:33:45Z

Tried finding a better solution few days back but couldn't do it without an extra API call. Will try to get back to this one tomorrow.

JS00001 · 2026-02-09T13:02:09Z

@brunovjk this is ready for you again!

brunovjk

Looking good

79178_web_chrome.mov

github-actions · 2026-02-10T15:54:53Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-10T15:58:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79178.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d2e5e9f-27c4bed4e1bad1547533f64eeead688916046d3b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d2e5e9f-d61873b20eca4b461028c5927fe580bab8fc178b/index.html

Web 🕸️
https://79178.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-10T16:02:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-11T06:52:39Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-12T15:22:17Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Update search total amount footer logic

333ac3e

ShridharGoel requested review from a team as code owners January 9, 2026 07:21

melvin-bot bot assigned ShridharGoel Jan 9, 2026

melvin-bot bot requested review from brunovjk and heyjennahay and removed request for a team January 9, 2026 07:21

melvin-bot bot removed the request for review from a team January 9, 2026 07:21

brunovjk approved these changes Jan 9, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 January 9, 2026 14:25

JS00001 requested changes Jan 9, 2026

View reviewed changes

Update isSavedSearch

e38609a

JS00001 requested changes Jan 12, 2026

View reviewed changes

ShridharGoel added 4 commits January 13, 2026 02:19

Use better logic

9b313a5

Update tests

6e6a87e

Fix lint

872ba8a

Update

f4c1a3d

JS00001 previously approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into issue78149

055960c

ShridharGoel added 2 commits January 19, 2026 00:08

Make branch match upstream/main

d67aee2

Update search total amount footer logic

ef6cffe

ShridharGoel dismissed JS00001’s stale review via ef6cffe January 18, 2026 18:40

ShridharGoel added 4 commits January 19, 2026 00:44

Update search total amount footer logic

8e1285b

Merge main

2fc2450

Updates

51c39b8

Add tests

e875cde

ShridharGoel marked this pull request as ready for review January 19, 2026 08:48

Fix prettier

22a1208

github-actions bot reviewed Jan 19, 2026

View reviewed changes

src/pages/Search/SearchPage.tsx Show resolved Hide resolved

Lint fixes

0156030

stephanieelliott removed their request for review January 21, 2026 00:40

ShridharGoel mentioned this pull request Jan 26, 2026

feat: [Insights] [Release 1] Top Categories - Add a limit filter to search #80262

Merged

54 tasks

ShridharGoel added 2 commits February 8, 2026 03:43

Merge main

d5bc8c0

Ensure totals are fetched when needed

15809e6

ShridharGoel requested a review from brunovjk February 8, 2026 05:02

brunovjk approved these changes Feb 10, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 February 10, 2026 14:54

JS00001 approved these changes Feb 10, 2026

View reviewed changes

JS00001 merged commit d2e5e9f into Expensify:main Feb 10, 2026
30 checks passed

OSBotify mentioned this pull request Feb 11, 2026

Deploy Checklist: New Expensify 2026-02-11 #82079

Closed

lakchote mentioned this pull request Feb 11, 2026

Reports - Filters are still applied after being cleared and returning to the same section. #82101

Closed

7 tasks

melvin-bot bot mentioned this pull request Feb 12, 2026

[Due for payment 2026-02-19] [$250] Expenses - Total spend footer appears on Reports > Expenses after saving search with custom columns #78149

Closed

7 tasks

mhawryluk mentioned this pull request Feb 16, 2026

[Due for payment 2026-02-26] Reports - Deleted expense is still visible on chart on "Bar" view mode. #81110

Closed

7 tasks

Conversation

ShridharGoel commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

codecov bot commented Jan 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brunovjk commented Jan 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JS00001 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Jan 13, 2026

Uh oh!

ShridharGoel commented Jan 13, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Jan 13, 2026

Uh oh!

JS00001 commented Jan 14, 2026

Uh oh!

ShridharGoel commented Jan 14, 2026

Uh oh!

ShridharGoel commented Jan 19, 2026

Uh oh!

Uh oh!

brunovjk commented Jan 19, 2026

Uh oh!

ShridharGoel commented Jan 26, 2026

Uh oh!

JS00001 commented Feb 9, 2026

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShridharGoel commented Jan 9, 2026 •

edited

Loading

codecov bot commented Jan 9, 2026 •

edited by github-actions bot

Loading