Prevent Excel tag files from being uploaded (PR by ijmalik) by SIMalik · Pull Request #79186 · Expensify/App

SIMalik · 2026-01-09T09:42:14Z

Explanation of Change

This change prevents Excel-based files (.xls and .xlsx) from being uploaded during tag imports.
Previously, the client allowed these files to be selected and submitted, resulting in an error after upload.

The update prevents users from submitting unsupported Excel files.

Fixed Issues

$ #78415
PROPOSAL: #78415 (comment)

Tests

Create a policy.
Enable Tag import.
Go to Tags > Import > Multi-level tags
Select an XLSX file
Notice how the client will not let you upload XLS/XLSX files

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

issue.78415.android.app.mp4

Android: mWeb Chrome

issue.78415.android.mweb.mp4

iOS: Native

issue.78415.ios.app.mp4

iOS: mWeb Safari

issue.78415.ios.safari.mp4

MacOS: Chrome / Safari

issue.78415.mac.web.mp4

melvin-bot · 2026-01-09T09:42:21Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-09T09:51:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ImportSpreadsheet.tsx	`0.00% <0.00%> (ø)`
... and 99 files with indirect coverage changes

SIMalik · 2026-01-09T14:42:26Z

Hi @Pujan92,

Kindly review this PR when you have a moment.

Thank you.
IJMALIK

CC: @yuwenmemon

src/components/ImportSpreadsheet.tsx

Pujan92 · 2026-01-09T18:04:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92 · 2026-01-10T11:35:45Z

src/components/ImportSpreadsheet.tsx

+            if (!CONST.MULTILEVEL_TAG_ALLOWED_SPREADSHEET_EXTENSIONS.includes(lowerExt as TupleToUnion<typeof CONST.MULTILEVEL_TAG_ALLOWED_SPREADSHEET_EXTENSIONS>)) {
+                setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');
+                return false;
+            }
+        } else if (!allowedExtensions.includes(fileExtension.toLowerCase())) {
            setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');
            return false;
        }


Suggested change

if (!CONST.MULTILEVEL_TAG_ALLOWED_SPREADSHEET_EXTENSIONS.includes(lowerExt as TupleToUnion<typeof CONST.MULTILEVEL_TAG_ALLOWED_SPREADSHEET_EXTENSIONS>)) {

setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');

return false;

}

} else if (!allowedExtensions.includes(fileExtension.toLowerCase())) {

setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');

return false;

}

if (!allowedExtensions.includes(fileExtension.toLowerCase())) {

setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');

return false;

}

We don't require 2 conditions now as we are conditionally assigning the data to allowedExtensions.

Pujan92

LGTM!

Screen.Recording.2026-01-10.at.22.34.00.mov

OSBotify · 2026-01-12T18:09:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-13T03:40:31Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

SIMalik · 2026-01-13T09:02:03Z

I’ve tested the changes on staging, it is working as expected.
@Pujan92 @yuwenmemon

issue.78415.staging.working.mp4

OSBotify · 2026-01-14T02:56:48Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

SIMalik · 2026-01-14T06:20:32Z

I’ve tested the changes on production, it is working as expected.
@Pujan92 @yuwenmemon

issue.78415.production.working.mp4

Prevent Excel tag files from being uploaded

174e18d

SIMalik requested review from a team as code owners January 9, 2026 09:42

melvin-bot bot assigned SIMalik Jan 9, 2026

melvin-bot bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify January 9, 2026 09:42

melvin-bot bot removed the request for review from a team January 9, 2026 09:42

SIMalik added 6 commits January 9, 2026 15:29

Resolve ESLint no-lonely-if in ImportSpreadsheet

c92aade

Resolve formatting diff

4e71a4a

Resolve formatting diff

3940cf2

Resolve formatting diff

ad29d33

Resolve formatting diff

feba3b3

Resolve formatting diff and ESLint Check issue

82bc90f

Pujan92 reviewed Jan 9, 2026

View reviewed changes

src/components/ImportSpreadsheet.tsx Outdated Show resolved Hide resolved

Simplify code - file extension validation

ee6280a

chore: re-run CI

79ca138

SIMalik requested a review from Pujan92 January 10, 2026 07:15

Pujan92 reviewed Jan 10, 2026

View reviewed changes

SIMalik added 3 commits January 10, 2026 21:39

Remove redundant condition by using allowedExtensions

fe42c25

Remove redundant condition by using allowedExtensions

27a5369

Removed unused const lowerExt

5c45531

Pujan92 approved these changes Jan 10, 2026

View reviewed changes

melvin-bot bot requested a review from yuwenmemon January 10, 2026 17:05

yuwenmemon approved these changes Jan 12, 2026

View reviewed changes

yuwenmemon merged commit 5a4d2be into Expensify:main Jan 12, 2026
31 checks passed

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

OSBotify mentioned this pull request Jan 29, 2026

Tags - Import multi-level tags to workspace is failed #80844

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent Excel tag files from being uploaded (PR by ijmalik)#79186

Prevent Excel tag files from being uploaded (PR by ijmalik)#79186
yuwenmemon merged 12 commits intoExpensify:mainfrom
SIMalik:78415

SIMalik commented Jan 9, 2026

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

codecov bot commented Jan 9, 2026 •

edited by github-actions bot

Loading

Uh oh!

SIMalik commented Jan 9, 2026

Uh oh!

Uh oh!

Pujan92 commented Jan 9, 2026 •

edited

Loading

Uh oh!

Pujan92 Jan 10, 2026

Uh oh!

Pujan92 left a comment

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

SIMalik commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

SIMalik commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

SIMalik commented Jan 9, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

codecov bot commented Jan 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SIMalik commented Jan 9, 2026

Uh oh!

Uh oh!

Pujan92 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

SIMalik commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

SIMalik commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 9, 2026 •

edited by github-actions bot

Loading

Pujan92 commented Jan 9, 2026 •

edited

Loading