[CP Staging & Prod] Fix ReferenceError in getCurrentPosition() - web API reference on mobile by GCyganek · Pull Request #79222 · Expensify/App

GCyganek · 2026-01-09T17:26:43Z

Explanation of Change

Fixes ReferenceError caused by checking if caught error is instance of GeolocationPositionError which is a web API can't shouldn't be referenced on mobile.

This was brought up on Slack with this sentry link: https://expensify.sentry.io/issues/7112671849/?environment=production&project=4510228107427840&query=is%3Aunresolved%20user.email%3A%EF%80%8DContains%EF%80%8Dflorent%40expensify.com

Fixed Issues

$ #79230
PROPOSAL: N/A

Tests

It's not easy to trigger an error when the getCurrentPosition() is called without code changes.

For mobile, change the code to throw a random error like this:

    try {
        throw new Error("error");
        const currentPosition = await getCurrentPositionAsync(options);
        success(currentPosition);
    } catch (caughtError) {

Go to the Map distance expense screen and (FAB > Track distance) try to load your current location for the Start/Stop endpoint. Verify that there is no spinner spinning forever and that there is an error displayed to the user.

Web:

Comment out these first lines of getCurrentPosition() function:

   const foregroundPermissionResponse: PermissionResponse = await requestForegroundPermissionsAsync();

    if (foregroundPermissionResponse.status !== PermissionStatus.GRANTED) {
        error({code: GeolocationErrorCode.PERMISSION_DENIED, message: 'User denied access to location.'});
        return;
    }

Disable location access and go to the Map distance expense screen and (FAB > Track distance) try to load your current location for the Start/Stop endpoint. Verify that there is no spinner spinning forever and that there is an error displayed to the user.

Can be also tested using Scan receipt flow with a receipt that has erased currency:

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

make sure this works on mobile:

FAB > Scan receipt
Use this receipt which has erased currency:

Make sure the expense is created and the currency is set based on your location

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-09.at.18.38.49.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-09.at.18.37.55.mov

codecov · 2026-01-09T17:36:06Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/getCurrentPosition/index.ts	`5.55% <0.00%> (ø)`
... and 19 files with indirect coverage changes

melvin-bot · 2026-01-09T17:40:12Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-09T18:33:44Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

situchan · 2026-01-09T18:45:04Z

src/libs/getCurrentPosition/index.ts

        let code = GeolocationErrorCode.POSITION_UNAVAILABLE;

-        if (caughtError instanceof GeolocationPositionError) {
+        if (Platform.OS === 'web' && caughtError instanceof GeolocationPositionError) {


As the file is small, can we separate this into index.ts, index.native.ts?

Yes we just chatted about it but in sake of fixing this asap we allow it for this PR

mountiny

discussed in here, I would allow the Platform code as we should fix it asap and clear it up in a separate PR later that does not have to be CPed

situchan · 2026-01-09T18:50:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android1.mov

android2.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-09T18:57:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79222.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b29b61105f494d7b271455f7b1d18ea41edcd1bf/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2cfc1299e808060fba95065d501562a0f5dfd26b/index.html

Web 🕸️
https://79222.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…tCurrentPosition-web-api-reference-on-mobile [CP Staging & Prod] Fix ReferenceError in getCurrentPosition() - web API reference on mobile (cherry picked from commit b97ba94) (cherry-picked to staging by AndrewGable)

OSBotify · 2026-01-09T20:52:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-09T21:31:59Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.97-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…tCurrentPosition-web-api-reference-on-mobile [CP Staging & Prod] Fix ReferenceError in getCurrentPosition() - web API reference on mobile (cherry picked from commit b97ba94) (cherry-picked to production by AndrewGable)

OSBotify · 2026-01-10T01:40:10Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.98-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:22:45Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:13:44Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:40:38Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:56:54Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix ReferenceError in getCurrentPosition() - web API reference on mobile

d464ff7

melvin-bot bot assigned GCyganek Jan 9, 2026

GCyganek changed the title ~~Fix ReferenceError in getCurrentPosition() - web API reference on mobile~~ [No QA] Fix ReferenceError in getCurrentPosition() - web API reference on mobile Jan 9, 2026

GCyganek marked this pull request as ready for review January 9, 2026 17:39

GCyganek requested review from a team as code owners January 9, 2026 17:39

melvin-bot bot requested review from grgia and heyjennahay and removed request for a team January 9, 2026 17:39

melvin-bot bot removed the request for review from a team January 9, 2026 17:40

situchan reviewed Jan 9, 2026

View reviewed changes

GCyganek changed the title ~~[No QA] Fix ReferenceError in getCurrentPosition() - web API reference on mobile~~ Fix ReferenceError in getCurrentPosition() - web API reference on mobile Jan 9, 2026

mountiny changed the title ~~Fix ReferenceError in getCurrentPosition() - web API reference on mobile~~ [CP Staging & Prod] Fix ReferenceError in getCurrentPosition() - web API reference on mobile Jan 9, 2026

mountiny approved these changes Jan 9, 2026

View reviewed changes

situchan approved these changes Jan 9, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair January 9, 2026 19:24

arosiclair approved these changes Jan 9, 2026

View reviewed changes

arosiclair requested a review from AndrewGable January 9, 2026 20:31

AndrewGable approved these changes Jan 9, 2026

View reviewed changes

AndrewGable merged commit b97ba94 into Expensify:main Jan 9, 2026
43 of 46 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 9, 2026

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Closed

77 tasks

OSBotify added the CP Production label Jan 10, 2026

melvin-bot bot mentioned this pull request Jan 10, 2026

[$250] [Due for payment 2026-01-21] [Due for payment 2026-01-17] Android - User is unable to create receipt expense on Android after rejeceting location access #79230

Closed

7 tasks

GCyganek mentioned this pull request Jan 12, 2026

Replace Platform.OS with platform-specific files for getCurrentPosition() #79333

Merged

54 tasks

situchan mentioned this pull request Jan 21, 2026

Replace @react-native-community/geolocation with expo-location #73757

Merged

54 tasks

Conversation

GCyganek commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

situchan Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GCyganek commented Jan 9, 2026 •

edited

Loading

codecov bot commented Jan 9, 2026 •

edited by github-actions bot

Loading

situchan commented Jan 9, 2026 •

edited

Loading