Add travel option to workspace duplication#79311
Merged
madmax330 merged 5 commits intoExpensify:mainfrom Jan 12, 2026
Merged
Conversation
- Add travel copy option in WorkspaceDuplicateSelectFeaturesForm when policy.isTravelEnabled is true - Pass travel in parts object to API when duplicating workspace - Add optimistic update for isTravelEnabled in buildDuplicatePolicyData to copy travel enable/disable state
melvin-bot
bot
requested review from
cristipaval and
joekaufmanexpensify
and removed request for
a team
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70106f3dd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -2727,9 +2728,10 @@ function buildDuplicatePolicyData(policy: Policy, options: DuplicatePolicyDataOp | |||
| areReportFieldsEnabled: isReportsOptionSelected, | |||
| areConnectionsEnabled: isConnectionsOptionSelected, | |||
| arePerDiemRatesEnabled: isPerDiemOptionSelected, | |||
| isTravelEnabled: isTravelOptionSelected ? policy?.isTravelEnabled : undefined, | |||
There was a problem hiding this comment.
When duplicating a workspace that already has travel configured, deselecting Travel only flips isTravelEnabled but the new policy is still seeded from ...policy, so travelSettings (e.g., accepted terms / Spotnana IDs) gets copied into the duplicate. Since getTravelStep uses policy.travelSettings.hasAcceptedTerms without checking isTravelEnabled, a user who opted out of copying Travel can still see the duplicated workspace treated as provisioned (e.g., “Book or manage your trip”) if they navigate to the travel page. Consider explicitly clearing travelSettings when parts.travel is false.
Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment.
we dont want to copy travelSettings
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
ishpaul777
requested review from
madmax330
and removed request for
cristipaval
Contributor
|
tests are failing |
Contributor
|
If this requires C+ review and testing, I can help |
Contributor
Author
|
eslint failing on other PR also, |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
madmax330
approved these changes
Jan 12, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
91 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.0-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #78202
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-12.at.12.00.46.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-01-12.at.12.02.24.AM.mov
iOS: Native
Screen.Recording.2026-01-11.at.11.57.41.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-01-11.at.11.53.09.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-11.at.11.29.46.PM.mov