Skip to content

[Release 1] [Domain control] Fix SetTechnicalContactEmail command #79355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Jan 12, 2026
Merged

[Release 1] [Domain control] Fix SetTechnicalContactEmail command #79355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
388da91
fix: update SetTechnicalCOntactEmail params
war-in Jan 12, 2026
e3ca088
fix: remove unnecessary authToken param
war-in Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libs/API/parameters/SetTechnicalContactEmailParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
type SetTechnicalContactEmailParams = {
authToken?: string | null;
domainAccountID: number;
technicalContactAccountID: number;
technicalContactEmail: string;
};

export default SetTechnicalContactEmailParams;
1 change: 0 additions & 1 deletion src/libs/API/parameters/ToggleConsolidatedDomainBillingParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
type ToggleConsolidatedDomainBillingParams = {
authToken?: string | null;
domainAccountID: number;
domainName: string;
enabled: boolean;
Expand Down
8 changes: 2 additions & 6 deletions src/libs/actions/Domain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ function resetCreateDomainForm() {
Onyx.merge(ONYXKEYS.FORMS.CREATE_DOMAIN_FORM, null);
}

function setPrimaryContact(domainAccountID: number, newTechnicalContactAccountID: number, newTechnicalContactEmail: string, currentTechnicalContactEmail?: string) {
function setPrimaryContact(domainAccountID: number, newTechnicalContactEmail: string, currentTechnicalContactEmail?: string) {
const optimisticData: Array<
OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER | typeof ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS | typeof ONYXKEYS.COLLECTION.DOMAIN_ERRORS>
> = [
Expand Down Expand Up @@ -426,11 +426,9 @@ function setPrimaryContact(domainAccountID: number, newTechnicalContactAccountID
},
];

const authToken = getAuthToken();
const params: SetTechnicalContactEmailParams = {
authToken,
domainAccountID,
technicalContactAccountID: newTechnicalContactAccountID,
technicalContactEmail: newTechnicalContactEmail,
};

API.write(WRITE_COMMANDS.SET_TECHNICAL_CONTACT_EMAIL, params, {optimisticData, successData, failureData});
Expand Down Expand Up @@ -510,9 +508,7 @@ function toggleConsolidatedDomainBilling(domainAccountID: number, domainName: st
},
];

const authToken = getAuthToken();
const params: ToggleConsolidatedDomainBillingParams = {
authToken,
domainAccountID,
domainName,
enabled: useTechnicalContactBillingCard,
Expand Down
2 changes: 1 addition & 1 deletion src/pages/domain/Admins/DomainAddPrimaryContactPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function DomainAddPrimaryContactPage({route}: DomainAddPrimaryContactPageProps)
return;
}
if (option.login !== technicalContactSettings?.technicalContactEmail) {
setPrimaryContact(domainAccountID, option.accountID, option.login, technicalContactSettings?.technicalContactEmail);
setPrimaryContact(domainAccountID, option.login, technicalContactSettings?.technicalContactEmail);
}
Navigation.goBack(ROUTES.DOMAIN_ADMINS_SETTINGS.getRoute(domainAccountID));
}}
Expand Down
Loading