[No QA][Sentry] Filter out skeleton transactions based on desired duration#79357
Merged
rlinoz merged 6 commits intoExpensify:mainfrom Jan 13, 2026
Merged
[No QA][Sentry] Filter out skeleton transactions based on desired duration#79357rlinoz merged 6 commits intoExpensify:mainfrom
rlinoz merged 6 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
bot
requested review from
ShridharGoel and
trjExpensify
and removed request for
a team
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
adhorodyski
reviewed
Jan 12, 2026
| const minDurationFilter: TelemetryBeforeSend = (event) => { | ||
| // Check if the transaction (event) itself has a min_duration requirement | ||
| const eventMinDuration = event.contexts?.trace?.data?.[CONST.TELEMETRY.ATTRIBUTE_MIN_DURATION] as number; | ||
| if (eventMinDuration && !Number.isNaN(eventMinDuration)) { |
Contributor
There was a problem hiding this comment.
can you untangle these if statements so we're not nesting them within each other? You can invert the boolean value checks and early return.
Contributor
Author
There was a problem hiding this comment.
this is not inline function so there is no place for early return but I've reduced amount of deep ifs. This should be more readable now
adhorodyski
reviewed
Jan 12, 2026
| const eventMinDuration = event.contexts?.trace?.data?.[CONST.TELEMETRY.ATTRIBUTE_MIN_DURATION] as number; | ||
| if (eventMinDuration && !Number.isNaN(eventMinDuration)) { | ||
| if (event.timestamp && event.start_timestamp) { | ||
| const eventDuration = (event.timestamp - event.start_timestamp) * 1000; |
Contributor
There was a problem hiding this comment.
1000 should be even a file-scoped constant
Contributor
Author
There was a problem hiding this comment.
instead of creating a constant I moved this calculation to separate function so there is no repetiton
| const eventMinDuration = event.contexts?.trace?.data?.[CONST.TELEMETRY.ATTRIBUTE_MIN_DURATION] as number | undefined; | ||
|
|
||
| if (isValidMinDuration(eventMinDuration)) { | ||
| const eventDuration = calculateDuration(event.start_timestamp ?? 0, event.timestamp ?? 0); |
Contributor
There was a problem hiding this comment.
You can do something like this instead of ?? 0:
if (!event.start_timestamp || !event.timestamp) {
// Can't calculate duration, so don't filter
return event;
}
Contributor
Author
There was a problem hiding this comment.
I ran some tests and I think we're safe to do so
| return true; | ||
| } | ||
|
|
||
| if (!span.timestamp) { |
Contributor
There was a problem hiding this comment.
Do you think this can be changed to !span.start_timestamp || !span.timestamp ?
Contributor
Author
There was a problem hiding this comment.
I can, but start_timestamp is typed strictly to number in contrary to timestamp which can be undefined. Should I update this?
rlinoz
reviewed
Jan 12, 2026
| import type {TelemetryBeforeSend} from './index'; | ||
|
|
||
| function isValidMinDuration(value: unknown): value is number { | ||
| return typeof value === 'number' && !Number.isNaN(value); |
Contributor
There was a problem hiding this comment.
I have been wondering whether it is possible that the type of what we are setting is being changed somewhere, so value would be of type string or something...
I haven't find any evidence of that, but do you think we should check if it is string and try to parse it to number too? Or at least log it so we can update later.
Contributor
Author
There was a problem hiding this comment.
I've added a logic of parsing string, so I've changed isValidMinDuration to getValidMinDuration which handles both checking and parsing
Contributor
Author
|
@adhorodyski @rlinoz @ShridharGoel I've responded to all your comments |
Contributor
|
PR doesn’t need product input as a tooling PR. Unassigning and unsubscribing myself. |
ShridharGoel
approved these changes
Jan 13, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
ShridharGoel
approved these changes
Jan 13, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
39 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.1-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR filters out transactions of
skeletonobjects based on the minDuration. Previous implementation focused only on child spans but there are cases where we have to treat transaction as a span.Fixed Issues
$ #74138
PROPOSAL:
Tests
To test this out I've disabled debugTransport in setup/telemetry/index.ts so all events are sent to Sentry. This can be skipped when testing on adhoc.
src/telemetry/middlewares/minDurationFilterto confirm that there is anytransactionwith nameManualSkeleton. This is crucial to test this out as sometimes spans are attached to other transactionsManualSkeletonOffline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
ios.mov
MacOS: Chrome / Safari
dev.mov