[Release 2] [Domain control] Add `DomainMemberDetialsPage` RHP by war-in · Pull Request #79358 · Expensify/App

war-in · 2026-01-12T15:14:10Z

Explanation of Change

This PR adds the member details RHP and unifies it with DomainAdminDetailsPage

(initial PR)

Fixed Issues

$ #78124
PROPOSAL:

Tests

Open /domain/<domainAccountID>/members
Click on any row
Verify that RHP with member details opens and contains name, email and Profile
Click on Profile and verify it opens another RHP with account detials
Open /domain/<domainAccountID>/admins
Click on any row
Verify that RHP with admin details opens and contains name, email, Revoke admin access and Profile

Offline tests

QA Steps

Open /domain/<domainAccountID>/members
Click on any row
Verify that RHP with member details opens and contains name, email and Profile
Click on Profile and verify it opens another RHP with account detials
Open /domain/<domainAccountID>/admins
Click on any row
Verify that RHP with admin details opens and contains name, email, Revoke admin access and Profile

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-12.at.16.13.24.mov

…page' into feature/kuba-nowakowski/add_domain_members_details_page # Conflicts: # src/languages/en.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/types.ts # src/pages/domain/Members/DomainMembersPage.tsx

…feature/kuba-nowakowski/add_domain_members_details_page

…feature/kuba-nowakowski/add_domain_members_details_page # Conflicts: # src/pages/domain/Members/DomainMembersPage.tsx

…page' into feature/kuba-nowakowski/add_domain_members_details_page

…page' into feature/kuba-nowakowski/add_domain_members_details_page # Conflicts: # src/pages/domain/Admins/DomainAdminDetailsPage.tsx

…n_members_details_page

melvin-bot · 2026-01-12T15:14:28Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-12T15:18:11Z

Code Review Summary

I've reviewed PR #79358 and identified several issues:

Critical Issues

1. Inconsistent import formatting in DomainAdminDetailsPage.tsx
Import statements have inconsistent spacing. Some use space after curly braces, others don't.

2. Unused imports in DomainAdminDetailsPage.tsx
After refactoring, many imports are no longer needed: Str, View, Avatar, HeaderWithBackButton, MenuItemWithTopDescription, OfflineWithFeedback, ScreenWrapper, ScrollView, Text, getPhoneNumber, DomainNotFoundPageWrapper, CONST, ROUTES

3. MembersDetailsPage.tsx - Incorrect prop usage
Line 18 passes menuItems prop but BaseDomainMemberDetailsComponent expects children, not menuItems. Also imports unused MemberDetailsMenuItem type.

4. BaseDomainMemberDetailsComponent.tsx - Unused type export
MemberDetailsMenuItem type is exported but not used anywhere.

Recommendations

Clean up unused imports
Fix prop mismatch - pass children correctly
Remove unused type export
Ensure consistent import formatting

github-actions · 2026-01-12T15:18:44Z

Additional Code Quality Findings

DomainAdminDetailsPage.tsx

Line 1: Import formatting inconsistency - missing spaces in curly braces
Lines 2-29: Multiple unused imports after refactoring (Str, View, Avatar, HeaderWithBackButton, MenuItemWithTopDescription, OfflineWithFeedback, ScreenWrapper, ScrollView, Text, getPhoneNumber, DomainNotFoundPageWrapper, CONST, ROUTES)

MembersDetailsPage.tsx

Line 4: Unused import - MemberDetailsMenuItem type is imported but never used
Line 7: Unused import - getEmptyArray is imported but should not be needed
Line 18: Bug - Passes menuItems prop but BaseDomainMemberDetailsComponent expects children prop

BaseDomainMemberDetailsComponent.tsx

Line 32: Unused type definition - MemberDetailsMenuItem is defined but not used in component
Line 121: Unnecessary export - MemberDetailsMenuItem is exported but not consumed anywhere

Suggested Fixes

Remove all unused imports from DomainAdminDetailsPage.tsx
In MembersDetailsPage.tsx, remove menuItems prop and unused imports
Pass null or empty fragment as children if no additional menu items needed
Remove or implement MemberDetailsMenuItem functionality
Standardize import formatting with spaces in curly braces

codecov · 2026-01-12T15:23:05Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
...avigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/ROUTES.ts	`12.24% <0.00%> (+0.07%)`	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`8.15% <0.00%> (-0.16%)`	⬇️
src/pages/domain/Members/DomainMembersPage.tsx	`0.00% <0.00%> (ø)`
...c/pages/domain/Members/DomainMemberDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/domain/Admins/DomainAdminDetailsPage.tsx	`0.00% <0.00%> (ø)`
.../pages/domain/BaseDomainMemberDetailsComponent.tsx	`0.00% <0.00%> (ø)`
... and 87 files with indirect coverage changes

src/pages/domain/Admins/DomainAdminDetailsPage.tsx

src/pages/domain/Members/MembersDetailsPage.tsx

src/pages/domain/BaseDomainMemberDetailsComponent.tsx

situchan · 2026-01-12T15:26:06Z

src/pages/domain/BaseDomainMemberDetailsComponent.tsx

+    const {translate, formatPhoneNumber} = useLocalize();
+    const icons = useMemoizedLazyExpensifyIcons(['Info'] as const);
+
+    // eslint-disable-next-line rulesdir/no-inline-useOnyx-selector


For all eslint disablings, there should be comment explaining why.
Can we move selector function to the top of the file?

no we can't, we need the accountID

I'll add the comment

I feel like we discussed this in the past and there was a way to achieve this somehow 🤔

cc @chrispader @TMisiukiewicz

war-in · 2026-01-12T15:34:16Z

@situchan review addressed!

situchan · 2026-01-12T16:10:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-01-13.at.6.57.17.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

situchan · 2026-01-12T16:10:13Z

There are still failing checks

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

…n_members_details_page

mountiny · 2026-01-12T19:58:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 951678c14e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/domain/BaseDomainMemberDetailsComponent.tsx

war-in · 2026-01-13T10:39:12Z

@situchan @mountiny PR ready for the final testing and review

JS00001

Looking good

situchan · 2026-01-13T12:48:35Z

Bug: member profile avatar briefly shows and disappears after opening profile page

Screen.Recording.2026-01-13.at.6.47.28.PM.mov

Edit: maybe not bug because members list is sorted alphabetically. The order changed because "Hidden" name is replaced with real one.

situchan · 2026-01-13T12:55:40Z

Not blocker but worth mentioning.

For primary contact, revoke is possible when "Hidden" but not possible after fetching profile.

Screen.Recording.2026-01-13.at.6.53.10.PM.mov

war-in · 2026-01-13T13:31:59Z

Bug: member profile avatar briefly shows and disappears after opening profile page

For primary contact, revoke is possible when "Hidden" but not possible after fetching profile.

I think those two will be resolved once the backend changes are deployed

heyjennahay · 2026-01-13T15:16:53Z

Just checking, is this spelling error (Detials instead of Details) in the title meant to be here or should it be corrected? And has it been incorrectly used anywhere else?

DomainMemberDetialsPage

situchan · 2026-01-13T15:20:44Z

Just checking, is this spelling error (Detials instead of Details) in the title meant to be here or should it be corrected? And has it been incorrectly used anywhere else?

DomainMemberDetialsPage

should be corrected 😄
It's just PR title, not code.

mountiny

Thanks, non blocking comments

mountiny · 2026-01-13T16:43:18Z

src/pages/domain/BaseDomainMemberDetailsComponent.tsx

+    const {translate, formatPhoneNumber} = useLocalize();
+    const icons = useMemoizedLazyExpensifyIcons(['Info'] as const);
+
+    // eslint-disable-next-line rulesdir/no-inline-useOnyx-selector


I feel like we discussed this in the past and there was a way to achieve this somehow 🤔

mountiny · 2026-01-13T16:43:27Z

src/pages/domain/BaseDomainMemberDetailsComponent.tsx

+    const {translate, formatPhoneNumber} = useLocalize();
+    const icons = useMemoizedLazyExpensifyIcons(['Info'] as const);
+
+    // eslint-disable-next-line rulesdir/no-inline-useOnyx-selector


cc @chrispader @TMisiukiewicz

OSBotify · 2026-01-13T16:55:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T03:24:29Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:32:37Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

sumo-slonik and others added 11 commits December 19, 2025 00:52

add members details page

eb9cc4c

refactor: remove outdated & unnecessary code

f41f400

Merge branch 'feature/kuba-nowakowski/add__domain_members_page' into …

59968bc

…feature/kuba-nowakowski/add_domain_members_details_page

chore: remove polish descriptions

3d6289a

Merge branch 'feature/kuba-nowakowski/add__domain_members_page' into …

f82b58e

…feature/kuba-nowakowski/add_domain_members_details_page # Conflicts: # src/pages/domain/Members/DomainMembersPage.tsx

refactor: apply review comments

f0eb892

Merge branch 'refs/heads/feature/kuba-nowakowski/add__domain_members_…

d8b5e1c

…page' into feature/kuba-nowakowski/add_domain_members_details_page

Merge branch 'refs/heads/feature/kuba-nowakowski/add__domain_members_…

168f0a1

…page' into feature/kuba-nowakowski/add_domain_members_details_page # Conflicts: # src/pages/domain/Admins/DomainAdminDetailsPage.tsx

fix: post-merge fixes

7a5cced

Merge branch 'refs/heads/main' into feature/kuba-nowakowski/add_domai…

2513796

…n_members_details_page

melvin-bot bot assigned war-in Jan 12, 2026

war-in marked this pull request as ready for review January 12, 2026 15:14

war-in requested review from a team as code owners January 12, 2026 15:14

melvin-bot bot requested a review from situchan January 12, 2026 15:14

melvin-bot bot requested review from heyjennahay and removed request for a team January 12, 2026 15:14

war-in moved this to Ready for Review in Bring Domain Control to NewDot Jan 12, 2026

war-in added this to Bring Domain Control to NewDot Jan 12, 2026

fix: prettier & eslint

ed0d8bb

situchan reviewed Jan 12, 2026

View reviewed changes

war-in added 2 commits January 12, 2026 16:28

fix: remove unused type

af4b7d1

chore: add comment

59dde9b

situchan reviewed Jan 12, 2026

View reviewed changes

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

war-in added 2 commits January 12, 2026 18:37

Merge branch 'refs/heads/main' into feature/kuba-nowakowski/add_domai…

87d46cc

…n_members_details_page

fix: eslint

951678c

mountiny self-requested a review January 12, 2026 19:58

chatgpt-codex-connector bot reviewed Jan 12, 2026

View reviewed changes

src/pages/domain/BaseDomainMemberDetailsComponent.tsx Outdated Show resolved Hide resolved

mountiny marked this pull request as draft January 12, 2026 20:49

mountiny marked this pull request as ready for review January 12, 2026 20:49

fix: correct layout wrapping

7dd21ae

war-in mentioned this pull request Jan 13, 2026

[HOLD] Add domain members details page software-mansion-labs/expensify-app-fork#277

Closed

53 tasks

This was referenced Jan 13, 2026

[Release 2] [Domain Control] Close domain member account #78002

Merged

[Release 3.3] [Domain Control] Report suspicious activity #78372

Merged

JS00001 approved these changes Jan 13, 2026

View reviewed changes

situchan approved these changes Jan 13, 2026

View reviewed changes

mountiny approved these changes Jan 13, 2026

View reviewed changes

mountiny merged commit 52cd36b into Expensify:main Jan 13, 2026
32 of 34 checks passed

github-project-automation bot moved this from Ready for Review to Done in Bring Domain Control to NewDot Jan 13, 2026

OSBotify mentioned this pull request Jan 14, 2026

Deploy Checklist: New Expensify 2026-01-14 #79522

Closed

39 tasks

melvin-bot bot mentioned this pull request Jan 14, 2026

[Due for payment 2026-01-21] [HOLD https://github.com/Expensify/Web-Expensify/pull/49926/files] [Release 2] [Domain Control] Domain member detail page #78124

Closed

Conversation

war-in commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Code Review Summary

Critical Issues

Recommendations

Uh oh!

github-actions bot commented Jan 12, 2026

Additional Code Quality Findings

DomainAdminDetailsPage.tsx

MembersDetailsPage.tsx

BaseDomainMemberDetailsComponent.tsx

Suggested Fixes

Uh oh!

codecov bot commented Jan 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

situchan Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

war-in Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

war-in Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

war-in commented Jan 12, 2026

Uh oh!

situchan commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Jan 12, 2026

Uh oh!

Uh oh!

mountiny commented Jan 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

war-in commented Jan 13, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

war-in commented Jan 13, 2026

Uh oh!

heyjennahay commented Jan 13, 2026

Uh oh!

situchan commented Jan 13, 2026

war-in commented Jan 12, 2026 •

edited

Loading

codecov bot commented Jan 12, 2026 •

edited by github-actions bot

Loading

situchan commented Jan 12, 2026 •

edited

Loading

situchan commented Jan 13, 2026 •

edited

Loading

situchan commented Jan 13, 2026 •

edited

Loading