fix: iOS import tag no loading status on the button by eh2077 · Pull Request #79363 · Expensify/App

eh2077 · 2026-01-12T15:43:22Z

Explanation of Change

Fixed Issues

$ #76282
PROPOSAL: #76282 (comment)

Tests

Same as QA tests

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

go to a workspace to enable tags
go to Tags
click Import button
choose Single level of tags
choose file to upload
upload a valid tags file
verify file can be uploaded
upload a large valid tags file
verify that Choose file button is loading and then navigate to next page
upload an invalid file
verify that error modal shows up

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-01-12.at.11.26.42.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-12.at.11.28.24.PM.mov

melvin-bot · 2026-01-12T15:43:29Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2026-01-12T15:45:06Z

Hmm, I think melvin should request review from @FitseTLT

codecov · 2026-01-12T15:52:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ImportSpreadsheet.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

eh2077 · 2026-01-20T08:54:32Z

@FitseTLT friendly bump

FitseTLT · 2026-01-23T18:59:55Z

Will check this on monday

ikevin127 · 2026-01-25T01:55:50Z

@mollfpr Please remove me as reviewer and add @FitseTLT whenever you get a chance 🙌

mollfpr · 2026-01-26T23:59:41Z

I couldn't find @FitseTLT to add as a reviewer.

FitseTLT · 2026-01-27T00:07:24Z

May be if my commenting helps

FitseTLT · 2026-01-28T15:58:58Z

Checking

FitseTLT · 2026-01-29T13:22:17Z

@eh2077 can u pls merge main?

FitseTLT · 2026-02-02T15:49:52Z

@eh2077 Can u resolve the conflicts please?

…tag-no-loading-status

github-actions · 2026-02-04T02:25:36Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

…tag-no-loading-status

eh2077 · 2026-02-04T02:57:02Z

Sorry about the force pushes, just setup a new dev env to make remote build cache work. Tested well again.

Screen.Recording.2026-02-04.at.10.24.25.AM.mov

FitseTLT · 2026-02-04T13:54:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

2026-02-04.16-52-26.mp4

iOS: HybridApp

2026-02-04.22-54-32.mp4

iOS: mWeb Safari

2026-02-04.16-51-20.mp4

MacOS: Chrome / Safari

2026-02-04.16-47-37.mp4

FitseTLT · 2026-02-04T14:00:54Z

@eh2077 remove the first step because this change should be tested in all platforms.

eh2077 · 2026-02-04T14:11:57Z

Updated!

FitseTLT · 2026-02-04T20:45:51Z

@mollfpr U may proceed

mollfpr

LGTM! Thank you!

github-actions · 2026-02-05T06:00:33Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-05T06:04:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-05T06:05:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79363.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-42c19be-2e219f78ca3bc5337bdb26c14e30c9994ec2829b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-42c19be-403a7d4b5b86c5a9d928e38f36d0492881f3b878/index.html

Web 🕸️
https://79363.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-05T20:46:12Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:46:38Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-10T07:02:33Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: iOS import tag no loading status on the button

6d86eef

eh2077 requested review from a team as code owners January 12, 2026 15:43

melvin-bot bot assigned eh2077 Jan 12, 2026

melvin-bot bot requested review from heyjennahay and ikevin127 and removed request for a team January 12, 2026 15:43

melvin-bot bot removed the request for review from a team January 12, 2026 15:43

mollfpr removed the request for review from ikevin127 January 26, 2026 23:57

eh2077 added 3 commits February 3, 2026 23:16

merge with main and fix conflicts

dcfe842

fix lint

b0d22fa

Merge remote-tracking branch 'origin/main' into 76282-fix-ios-import-…

fe4f1b1

…tag-no-loading-status

eh2077 force-pushed the 76282-fix-ios-import-tag-no-loading-status branch from fa83489 to c1585c4 Compare February 4, 2026 02:41

Merge remote-tracking branch 'origin/main' into 76282-fix-ios-import-…

2b24005

…tag-no-loading-status

eh2077 force-pushed the 76282-fix-ios-import-tag-no-loading-status branch from c1585c4 to 2b24005 Compare February 4, 2026 02:52

FitseTLT approved these changes Feb 4, 2026

View reviewed changes

mollfpr approved these changes Feb 5, 2026

View reviewed changes

mollfpr merged commit 42c19be into Expensify:main Feb 5, 2026
31 checks passed

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Closed

This was referenced Feb 23, 2026

[Due for Payment 2026-02-17] [$250] IOS - Import Tag - Unable to import txt. file #76282

Closed

Add CSV import flow to Categories page #47827

Merged

Conversation

eh2077 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 12, 2026

Uh oh!

eh2077 commented Jan 12, 2026

Uh oh!

codecov bot commented Jan 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eh2077 commented Jan 20, 2026

Uh oh!

FitseTLT commented Jan 23, 2026

Uh oh!

ikevin127 commented Jan 25, 2026

Uh oh!

mollfpr commented Jan 26, 2026

Uh oh!

FitseTLT commented Jan 27, 2026

Uh oh!

FitseTLT commented Jan 28, 2026

Uh oh!

FitseTLT commented Jan 29, 2026

Uh oh!

FitseTLT commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Feb 4, 2026

Uh oh!

FitseTLT commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Feb 4, 2026

Uh oh!

eh2077 commented Feb 4, 2026

Uh oh!

FitseTLT commented Feb 4, 2026

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eh2077 commented Jan 12, 2026 •

edited

Loading

codecov bot commented Jan 12, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

FitseTLT commented Feb 4, 2026 •

edited

Loading