Fix issues blocking the DeployBlockerCash workflow from running#79400
Fix issues blocking the DeployBlockerCash workflow from running#79400
Conversation
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8179f13af6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Only validate write access for manual dispatch - label events are already gated by GitHub's | ||
| # permission model (triage+ can add labels), and the workflow uses controlled tools | ||
| - name: Validate actor has write access | ||
| if: github.event_name == 'workflow_dispatch' | ||
| uses: ./.github/actions/composite/validateActor |
There was a problem hiding this comment.
Keep write-access gate for label-triggered runs
By gating validateActor only on workflow_dispatch, any user with triage permission who can add the DeployBlockerCash label can now trigger a workflow run that uses secrets.OS_BOTIFY_TOKEN with gh api access (see the Claude step in this same job). This is a permission escalation relative to the previous behavior: triage users (who do not have write/admin) can indirectly perform bot-privileged actions like commenting or label edits via the Claude agent. If a triage user adds the label, the workflow will run with those secrets and tools, which was previously blocked by the write check.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is known and expected, the actions themselves are limited with scripts and if you are able to add the label you should be able to run the workflow
|
Merging this one so it can work on new blockers |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.3.1-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀
|
Explanation of Change
Problem 1: Workflow blocked for triage users
The workflow would trigger when someone added the DeployBlockerCash label, but immediately skip.
The validateActor step required write or admin permission. If you have access to add the label, it should be able to run
Problem 2: Concurrent runs canceling each other
The concurrency config had cancel-in-progress: true. If the same issue received multiple label events (label removed/re-added, multiple people trying to add it, or any race condition), the runs would cancel each other instead of completing.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari