Fix showing of billable column when policy exists but defaultBillable isn't present by ShridharGoel · Pull Request #79421 · Expensify/App

ShridharGoel · 2026-01-13T07:26:36Z

Explanation of Change

Updated isBillableEnabledOnPolicy to require disabledFields.defaultBillable === false so missing policy fields don’t
incorrectly show the column.

Fixed Issues

$ #79418
$ #79413
PROPOSAL:

Tests

Go to staging.new.expensify.com
Create a workspace.
Open 1:1 DM with any user.
Submit two expenses to the user.
Open the IOU report.
→ Billable column is not shown - Expected.
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh OR relogin.
Open the same IOU report.
Billable column will not show up in IOU report after reset app/relogin.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-13.at.12.55.39.PM.mov

…doesn't

melvin-bot · 2026-01-13T07:26:43Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-13T07:26:48Z

@DylanDylann @JS00001 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-01-13T07:27:05Z

@Pujan92 is the C+ on this.

codecov · 2026-01-13T07:34:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/MoneyRequestReportUtils.ts	`73.01% <100.00%> (ø)`
... and 76 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c45285118

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-13T07:34:56Z

src/libs/MoneyRequestReportUtils.ts

 function isBillableEnabledOnPolicy(policy: Policy | OnyxEntry<Policy> | undefined): boolean {
-    return !!policy && policy.disabledFields?.defaultBillable !== true;
+    return !!policy && policy.disabledFields?.defaultBillable === false;


Defaulting missing disabledFields to disabled hides billable column

This now returns false when disabledFields.defaultBillable is undefined. disabledFields is optional in the policy schema and other code paths treat a missing value as “not disabled” (e.g., the workspace billable toggle uses ?? false and reimbursable checks treat missing as enabled), so policies that omit this field (older policies or partial Onyx records) will have the billable column hidden even though billable tracking is effectively enabled and billable transactions may exist. That results in a missing column in money request reports for those policies; consider treating undefined as enabled (the prior !== true behavior) to keep this consistent.

Useful? React with 👍 / 👎.

Awaiting confirmation from @JS00001

I think the bots correct, if its undefined, then defaultBillable should not be a disabled field.

Can we come up with another way of doing this?

Then isn't the bug invalid? The issue was happening because defaultBillable wasn't available in the personal policy I think.

So, if we consider it as true when defined, then the column would show

I think the bots correct, if its undefined, then defaultBillable should not be a disabled field.

Isn't hiding the billable column correct whenever the policy disabledFields data isn't available?

Expenses are able to be marked as billable, unless the field is disabled I believe

@ShridharGoel I think that we can add some checks for that. For example, if the policy is a non-corporate policy, then return false.

Pujan92 · 2026-01-13T11:20:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

DylanDylann · 2026-01-13T12:23:23Z

@JS00001 Please help remove me from this PR

Pujan92

LGTM!

Screen.Recording.2026-01-13.at.17.57.34.mov

JS00001 · 2026-01-13T13:48:41Z

@ShridharGoel commented on this solution

JS00001 · 2026-01-13T14:54:12Z

@Pujan92 Can you please re-validate this PR against both blockers?

Pujan92 · 2026-01-13T16:55:44Z

@JS00001 looks fine to me for those blockers.

Screen.Recording.2026-01-13.at.22.19.48.mov

For example, if the policy is a non-corporate policy, then return false.

We are not showing that column for the non-corporate(team) policy type, even though disabledFields?.defaultBillable is false.

Screen.Recording.2026-01-13.at.22.20.50.mov

JS00001 · 2026-01-13T17:09:59Z

@ShridharGoel I think that we'd need to check isPaidGroupPolicy, not just === Corporate

joekaufmanexpensify

DB fix 👍

OSBotify · 2026-01-13T18:31:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T03:24:47Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:32:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix showing of billable column when policy exists but disabledFields …

1c45285

…doesn't

ShridharGoel requested review from a team as code owners January 13, 2026 07:26

melvin-bot bot assigned ShridharGoel Jan 13, 2026

melvin-bot bot requested review from ahmedGaber93 and joekaufmanexpensify and removed request for a team January 13, 2026 07:26

melvin-bot bot requested review from a team, DylanDylann and JS00001 and removed request for a team January 13, 2026 07:26

ShridharGoel changed the title ~~Fix showing of billable column when policy exists but disabledFields doesn't~~ Fix showing of billable column when policy exists but defaultBillable isn't present Jan 13, 2026

ShridharGoel mentioned this pull request Jan 13, 2026

[Due for payment 2026-01-21] Expense - Billable column shows up in IOU report after reset app/relogin #79418

Closed

7 tasks

chatgpt-codex-connector bot reviewed Jan 13, 2026

View reviewed changes

Pujan92 approved these changes Jan 13, 2026

View reviewed changes

Pujan92 mentioned this pull request Jan 13, 2026

[Due for payment 2026-01-21] Expense - Invited member can see Billable column when billable is not enabled #79413

Closed

7 tasks

JS00001 removed request for DylanDylann and ahmedGaber93 January 13, 2026 13:48

Update to include coroporate policy condition

82a2c3c

joekaufmanexpensify previously approved these changes Jan 13, 2026

View reviewed changes

Update to check paid group policy

b3e62e2

ShridharGoel dismissed joekaufmanexpensify’s stale review via b3e62e2 January 13, 2026 17:36

JS00001 approved these changes Jan 13, 2026

View reviewed changes

JS00001 merged commit e549b6b into Expensify:main Jan 13, 2026
31 checks passed

OSBotify mentioned this pull request Jan 14, 2026

Deploy Checklist: New Expensify 2026-01-14 #79522

Closed

39 tasks

Conversation

ShridharGoel commented Jan 13, 2026 • edited by JS00001 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

ShridharGoel commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jan 13, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Jan 13, 2026

Uh oh!

JS00001 commented Jan 13, 2026

Uh oh!

Pujan92 commented Jan 13, 2026

Uh oh!

JS00001 commented Jan 13, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

ShridharGoel commented Jan 13, 2026 •

edited by JS00001

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

Pujan92 commented Jan 13, 2026 •

edited

Loading