[Release 2] [Domain Control] Add domain member by jmusial · Pull Request #79450 · Expensify/App

jmusial · 2026-01-13T11:05:08Z

Explanation of Change

Part for Domain Control project. This PR adds adding (removing) the domain member with GBR and RBR flows.

Current blockers:

waiting on BE to be deployed
waiting on BE errors implementation

But works on local BE and all videos are there.

Fixed Issues

$ #78126

PROPOSAL:

Tests

Pre requisutes:

Have an account with a domain admin rights added.

1. Positive test

Open "Workspaces" -> "Domain" -> "Members"
Click on "Add member"
Enter email
Click "Invite"
Verify that user have been invited

2. Error test

Pre requisite: On Debug modal select Simulate failing network requests

Open "Workspaces" -> "Domain" -> "Members"
Click on "Add member"
Enter email
Click "Invite"
Verify that user shows on the list with an error
Verify that user row dissapears on dismiss error

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

0085.android.native.mov

Android: mWeb Chrome

0085.andorid.chrome.mov

iOS: Native

0085.ios.native.mov

iOS: mWeb Safari

0085.ios.safari.mov

MacOS: Chrome / Safari

0085.desktop.chrome.mov

…feature/kuba-nowakowski/add__domain_addmembers_page # Conflicts: # src/languages/en.ts # src/libs/API/types.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/types.ts # src/libs/actions/Domain.ts # src/pages/domain/Members/DomainMembersPage.tsx # src/types/onyx/DomainPendingActions.ts

…feature/kuba-nowakowski/add__domain_addmembers_page

…rs_page

melvin-bot · 2026-01-13T11:05:14Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-01-13T11:21:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...avigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/actions/Domain.ts	`25.22% <100.00%> (+9.06%)`	⬆️
src/selectors/Domain.ts	`89.18% <100.00%> (+0.30%)`	⬆️
src/ROUTES.ts	`13.42% <0.00%> (+0.08%)`	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.89% <0.00%> (-0.02%)`	⬇️
src/pages/domain/Admins/DomainAddAdminPage.tsx	`0.00% <0.00%> (ø)`
... and 4 more
... and 20 files with indirect coverage changes

…rs_page

war-in · 2026-01-26T11:05:49Z

@mountiny tested and it works fine! I think we can proceed with this PR

situchan · 2026-01-26T11:30:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

situchan · 2026-01-26T11:39:36Z

A few questions regarding Form UX when input is invalid:

Should we disable submit button? Other forms don't disable it and instead show RBR above button when submit.
Should we always show input error? Other forms don't show error before submitting first time.

Screen.Recording.2026-01-26.at.5.36.17.PM.mov

situchan · 2026-01-26T11:43:05Z

Bug: profile page shows Hidden after invite member and immediately go to detail

Screen.Recording.2026-01-26.at.5.42.02.PM.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c94713fa7c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/domain/Members/DomainAddMemberPage.tsx

situchan · 2026-01-26T11:45:46Z

Bug: RBR message is too close to next row

war-in · 2026-01-26T15:17:57Z

A few questions regarding Form UX when input is invalid:

@situchan I applied your suggestions by using FormProvider. The component should be now aligned with our form best practices - ac6263b

war-in · 2026-01-26T15:18:53Z

Bug: profile page shows Hidden after invite member and immediately go to detail

That's because we remove the optimistic user 🤔 I'll check how it works on other screens

war-in · 2026-01-26T15:25:14Z

Bug: RBR message is too close to next row

don't we already have an issue for this? 🤔 This issue also occurs on workspace members page

situchan · 2026-01-26T15:27:02Z

Bug: RBR message is too close to next row

don't we already have an issue for this? 🤔 This issue also occurs on workspace members page

Not sure issue created for this but agree out of scope since happening on other pages

war-in · 2026-01-26T15:39:12Z

That's because we remove the optimistic user 🤔 I'll check how it works on other screens

I verified that on the workspace members page we mark the row as non-interactive - fixed here

Screen.Recording.2026-01-26.at.16.37.13.mov

war-in · 2026-01-26T15:39:40Z

All comments addressed!

situchan · 2026-01-26T15:46:56Z

New bug: autofocus input doesn't work

Screen.Recording.2026-01-26.at.9.46.28.PM.mov

war-in · 2026-01-26T15:59:42Z

New bug: autofocus input doesn't work

@situchan fixed

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce04415818

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-26T16:05:59Z

src/libs/actions/Domain.ts

+            key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
+            value: {
+                [DOMAIN_SECURITY_GROUP]: {
+                    shared: {
+                        [optimisticAccountID]: null,
+                    },


Remove null shared entries to avoid ghost members

Here the optimistic member is “removed” by setting shared[optimisticAccountID] to null, but memberAccountIDsSelector (src/selectors/Domain.ts) derives member IDs from Object.keys(shared) without checking the value. Since Onyx merges keep null keys around (the admin selector already filters nulls for this reason), a null entry can still be returned as a member after a successful add or error dismissal, leaving a blank/undismissable row. Either delete the key or update the selector to ignore null values.

Useful? React with 👍 / 👎.

Onyx merges keep null keys around (the admin selector already filters nulls for this reason), a null entry can still be returned as a member after a successful add or error dismissal, leaving a blank/undismissable row

I dont think that is correct, the null merge will be removed

OSBotify · 2026-01-26T23:08:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:11:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:56:42Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

sumo-slonik and others added 18 commits December 22, 2025 10:56

add members details page

7d5ea4f

working on onyx

6fa3b5b

fix imports

f763066

add plus icon

ed4a429

add onyx actions without correct typing

2a390b7

wip

9c69205

working adding user flow (without backend check)

961125a

working adding user flow (without backend check)

ef7a406

Merge branch 'feature/kuba-nowakowski/add__domain_members_page' into …

ba676b3

…feature/kuba-nowakowski/add__domain_addmembers_page

cleanup a bit

188a16a

Lint fix

d98a367

fix lint

56ad03c

remove unused param

8782f9e

refactor: improve the DomainAddMemberPage

56d7d06

Merge branch 'feature/kuba-nowakowski/add__domain_members_page' into …

2ca5f68

…feature/kuba-nowakowski/add__domain_addmembers_page

remove redundant params, add wrapper

15141ff

Merge branch 'main' into feature/kuba-nowakowski/add__domain_addmembe…

d43437f

…rs_page

melvin-bot bot assigned jmusial Jan 13, 2026

fix prettier

2795369

jmusial moved this to In Progress in Bring Domain Control to NewDot Jan 13, 2026

jmusial added this to Bring Domain Control to NewDot Jan 13, 2026

jmusial changed the title ~~[Release 2] [Domain Control] Add domain member~~ [HOLD] [Release 2] [Domain Control] Add domain member Jan 13, 2026

Merge branch 'main' into feature/kuba-nowakowski/add__domain_addmembe…

64ad4f0

…rs_page

jmusial mentioned this pull request Jan 14, 2026

[HOLD] [NOT READY FOR REVIEW] Domain members add member software-mansion-labs/expensify-app-fork#279

Closed

53 tasks

jmusial added 3 commits January 15, 2026 09:07

Merge branch 'main' into feature/kuba-nowakowski/add__domain_addmembe…

1b317bb

…rs_page

prettier fix

3d0712c

update domain types

c0ed53a

fix: eslint

c94713f

chatgpt-codex-connector bot reviewed Jan 26, 2026

View reviewed changes

src/pages/domain/Members/DomainAddMemberPage.tsx Show resolved Hide resolved

refactor: use FormProvider

ac6263b

war-in added 2 commits January 26, 2026 16:27

fix: go back to members page

c59d604

fix: make member non-interactive when waiting for API response

ce04415

fix: text input focus issue

591d41b

situchan approved these changes Jan 26, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 26, 2026 16:01

chatgpt-codex-connector bot reviewed Jan 26, 2026

View reviewed changes

mountiny approved these changes Jan 26, 2026

View reviewed changes

mountiny merged commit 164d05a into Expensify:main Jan 26, 2026
33 checks passed

github-project-automation bot moved this from In Progress to Done in Bring Domain Control to NewDot Jan 26, 2026

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

melvin-bot bot mentioned this pull request Jan 28, 2026

[Due for payment 2026-02-04] [Release 2] [Domain Control] Close domain member account #78126

Closed

Conversation

jmusial commented Jan 13, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. Positive test

2. Error test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

situchan commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Jan 26, 2026

Uh oh!

situchan commented Jan 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

situchan commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

situchan commented Jan 26, 2026

Uh oh!

war-in commented Jan 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmusial commented Jan 13, 2026 •

edited by mountiny

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

situchan commented Jan 26, 2026 •

edited

Loading