fix:78318: Hide Table.Header when isEmptyResult is true by Eskalifer1 · Pull Request #79472 · Expensify/App

Eskalifer1 · 2026-01-13T14:07:42Z

Explanation of Change

This PR fixes an issue where the table header remained visible when a search query returned no results

Fixed Issues

$#78318
PROPOSAL:#78318 (comment)

Tests

Precondition:
Workspace has company cards.

Go to workspace settings > Company cards.
On the search field, type anything that will not return results.
Ensure that Table header will be hidden when there is no results

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

78318-android-native.mov

Android: mWeb Chrome

78318-android-web.mov

iOS: Native

78318-ios-native.mov

iOS: mWeb Safari

78318-ios-web.mov

MacOS: Chrome / Safari

78318-web.mov

melvin-bot · 2026-01-13T14:07:49Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-13T14:16:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Table/Table.tsx	`88.88% <100.00%> (+2.22%)`	⬆️
src/components/Table/TableBody.tsx	`100.00% <ø> (ø)`
src/components/Table/TableContext.tsx	`75.00% <ø> (ø)`
src/components/Table/TableHeader.tsx	`100.00% <100.00%> (ø)`
... and 44 files with indirect coverage changes

hungvu193 · 2026-01-13T14:46:10Z

src/components/Table/TableHeader.tsx

+    const hasActiveFilters = filterConfig
+        ? Object.keys(activeFilters).some((key) => {
+              const filterValue = activeFilters[key];
+              const defaultValue = filterConfig?.[key]?.default;
+              return filterValue !== defaultValue;
+          })
+        : false;
+
+    const hasSearchString = activeSearchString.trim().length > 0;
+    const isEmptyResult = filteredAndSortedData.length === 0 && originalDataLength > 0 && (hasSearchString || hasActiveFilters);


Do you think we can move this logic into TableContext and reuse it everywhere else since it's duplciate logic?

Yes, I think it's possible, because we define the context here:

App/src/components/Table/Table.tsx

Lines 179 to 192 in ef24438

const contextValue: TableContextValue<T, ColumnKey, FilterKey> = {

listRef,

listProps,

processedData,

originalDataLength: data?.length ?? 0,

columns,

filterConfig: filters,

activeFilters: currentFilters,

activeSorting,

activeSearchString,

tableMethods,

};

return <TableContext.Provider value={contextValue as unknown as TableContextValue<unknown, string>}>{children}</TableContext.Provider>;

Therefore, I believe we can define this data here and then pass it, but in Header.Body we will still have to retrieve most of these values, as they are used not only to define the empty state. I will update the PR within a few hours.

Updated PR!

hungvu193 · 2026-01-13T15:43:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-13.at.22.41.00.mov

Android: mWeb Chrome

Screen.Recording.2026-01-13.at.22.41.00.mov

iOS: HybridApp

Screen.Recording.2026-01-13.at.22.19.46.mov

iOS: mWeb Safari

Screen.Recording.2026-01-13.at.22.10.49.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-13.at.22.07.38.mov

hungvu193

LGTM

carlosmiceli · 2026-01-13T15:58:17Z

@joekaufmanexpensify do you need to review it too?

joekaufmanexpensify

Makes sense from a product perspective 👍

OSBotify · 2026-01-13T17:30:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T03:25:03Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:33:10Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix:78318: Hide Table.Header when isEmptyResult is true

ff3d364

Eskalifer1 requested review from a team as code owners January 13, 2026 14:07

melvin-bot bot assigned Eskalifer1 Jan 13, 2026

melvin-bot bot requested review from hungvu193 and joekaufmanexpensify and removed request for a team January 13, 2026 14:07

melvin-bot bot removed the request for review from a team January 13, 2026 14:07

hungvu193 reviewed Jan 13, 2026

View reviewed changes

Eskalifer1 added 2 commits January 13, 2026 17:22

feat: refactor code to use context values instead of duplicate

c30a170

fix eslint

573260e

hungvu193 approved these changes Jan 13, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli January 13, 2026 15:43

carlosmiceli approved these changes Jan 13, 2026

View reviewed changes

joekaufmanexpensify approved these changes Jan 13, 2026

View reviewed changes

carlosmiceli merged commit a70a2f1 into Expensify:main Jan 13, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Jan 14, 2026

Deploy Checklist: New Expensify 2026-01-14 #79522

Closed

39 tasks

melvin-bot bot mentioned this pull request Jan 14, 2026

[Due for payment 2026-01-21] [$250] Company cards - Table header is shown when there is no result #78318

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix:78318: Hide Table.Header when isEmptyResult is true#79472

fix:78318: Hide Table.Header when isEmptyResult is true#79472
carlosmiceli merged 3 commits intoExpensify:mainfrom
Eskalifer1:fix/78318

Eskalifer1 commented Jan 13, 2026

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

Uh oh!

hungvu193 Jan 13, 2026

Uh oh!

Eskalifer1 Jan 13, 2026

Uh oh!

Eskalifer1 Jan 13, 2026

Uh oh!

hungvu193 commented Jan 13, 2026

Uh oh!

hungvu193 left a comment

Uh oh!

carlosmiceli commented Jan 13, 2026

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	const contextValue: TableContextValue<T, ColumnKey, FilterKey> = {
	listRef,
	listProps,
	processedData,
	originalDataLength: data?.length ?? 0,
	columns,
	filterConfig: filters,
	activeFilters: currentFilters,
	activeSorting,
	activeSearchString,
	tableMethods,
	};

	return <TableContext.Provider value={contextValue as unknown as TableContextValue<unknown, string>}>{children}</TableContext.Provider>;

Conversation

Eskalifer1 commented Jan 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hungvu193 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jan 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Jan 13, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading