Fix: Badge Alignment on workspace members page by nyomanjyotisa · Pull Request #79491 · Expensify/App

nyomanjyotisa · 2026-01-13T15:44:15Z

Explanation of Change

Add a badgeStyles prop to MemberRightIcon and pass styles.alignSelfEnd from WorkspaceMembersPage to override the default alignSelfCenter on workspace members page

Fixed Issues

$ #79341
PROPOSAL: #79341 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to Workspace Settings -> Members
Have at least three members
One member should have an Owner badge, the second should be an Admin, and the last one should be an Auditor
Verify that all badges are aligned to the right

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-01-13T15:58:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/MemberRightIcon.tsx	`100.00% <100.00%> (ø)`
src/pages/workspace/WorkspaceMembersPage.tsx	`66.98% <ø> (ø)`
... and 66 files with indirect coverage changes

melvin-bot · 2026-01-13T17:19:56Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-01-13T17:24:21Z

src/pages/workspace/WorkspaceMembersPage.tsx

                        role={policyEmployee.role}
                        owner={policy?.owner}
                        login={details.login}
+                        badgeStyles={[styles.alignSelfEnd]}


Is this change needed?

Oh yeah, after rechecking, I don’t think we need to pass the badgeStyles prop here. The component is rendered directly without a wrapping View, so it already aligns to the right in the narrow layout

PR updated

situchan · 2026-01-13T17:43:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

war-in · 2026-01-13T17:47:51Z

src/pages/workspace/MemberRightIcon.tsx

+        return (
+            <Badge
+                text={translate(badgeText)}
+                badgeStyles={badgeStyles}


shouldn't we define that style directly here?

styles.alignSelfEnd

that way, badges on all pages will be aligned

That's ok too but need to test all affected pages.
Wanted to limit the scope of fix as issue happens only in one place.

It also happened on the DomainAdminsPage with the Primary contact badge (there are no other badges there but Jon noticed that the distance from the right icon is different from the workspace members page)

(both solutions are fine for me, we can set the style manually on the admins page too)

Sure, btw direct Badge (not MemberRightIcon) is used in DomainAdminsPage.

joekaufmanexpensify

👍

OSBotify · 2026-01-15T17:47:09Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.3-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:17:17Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: Badge Alignment on workspace members page

49643b6

melvin-bot bot assigned nyomanjyotisa Jan 13, 2026

lint fix

417f826

lint fix

5da5744

nyomanjyotisa marked this pull request as ready for review January 13, 2026 17:19

nyomanjyotisa requested review from a team as code owners January 13, 2026 17:19

melvin-bot bot requested review from joekaufmanexpensify and situchan and removed request for a team January 13, 2026 17:19

melvin-bot bot removed the request for review from a team January 13, 2026 17:19

nyomanjyotisa mentioned this pull request Jan 13, 2026

[Due for payment 2026-01-28] [$100] Fix Badge Alignment on workspace members page #79341

Closed

7 tasks

situchan reviewed Jan 13, 2026

View reviewed changes

minor fix

d2f9385

war-in reviewed Jan 13, 2026

View reviewed changes

situchan approved these changes Jan 13, 2026

View reviewed changes

melvin-bot bot requested a review from grgia January 13, 2026 18:06

joekaufmanexpensify approved these changes Jan 14, 2026

View reviewed changes

grgia approved these changes Jan 15, 2026

View reviewed changes

grgia merged commit b756143 into Expensify:main Jan 15, 2026
32 of 36 checks passed

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Badge Alignment on workspace members page#79491

Fix: Badge Alignment on workspace members page#79491
grgia merged 4 commits intoExpensify:mainfrom
nyomanjyotisa:issue-79341

nyomanjyotisa commented Jan 13, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

situchan Jan 13, 2026

Uh oh!

nyomanjyotisa Jan 13, 2026 •

edited

Loading

Uh oh!

situchan commented Jan 13, 2026 •

edited

Loading

Uh oh!

war-in Jan 13, 2026

Uh oh!

situchan Jan 13, 2026

Uh oh!

war-in Jan 13, 2026

Uh oh!

situchan Jan 13, 2026 •

edited

Loading

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nyomanjyotisa commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

situchan Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

war-in Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

war-in Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nyomanjyotisa commented Jan 13, 2026 •

edited

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

nyomanjyotisa Jan 13, 2026 •

edited

Loading

situchan commented Jan 13, 2026 •

edited

Loading

situchan Jan 13, 2026 •

edited

Loading