fix QBD - Application crashes when try to connect QBD by situchan · Pull Request #79511 · Expensify/App

situchan · 2026-01-13T21:23:58Z

Explanation of Change

The offending PR is #79286.
The root cause is related to react compiler.
The culprit is here:

App/src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx

Lines 41 to 43 in b0ad823

    
           const ContentWrapper = hasResultOfFetchingSetupLink 
        
               ? ({children}: React.PropsWithChildren) => children 
        
               : ({children}: React.PropsWithChildren) => <FullPageOfflineBlockingView addBottomSafeAreaPadding>{children}</FullPageOfflineBlockingView>;

Crash log:

I updated code like this:

Before:

ContentWrapper = hasResultOfFetchingSetupLink ? ({children}) => children : ({children}) => <FullPageOfflineBlockingView>{children}</FullPageOfflineBlockingView>

render:
...
<ContentWrapper>{children}</ContentWrapper>
...

After:

render:
...
{hasResultOfFetchingSetupLink ? children : <FullPageOfflineBlockingView>{children}</FullPageOfflineBlockingView>}
...

Fixed Issues

$ #79454

Tests

Precondition: Control workspace with enabled Accounting.

Go to Accounting
Click on Connect nearby QuickBook Desktop
Verify that 'QuickBooks Desktop setup' tap opens without crash

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-14.at.3.21.41.AM.mov

codecov · 2026-01-13T21:32:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...pace/accounting/qbd/QuickBooksDesktopSetupPage.tsx	`0.00% <0.00%> (ø)`
... and 4 files with indirect coverage changes

melvin-bot · 2026-01-13T23:11:21Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-13T23:13:34Z

src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx


    const shouldShowError = hasError;

+    const children = (


❌ PERF-4 (docs)

The children JSX element is not memoized and is passed to the memoized FullPageOfflineBlockingView component. Since the parent component is not optimized by React Compiler, this creates a new React element on every render, breaking memoization and causing unnecessary re-renders.

Suggested fix: Wrap the children declaration with useMemo:

const children = useMemo(() => ( <> {shouldShowError && ( // ... existing JSX )} {!shouldShowError && ( // ... existing JSX )} </> ), [shouldShowError, hasResultOfFetchingSetupLink, codatSetupLink, styles, translate, illustrations, environmentURL, policyID]);

I think react compiler already auto memoize this. So false alarm

francoisl · 2026-01-13T23:18:11Z

Reassigning to @aimane-chnaif as discussed in https://expensify.slack.com/archives/C02NK2DQWUX/p1768346037487499 since this is for a deploy blocker

aimane-chnaif · 2026-01-13T23:35:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

francoisl

Thanks for the quick review!

fix QBD - Application crashes when try to connect QBD (cherry picked from commit 7151e41) (cherry-picked to staging by francoisl)

OSBotify · 2026-01-13T23:52:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T00:51:21Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.0-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-01-14T02:58:39Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T03:25:18Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:33:25Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix QBD - Application crashes when try to connect QBD

d5db69d

melvin-bot bot assigned situchan Jan 13, 2026

situchan mentioned this pull request Jan 13, 2026

[Awaiting Payment][$250] QBD - Application crashes when try to connect QBD #79454

Closed

7 tasks

situchan marked this pull request as ready for review January 13, 2026 23:11

situchan requested review from a team as code owners January 13, 2026 23:11

melvin-bot bot requested review from hoangzinh and joekaufmanexpensify and removed request for a team January 13, 2026 23:11

melvin-bot bot removed the request for review from a team January 13, 2026 23:11

github-actions bot reviewed Jan 13, 2026

View reviewed changes

francoisl requested review from aimane-chnaif and removed request for hoangzinh January 13, 2026 23:17

aimane-chnaif approved these changes Jan 13, 2026

View reviewed changes

melvin-bot bot requested a review from pecanoro January 13, 2026 23:41

francoisl approved these changes Jan 13, 2026

View reviewed changes

francoisl merged commit 7151e41 into Expensify:main Jan 13, 2026
37 of 38 checks passed

OSBotify pushed a commit that referenced this pull request Jan 13, 2026

Merge pull request #79511 from situchan/fix-79454

8602658

fix QBD - Application crashes when try to connect QBD (cherry picked from commit 7151e41) (cherry-picked to staging by francoisl)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 13, 2026

OSBotify mentioned this pull request Jan 13, 2026

Deploy Checklist: New Expensify 2026-01-13 #79402

Closed

91 tasks

roryabraham mentioned this pull request Jan 14, 2026

Fix QBD setup page #79518

Closed

53 tasks

situchan deleted the fix-79454 branch March 18, 2026 19:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix QBD - Application crashes when try to connect QBD#79511

fix QBD - Application crashes when try to connect QBD#79511
francoisl merged 1 commit intoExpensify:mainfrom
situchan:fix-79454

situchan commented Jan 13, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

github-actions bot Jan 13, 2026

Uh oh!

aimane-chnaif Jan 13, 2026 •

edited

Loading

Uh oh!

francoisl commented Jan 13, 2026

Uh oh!

aimane-chnaif commented Jan 13, 2026 •

edited

Loading

Uh oh!

francoisl left a comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const ContentWrapper = hasResultOfFetchingSetupLink
	? ({children}: React.PropsWithChildren) => children
	: ({children}: React.PropsWithChildren) => <FullPageOfflineBlockingView addBottomSafeAreaPadding>{children}</FullPageOfflineBlockingView>;

Conversation

situchan commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

github-actions bot Jan 13, 2026

Choose a reason for hiding this comment

❌ PERF-4 (docs)

Uh oh!

aimane-chnaif Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francoisl commented Jan 13, 2026

Uh oh!

aimane-chnaif commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

OSBotify commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

situchan commented Jan 13, 2026 •

edited

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

aimane-chnaif Jan 13, 2026 •

edited

Loading

aimane-chnaif commented Jan 13, 2026 •

edited

Loading