fix: the button has interactive elements nested inside by daledah · Pull Request #79525 · Expensify/App

daledah · 2026-01-14T04:02:10Z

Explanation of Change

Fixed Issues

$ #76909
PROPOSAL: #76909 (comment)

Tests

Go to workspace
Go to Workflow page
Using TAB to the 'Approvals' sections
When users navigate to the 'Approvals' section on the Workflows page, the element will only be focused and announced once, and there will be no additional controls nested within the button element.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

melvin-bot · 2026-01-14T04:19:29Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-14T04:19:36Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-01-14T08:46:09Z

@dukenv0307 all yours

mountiny · 2026-01-14T13:22:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6284112802

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-14T13:33:04Z

src/components/ApprovalWorkflowSection.tsx

+                    shouldBeAccessible={false}
+                    tabIndex={-1}


Preserve approval details for screen readers

Marking this MenuItem as inaccessible (shouldBeAccessible={false}/tabIndex={-1}) removes it from screen‑reader navigation, but the surrounding PressableWithoutFeedback only announces its own label. As a result, VoiceOver/TalkBack users can no longer hear the members/approver details that were previously exposed via these menu items. If the goal is to avoid nested interactive elements, consider keeping the text accessible (e.g., include it in the parent’s accessibilityLabel/hint or render static text) while removing only the nested pressable behavior.

Useful? React with 👍 / 👎.

But I think it's fine to keep the accessibilityLabel as it is

@rushatgabhane Could you help out here? I am not sure that based on the ai comment this is the right way to go about it, does this mean that the users would not be able to get the details of the people in the approval workflow sections?

i think the expected result of the issue is incomplete

when the user tab navigates, we should announce expenses from [users], and the approver [users]

if we can do it from parent level that'll be great because entire thing is ONE pressable.

So this PR is good, but we need to improve the accessibility label

cc @dukenv0307 wdyt

ok I'm fine with this approach. @daledah can you please fix it?

dukenv0307 · 2026-01-14T15:31:17Z

on it now

dukenv0307 · 2026-01-14T15:40:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-14.at.22.38.53.mov

Android: mWeb Chrome

Screen.Recording.2026-01-14.at.22.36.49.mov

iOS: HybridApp

Screen.Recording.2026-01-14.at.22.40.07.mov

iOS: mWeb Safari

Screen.Recording.2026-01-14.at.22.37.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-14.at.22.35.46.mov

joekaufmanexpensify

👍

mountiny · 2026-01-15T16:34:04Z

I will merge this now to test something, but @daledah can you please follow up on #79525 (comment)

OSBotify · 2026-01-15T17:47:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.3-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:17:20Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: the button has interactive elements nested inside

6284112

melvin-bot bot assigned daledah Jan 14, 2026

daledah marked this pull request as ready for review January 14, 2026 04:19

daledah requested review from a team as code owners January 14, 2026 04:19

melvin-bot bot requested review from dukenv0307 and joekaufmanexpensify January 14, 2026 04:19

melvin-bot bot requested review from a team and mountiny and removed request for a team January 14, 2026 04:19

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

dukenv0307 approved these changes Jan 14, 2026

View reviewed changes

joekaufmanexpensify approved these changes Jan 14, 2026

View reviewed changes

mountiny merged commit c400682 into Expensify:main Jan 15, 2026
39 of 40 checks passed

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

Conversation

daledah commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

mountiny commented Jan 14, 2026

Uh oh!

mountiny commented Jan 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 14, 2026

Uh oh!

dukenv0307 commented Jan 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 15, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented Jan 14, 2026 •

edited

Loading

rushatgabhane Jan 14, 2026 •

edited

Loading