Ask user to continue GPS trip when reopening the app by GCyganek · Pull Request #79555 · Expensify/App

GCyganek · 2026-01-14T10:54:18Z

Explanation of Change

Adds logic that checks if there was an ongoing GPS trip before user closed the app last time. Shows a modal that asks user to Continue/View the trip if needed

Fixed Issues

$ #77222
PROPOSAL: N/A

Tests

Continue trip:

FAB > Track distance
GPS Tab > Start the GPS trip
Close the app (without stopping the trip)
Open the app and verify that it shows a modal asking to continue the trip
Tap Continue trip
Verify that it redirects the user to the GPS screen and that the GPS trip is still ongoing and that location tracking is working correctly

View trip:

FAB > Track distance
GPS Tab > Start the GPS trip
Close the app (without stopping the trip)
Open the app and verify that it shows a modal asking to continue the trip
Tap View trip
Verify that it redirects the user to the GPS screen and that the GPS trip is finished and the end address is set correctly based on the last point recorded before the app was closed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-20.at.13.45.48.mov

Screen.Recording.2026-01-20.at.13.46.25.mov

iOS: Native

Screen.Recording.2026-01-20.at.16.34.52.mov

Screen.Recording.2026-01-20.at.16.32.05.mov

melvin-bot · 2026-01-14T10:54:24Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

github-actions · 2026-01-14T10:54:28Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-01-14T11:03:44Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/AppNavigator/AuthScreens.tsx	`52.27% <ø> (ø)`
src/components/GPSTripStateChecker/index.tsx	`0.00% <0.00%> (ø)`
...rc/components/GPSTripStateChecker/index.native.tsx	`80.00% <80.00%> (ø)`
... and 17 files with indirect coverage changes

melvin-bot · 2026-01-20T13:50:33Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

GCyganek · 2026-01-20T13:51:21Z

@trjExpensify please ignore, @AndrewGable will review

src/components/GPSTripStateChecker/index.native.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1d1d7987e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/GPSTripStateChecker/index.native.tsx

dukenv0307 · 2026-01-21T03:57:49Z

src/components/GPSTripStateChecker/index.native.tsx

+    }, []);
+
+    const navigateToGpsScreen = () => {
+        const optimisticReportID = generateReportID();


Could you please update this logic just like what we did in the previous PR?

dukenv0307 · 2026-01-21T15:41:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-22.at.10.12.32.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-01-21.at.22.38.10.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

dukenv0307 · 2026-01-21T15:43:52Z

@GCyganek, I see on Android the modal opens along with the splash screen. Should we open it after the app has finished loading?

Screen.Recording.2026-01-21.at.22.40.41.mov

GCyganek · 2026-01-21T15:50:00Z

@GCyganek, I see on Android the modal opens along with the splash screen. Should we open it after the app has finished loading?

I can take a look and in a moment to see if I can do something easy to fix it now

GCyganek · 2026-01-21T16:10:19Z

Updated:

Screen.Recording.2026-01-21.at.17.09.07.mov

Screen.Recording.2026-01-21.at.17.04.57.mov

trjExpensify

Core PR of a WN project. 👍

OSBotify · 2026-01-27T20:11:42Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:56:55Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Ask user to continue trip when reopening app - GPS

660e46d

melvin-bot bot assigned GCyganek Jan 14, 2026

GCyganek mentioned this pull request Jan 14, 2026

Handle reconnection while there is an ongoing GPS trip #79558

Merged

54 tasks

GCyganek added 5 commits January 14, 2026 12:04

Add de translations

bd09abe

Translations

1aa6146

Merge branch 'main' into @GCyganek/gps/ask-user-to-continue-gps

42380f0

Stop background location tracking before killing the app

b9689e5

Merge branch 'main' into @GCyganek/gps/ask-user-to-continue-gps

d1d1d79

GCyganek marked this pull request as ready for review January 20, 2026 13:50

GCyganek requested review from a team as code owners January 20, 2026 13:50

melvin-bot bot requested review from dukenv0307 and trjExpensify January 20, 2026 13:50

melvin-bot bot removed request for a team January 20, 2026 13:50

github-actions bot reviewed Jan 20, 2026

View reviewed changes

src/components/GPSTripStateChecker/index.native.tsx Show resolved Hide resolved

github-actions bot reviewed Jan 20, 2026

View reviewed changes

src/components/GPSTripStateChecker/index.native.tsx Show resolved Hide resolved

github-actions bot reviewed Jan 20, 2026

View reviewed changes

src/components/GPSTripStateChecker/index.native.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 20, 2026

View reviewed changes

src/components/GPSTripStateChecker/index.native.tsx Show resolved Hide resolved

dukenv0307 reviewed Jan 21, 2026

View reviewed changes

GCyganek added 2 commits January 21, 2026 09:30

Merge branch 'main' into @GCyganek/gps/ask-user-to-continue-gps

3a8e637

use saved reportID for navigation

dffa3c2

Wait for the splash screen to hide before showing the modal

cf77d78

trjExpensify previously approved these changes Jan 21, 2026

View reviewed changes

dukenv0307 approved these changes Jan 22, 2026

View reviewed changes

melvin-bot bot requested a review from AndrewGable January 22, 2026 03:13

AndrewGable previously approved these changes Jan 24, 2026

View reviewed changes

Merge branch 'main' into @GCyganek/gps/ask-user-to-continue-gps

869d09c

GCyganek dismissed stale reviews from AndrewGable and trjExpensify via 869d09c January 26, 2026 09:36

Fix gps utils imports

0f445f0

GCyganek mentioned this pull request Jan 26, 2026

[GPS mileage expenses][Release 1] - Handle reconnection while there is an ongoing trip #77227

Closed

AndrewGable approved these changes Jan 27, 2026

View reviewed changes

AndrewGable merged commit 89ba5bc into Expensify:main Jan 27, 2026
30 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Conversation

GCyganek commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

codecov bot commented Jan 14, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 20, 2026

Uh oh!

GCyganek commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dukenv0307 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

GCyganek Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jan 21, 2026

Uh oh!

GCyganek commented Jan 21, 2026

Uh oh!

GCyganek commented Jan 21, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GCyganek commented Jan 14, 2026 •

edited

Loading

codecov bot commented Jan 14, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Jan 21, 2026 •

edited

Loading