-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Handle reconnection while there is an ongoing GPS trip #79558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndrewGable
merged 14 commits into
Expensify:main
from
software-mansion-labs:@GCyganek/gps/handle-reconnection
Feb 6, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
42672e2
Handle reconnection while there is an ongoing GPS trip
GCyganek 45e338b
Merge branch '@GCyganek/gps/ask-user-to-continue-gps' into @GCyganek/…
GCyganek 211eb23
Merge branch '@GCyganek/gps/ask-user-to-continue-gps' into @GCyganek/…
GCyganek 261eb01
Merge branch '@GCyganek/gps/ask-user-to-continue-gps' into @GCyganek/…
GCyganek cf37392
Merge branch '@GCyganek/gps/ask-user-to-continue-gps' into @GCyganek/…
GCyganek 6379941
Merge branch 'main' into @GCyganek/gps/handle-reconnection
GCyganek 7d3c9c2
Fix import
GCyganek 2f033ea
Do not call reverseGeocodeAsync in offline mode
GCyganek 8bfa9f6
Rerun Jest tests
GCyganek 32bad4c
Add explanation and refactor code to avoid repetition
GCyganek 69104c1
startAddress => address
GCyganek 63c5551
Merge branch 'main' into @GCyganek/gps/handle-reconnection
GCyganek 5c8a4d2
Merge branch 'main' into @GCyganek/gps/handle-reconnection
GCyganek 2df5c75
Prettier fix
GCyganek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
src/components/GPSTripStateChecker/useUpdateGpsTripOnReconnect.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import useNetwork from '@hooks/useNetwork'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import {setEndAddress, setStartAddress} from '@libs/actions/GPSDraftDetails'; | ||
| import {addressFromGpsPoint} from '@libs/GPSDraftDetailsUtils'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {GpsDraftDetails} from '@src/types/onyx'; | ||
|
|
||
| function useUpdateGpsTripOnReconnect() { | ||
| const [gpsDraftDetails] = useOnyx(ONYXKEYS.GPS_DRAFT_DETAILS, {canBeMissing: true}); | ||
|
|
||
| const updateAddressToHumanReadable = async (gpsPoint: GpsDraftDetails['gpsPoints'][number] | undefined, setAddress: typeof setStartAddress) => { | ||
| if (!gpsPoint) { | ||
| return; | ||
| } | ||
|
|
||
| const address = await addressFromGpsPoint(gpsPoint); | ||
|
|
||
| if (address !== null) { | ||
| setAddress({value: address, type: 'address'}); | ||
| } | ||
| }; | ||
|
|
||
| const updateAddressesToHumanReadable = () => { | ||
| if (!gpsDraftDetails) { | ||
| return; | ||
| } | ||
|
|
||
| const {gpsPoints, startAddress, endAddress} = gpsDraftDetails; | ||
|
|
||
| if (startAddress.type === 'coordinates') { | ||
| updateAddressToHumanReadable(gpsPoints.at(0), setStartAddress); | ||
| } | ||
|
|
||
| if (endAddress.type === 'coordinates') { | ||
| updateAddressToHumanReadable(gpsPoints.at(-1), setEndAddress); | ||
| } | ||
| }; | ||
|
|
||
| // This is intentional to use async/await pattern for better readability | ||
| // eslint-disable-next-line @typescript-eslint/no-misused-promises | ||
| useNetwork({onReconnect: updateAddressesToHumanReadable}); | ||
| } | ||
|
|
||
| export default useUpdateGpsTripOnReconnect; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.